All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>, intel-gfx@lists.freedesktop.org
Cc: "Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	jrg2718@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: forward hotplug events again
Date: Fri, 05 Jan 2018 07:31:15 +0000	[thread overview]
Message-ID: <151513747502.6838.14761676154465316049@mail.alporthouse.com> (raw)
In-Reply-To: <20180105014255.4874-1-rodrigo.vivi@intel.com>

Quoting Rodrigo Vivi (2018-01-05 01:42:55)
> As mentioned on commit '88be58be886f ("drm/i915/fbdev:
> Always forward hotplug events") we have real valid cases
> of hotplugs where fbdev is not fully setup yet.
> 
> Unfortunately this remove the checkpoint after the sync point.
> So probably we can live without it. Or we need a more robust
> serialization.

Heh? So you are removing the check as to whether or not the async init
worked. Without the vma, fbdev doesn't exist and the hotplug event will
cause the machine to die (see recent history for examples). I think what
you intend is to always allocate a basic 1024x768 vma if the init config
finds no crtcs to setup.
-Chris

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Lukas Wunner <lukas@wunner.de>,
	jrg2718@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: forward hotplug events again
Date: Fri, 05 Jan 2018 07:31:15 +0000	[thread overview]
Message-ID: <151513747502.6838.14761676154465316049@mail.alporthouse.com> (raw)
In-Reply-To: <20180105014255.4874-1-rodrigo.vivi@intel.com>

Quoting Rodrigo Vivi (2018-01-05 01:42:55)
> As mentioned on commit '88be58be886f ("drm/i915/fbdev:
> Always forward hotplug events") we have real valid cases
> of hotplugs where fbdev is not fully setup yet.
> 
> Unfortunately this remove the checkpoint after the sync point.
> So probably we can live without it. Or we need a more robust
> serialization.

Heh? So you are removing the check as to whether or not the async init
worked. Without the vma, fbdev doesn't exist and the hotplug event will
cause the machine to die (see recent history for examples). I think what
you intend is to always allocate a basic 1024x768 vma if the init config
finds no crtcs to setup.
-Chris

  parent reply	other threads:[~2018-01-05  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05  1:42 [PATCH] drm/i915: forward hotplug events again Rodrigo Vivi
2018-01-05  2:00 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-01-05  7:31 ` Chris Wilson [this message]
2018-01-05  7:31   ` [PATCH] " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=151513747502.6838.14761676154465316049@mail.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jrg2718@gmail.com \
    --cc=lukas@wunner.de \
    --cc=rodrigo.vivi@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.