From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jbacik@fb.com" <jbacik@fb.com>, "tj@kernel.org" <tj@kernel.org>,
"jack@suse.cz" <jack@suse.cz>, "clm@fb.com" <clm@fb.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hoeppner@linux.vnet.ibm.com" <hoeppner@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"sth@linux.vnet.ibm.com" <sth@linux.vnet.ibm.com>,
"kernel-team@fb.com" <kernel-team@fb.com>,
"asamymuthupa@micron.com" <asamymuthupa@micron.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"jianchao.w.wang@oracle.com" <jianchao.w.wang@oracle.com>
Subject: Re: [PATCH 5/8] blk-mq: make blk_abort_request() trigger timeout path
Date: Mon, 8 Jan 2018 22:10:01 +0000 [thread overview]
Message-ID: <1515449400.2909.31.camel@wdc.com> (raw)
In-Reply-To: <20180108191542.379478-6-tj@kernel.org>
T24gTW9uLCAyMDE4LTAxLTA4IGF0IDExOjE1IC0wODAwLCBUZWp1biBIZW8gd3JvdGU6DQo+IEBA
IC0xNTYsMTIgKzE1NiwxMiBAQCB2b2lkIGJsa190aW1lb3V0X3dvcmsoc3RydWN0IHdvcmtfc3Ry
dWN0ICp3b3JrKQ0KPiAgICovDQo+ICB2b2lkIGJsa19hYm9ydF9yZXF1ZXN0KHN0cnVjdCByZXF1
ZXN0ICpyZXEpDQo+ICB7DQo+IC0JaWYgKGJsa19tYXJrX3JxX2NvbXBsZXRlKHJlcSkpDQo+IC0J
CXJldHVybjsNCj4gLQ0KPiAgCWlmIChyZXEtPnEtPm1xX29wcykgew0KPiAtCQlibGtfbXFfcnFf
dGltZWRfb3V0KHJlcSwgZmFsc2UpOw0KPiArCQlyZXEtPmRlYWRsaW5lID0gamlmZmllczsNCj4g
KwkJbW9kX3RpbWVyKCZyZXEtPnEtPnRpbWVvdXQsIDApOw0KPiAgCX0gZWxzZSB7DQo+ICsJCWlm
IChibGtfbWFya19ycV9jb21wbGV0ZShyZXEpKQ0KPiArCQkJcmV0dXJuOw0KPiAgCQlibGtfZGVs
ZXRlX3RpbWVyKHJlcSk7DQo+ICAJCWJsa19ycV90aW1lZF9vdXQocmVxKTsNCj4gIAl9DQoNCk90
aGVyIHJlcS0+ZGVhZGxpbmUgd3JpdGVzIGFyZSBwcm90ZWN0ZWQgYnkgcHJlZW1wdF9kaXNhYmxl
KCksDQp3cml0ZV9zZXFjb3VudF9iZWdpbigmcnEtPmdzdGF0ZV9zZXEpLCB3cml0ZV9zZXFjb3Vu
dF9lbmQoJnJxLT5nc3RhdGVfc2VxKQ0KYW5kIHByZWVtcHRfZW5hYmxlKCkuIEkgdGhpbmsgaXQn
cyBmaW5lIHRoYXQgdGhlIGFib3ZlIHJlcS0+ZGVhZGxpbmUgc3RvcmUNCmRvZXMgbm90IGhhdmUg
dGhhdCBwcm90ZWN0aW9uIGJ1dCBJIGFsc28gdGhpbmsgdGhhdCB0aGF0IGRlc2VydmVzIGEgY29t
bWVudC4NCg0KVGhhbmtzLA0KDQpCYXJ0Lg==
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jbacik@fb.com" <jbacik@fb.com>, "tj@kernel.org" <tj@kernel.org>,
"jack@suse.cz" <jack@suse.cz>, "clm@fb.com" <clm@fb.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hoeppner@linux.vnet.ibm.com" <hoeppner@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"sth@linux.vnet.ibm.com" <sth@linux.vnet.ibm.com>,
"kernel-team@fb.com" <kernel-team@fb.com>,
"asamymuthupa@micron.com" <asamymuthupa@micron.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"jianchao.w.wang@oracle.com" <jianchao.w.wang@oracle.com>
Subject: Re: [PATCH 5/8] blk-mq: make blk_abort_request() trigger timeout path
Date: Mon, 8 Jan 2018 22:10:01 +0000 [thread overview]
Message-ID: <1515449400.2909.31.camel@wdc.com> (raw)
In-Reply-To: <20180108191542.379478-6-tj@kernel.org>
On Mon, 2018-01-08 at 11:15 -0800, Tejun Heo wrote:
> @@ -156,12 +156,12 @@ void blk_timeout_work(struct work_struct *work)
> */
> void blk_abort_request(struct request *req)
> {
> - if (blk_mark_rq_complete(req))
> - return;
> -
> if (req->q->mq_ops) {
> - blk_mq_rq_timed_out(req, false);
> + req->deadline = jiffies;
> + mod_timer(&req->q->timeout, 0);
> } else {
> + if (blk_mark_rq_complete(req))
> + return;
> blk_delete_timer(req);
> blk_rq_timed_out(req);
> }
Other req->deadline writes are protected by preempt_disable(),
write_seqcount_begin(&rq->gstate_seq), write_seqcount_end(&rq->gstate_seq)
and preempt_enable(). I think it's fine that the above req->deadline store
does not have that protection but I also think that that deserves a comment.
Thanks,
Bart.
next prev parent reply other threads:[~2018-01-08 22:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 19:15 [PATCHSET v4] blk-mq: reimplement timeout handling Tejun Heo
2018-01-08 19:15 ` [PATCH 1/8] blk-mq: move hctx lock/unlock into a helper Tejun Heo
2018-01-08 19:24 ` Bart Van Assche
2018-01-08 19:24 ` Bart Van Assche
2018-01-08 19:15 ` [PATCH 2/8] blk-mq: protect completion path with RCU Tejun Heo
2018-01-08 19:57 ` Holger Hoffstätte
2018-01-08 20:15 ` Jens Axboe
2018-01-08 22:55 ` Jens Axboe
2018-01-08 23:27 ` Holger Hoffstätte
2018-01-08 23:33 ` Holger Hoffstätte
2018-01-09 7:08 ` Hannes Reinecke
2018-01-09 15:22 ` Jens Axboe
2018-01-09 16:12 ` Bart Van Assche
2018-01-09 16:12 ` Bart Van Assche
2018-01-09 16:17 ` Jens Axboe
2018-01-09 16:19 ` tj
2018-01-09 16:22 ` Jens Axboe
2018-01-08 19:15 ` [PATCH 3/8] blk-mq: replace timeout synchronization with a RCU and generation based scheme Tejun Heo
2018-01-08 21:06 ` Bart Van Assche
2018-01-08 21:06 ` Bart Van Assche
2018-01-09 15:46 ` tj
2018-01-08 23:29 ` Bart Van Assche
2018-01-08 23:29 ` Bart Van Assche
2018-01-09 15:46 ` tj
2018-01-08 19:15 ` [PATCH 4/8] blk-mq: use blk_mq_rq_state() instead of testing REQ_ATOM_COMPLETE Tejun Heo
2018-01-08 22:03 ` Bart Van Assche
2018-01-08 22:03 ` Bart Van Assche
2018-01-08 19:15 ` [PATCH 5/8] blk-mq: make blk_abort_request() trigger timeout path Tejun Heo
2018-01-08 22:10 ` Bart Van Assche [this message]
2018-01-08 22:10 ` Bart Van Assche
2018-01-09 16:02 ` tj
2018-01-08 19:15 ` [PATCH 6/8] blk-mq: remove REQ_ATOM_COMPLETE usages from blk-mq Tejun Heo
2018-01-08 23:36 ` Bart Van Assche
2018-01-08 23:36 ` Bart Van Assche
2018-01-08 19:15 ` [PATCH 7/8] blk-mq: remove REQ_ATOM_STARTED Tejun Heo
2018-01-08 23:47 ` Bart Van Assche
2018-01-08 23:47 ` Bart Van Assche
2018-01-08 19:15 ` [PATCH 8/8] blk-mq: rename blk_mq_hw_ctx->queue_rq_srcu to ->srcu Tejun Heo
2018-01-08 23:48 ` Bart Van Assche
2018-01-08 23:48 ` Bart Van Assche
2018-01-09 16:29 [PATCHSET v5] blk-mq: reimplement timeout handling Tejun Heo
2018-01-09 16:29 ` [PATCH 5/8] blk-mq: make blk_abort_request() trigger timeout path Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515449400.2909.31.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=asamymuthupa@micron.com \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=hoeppner@linux.vnet.ibm.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=jianchao.w.wang@oracle.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sth@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.