From: Masahiro Yamada <yamada.masahiro@socionext.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: David Howells <dhowells@redhat.com>, linux-arm-kernel@lists.infradead.org, Masahiro Yamada <yamada.masahiro@socionext.com>, linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>, linux-m68k@vger.kernel.org, Guan Xuetao <gxt@mprc.pku.edu.cn>, Geert Uytterhoeven <geert@linux-m68k.org>, Catalin Marinas <catalin.marinas@arm.com>, Russell King <linux@armlinux.org.uk> Subject: [PATCH v3 0/5] linux/const.h: cleanups of macros such as UL(), _BITUL(), BIT() etc. Date: Thu, 22 Feb 2018 21:15:10 +0900 [thread overview] Message-ID: <1519301715-31798-1-git-send-email-yamada.masahiro@socionext.com> (raw) ARM, ARM64, UniCore32 define UL() as a shorthand of _AC(..., UL). More architectures may introduce it in the future. UL() is arch-agnostic, and useful. So let's move it to include/linux/const.h Currently, <asm/memory.h> must be included to use UL(). It pulls in more bloats just for defining some bit macros. I posted V2 one year ago. The previous posts are: https://patchwork.kernel.org/patch/9498273/ https://patchwork.kernel.org/patch/9498275/ https://patchwork.kernel.org/patch/9498269/ https://patchwork.kernel.org/patch/9498271/ At that time, what blocked this series was a comment from David Howells: You need to be very careful doing this. Some userspace stuff depends on the guard macro names on the kernel header files. (https://patchwork.kernel.org/patch/9498275/) Looking at the code closer, I noticed this is not a problem. See the following line. https://github.com/torvalds/linux/blob/v4.16-rc2/scripts/headers_install.sh#L40 scripts/headers_install.sh rips off _UAPI prefix from guard macro names. I ran "make headers_install" and confirmed the result is what I expect. So, we can prefix the include guard of include/uapi/linux/const.h, and add a new include/linux/const.h. Masahiro Yamada (5): linux/const.h: prefix include guard of uapi/linux/const.h with _UAPI m68k: rename UL() to TO_UL() linux/const.h: move UL() macro to include/linux/const.h linux/const.h: refactor _BITUL and _BITULL a bit linux/const.h: move BIT(_ULL) to linux/const.h for use in assembly arch/arm/include/asm/memory.h | 6 ------ arch/arm64/include/asm/memory.h | 6 ------ arch/m68k/mm/init.c | 6 +++--- arch/unicore32/include/asm/memory.h | 6 ------ include/linux/bitops.h | 3 +-- include/linux/const.h | 12 ++++++++++++ include/uapi/linux/const.h | 13 ++++++++----- 7 files changed, 24 insertions(+), 28 deletions(-) create mode 100644 include/linux/const.h -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: yamada.masahiro@socionext.com (Masahiro Yamada) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 0/5] linux/const.h: cleanups of macros such as UL(), _BITUL(), BIT() etc. Date: Thu, 22 Feb 2018 21:15:10 +0900 [thread overview] Message-ID: <1519301715-31798-1-git-send-email-yamada.masahiro@socionext.com> (raw) ARM, ARM64, UniCore32 define UL() as a shorthand of _AC(..., UL). More architectures may introduce it in the future. UL() is arch-agnostic, and useful. So let's move it to include/linux/const.h Currently, <asm/memory.h> must be included to use UL(). It pulls in more bloats just for defining some bit macros. I posted V2 one year ago. The previous posts are: https://patchwork.kernel.org/patch/9498273/ https://patchwork.kernel.org/patch/9498275/ https://patchwork.kernel.org/patch/9498269/ https://patchwork.kernel.org/patch/9498271/ At that time, what blocked this series was a comment from David Howells: You need to be very careful doing this. Some userspace stuff depends on the guard macro names on the kernel header files. (https://patchwork.kernel.org/patch/9498275/) Looking at the code closer, I noticed this is not a problem. See the following line. https://github.com/torvalds/linux/blob/v4.16-rc2/scripts/headers_install.sh#L40 scripts/headers_install.sh rips off _UAPI prefix from guard macro names. I ran "make headers_install" and confirmed the result is what I expect. So, we can prefix the include guard of include/uapi/linux/const.h, and add a new include/linux/const.h. Masahiro Yamada (5): linux/const.h: prefix include guard of uapi/linux/const.h with _UAPI m68k: rename UL() to TO_UL() linux/const.h: move UL() macro to include/linux/const.h linux/const.h: refactor _BITUL and _BITULL a bit linux/const.h: move BIT(_ULL) to linux/const.h for use in assembly arch/arm/include/asm/memory.h | 6 ------ arch/arm64/include/asm/memory.h | 6 ------ arch/m68k/mm/init.c | 6 +++--- arch/unicore32/include/asm/memory.h | 6 ------ include/linux/bitops.h | 3 +-- include/linux/const.h | 12 ++++++++++++ include/uapi/linux/const.h | 13 ++++++++----- 7 files changed, 24 insertions(+), 28 deletions(-) create mode 100644 include/linux/const.h -- 2.7.4
next reply other threads:[~2018-02-22 12:17 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-22 12:15 Masahiro Yamada [this message] 2018-02-22 12:15 ` [PATCH v3 0/5] linux/const.h: cleanups of macros such as UL(), _BITUL(), BIT() etc Masahiro Yamada 2018-02-22 12:15 ` [PATCH v3 1/5] linux/const.h: prefix include guard of uapi/linux/const.h with _UAPI Masahiro Yamada 2018-02-22 12:15 ` Masahiro Yamada 2018-02-22 12:15 ` [PATCH v3 2/5] m68k: rename UL() to TO_UL() Masahiro Yamada 2018-02-22 12:15 ` Masahiro Yamada 2018-02-22 13:20 ` Geert Uytterhoeven 2018-02-22 13:20 ` Geert Uytterhoeven 2018-02-22 16:58 ` Masahiro Yamada 2018-02-22 16:58 ` Masahiro Yamada 2018-02-26 9:49 ` Geert Uytterhoeven 2018-02-26 9:49 ` Geert Uytterhoeven 2018-02-22 12:15 ` [PATCH v3 3/5] linux/const.h: move UL() macro to include/linux/const.h Masahiro Yamada 2018-02-22 12:15 ` Masahiro Yamada 2018-02-22 12:15 ` [PATCH v3 4/5] linux/const.h: refactor _BITUL and _BITULL a bit Masahiro Yamada 2018-02-22 12:15 ` Masahiro Yamada 2018-02-22 12:15 ` [PATCH v3 5/5] linux/const.h: move BIT(_ULL) to linux/const.h for use in assembly Masahiro Yamada 2018-02-22 12:15 ` Masahiro Yamada 2018-02-24 5:00 ` kbuild test robot 2018-02-24 5:00 ` kbuild test robot 2018-02-26 2:13 ` Masahiro Yamada 2018-02-26 2:13 ` Masahiro Yamada 2018-03-13 8:39 ` Masahiro Yamada 2018-03-13 8:39 ` Masahiro Yamada
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1519301715-31798-1-git-send-email-yamada.masahiro@socionext.com \ --to=yamada.masahiro@socionext.com \ --cc=akpm@linux-foundation.org \ --cc=catalin.marinas@arm.com \ --cc=dhowells@redhat.com \ --cc=geert@linux-m68k.org \ --cc=gxt@mprc.pku.edu.cn \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-m68k@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.