All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] tpm: factor out tpm 1.2 duration calculation to tpm1-cmd.c
Date: Tue, 06 Mar 2018 13:19:54 +0200	[thread overview]
Message-ID: <1520335194.7549.7.camel@linux.intel.com> (raw)
In-Reply-To: <20180305202017.24008-3-tomas.winkler@intel.com>

On Mon, 2018-03-05 at 22:20 +0200, Tomas Winkler wrote:
> Factor out tpm1.2 commands calculation into tpm1-cmd.c file.
> and change the prefix from tpm_ to tpm1_.
> No functional change is done here.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

This a good idea but can you go on and move all TPM 1.x stuff to
this new file while you are doing it?

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 2/6] tpm: factor out tpm 1.2 duration calculation to tpm1-cmd.c
Date: Tue, 06 Mar 2018 13:19:54 +0200	[thread overview]
Message-ID: <1520335194.7549.7.camel@linux.intel.com> (raw)
In-Reply-To: <20180305202017.24008-3-tomas.winkler@intel.com>

On Mon, 2018-03-05 at 22:20 +0200, Tomas Winkler wrote:
> Factor out tpm1.2 commands calculation into tpm1-cmd.c file.
> and change the prefix from tpm_ to tpm1_.
> No functional change is done here.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

This a good idea but can you go on and move all TPM 1.x stuff to
this new file while you are doing it?

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-03-06 11:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05 20:20 [PATCH 0/6] tpm: timeouts revamp Tomas Winkler
2018-03-05 20:20 ` Tomas Winkler
2018-03-05 20:20 ` [PATCH 1/6] tpm: sort objects in the Makefile Tomas Winkler
2018-03-05 20:20   ` Tomas Winkler
2018-03-05 21:12   ` Jason Gunthorpe
2018-03-05 21:12     ` Jason Gunthorpe
2018-03-05 21:21     ` Winkler, Tomas
2018-03-05 21:21       ` Winkler, Tomas
2018-03-05 22:08       ` Jason Gunthorpe
2018-03-05 22:08         ` Jason Gunthorpe
2018-03-05 23:11         ` Winkler, Tomas
2018-03-05 23:11           ` Winkler, Tomas
2018-03-05 20:20 ` [PATCH 2/6] tpm: factor out tpm 1.2 duration calculation to tpm1-cmd.c Tomas Winkler
2018-03-05 20:20   ` Tomas Winkler
2018-03-06 11:19   ` Jarkko Sakkinen [this message]
2018-03-06 11:19     ` Jarkko Sakkinen
2018-03-06 11:21     ` Winkler, Tomas
2018-03-06 11:21       ` Winkler, Tomas
2018-03-06 13:55       ` Jarkko Sakkinen
2018-03-06 13:55         ` Jarkko Sakkinen
2018-03-05 20:20 ` [PATCH 3/6] tpm2: add longer timeouts for creation commands Tomas Winkler
2018-03-05 20:20   ` Tomas Winkler
2018-03-05 20:20 ` [PATCH 4/6] tpm2: add new tpm2 commands according to TCG 1.36 Tomas Winkler
2018-03-05 20:20   ` Tomas Winkler
2018-03-05 20:20 ` [PATCH 5/6] tmp: factor out tpm_get_timeouts Tomas Winkler
2018-03-05 20:20   ` Tomas Winkler
2018-03-05 20:20 ` [PATCH 6/6] tpm: tpm-interface: drop unused tpm_input_header headers Tomas Winkler
2018-03-05 20:20   ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520335194.7549.7.camel@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.