From: <twischer@de.adit-jv.com>
To: tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [PATCH - JACK plugin] jack: Use internal snd_pcm_state to reduce amount of additional variables
Date: Thu, 15 Mar 2018 13:56:26 +0100 [thread overview]
Message-ID: <1521118587-6319-1-git-send-email-twischer@de.adit-jv.com> (raw)
In-Reply-To: <s5hefl3izpf.wl-tiwai@suse.de>
Hello Takashi,
> So in which situation would io->state and jack->state differ with each
> other? Only DRAINING and XRUN, or in other cases?
I have extended the commit message:
Therefore this internal state variable is not always in sync with
io->state. In addition the internal state variable will be updated after
the corresponding callback function was processed and not before the
callback function was called (e.g. PREPARE and RUNNING).
Therefore the internal state will always contain the state
which is currently active.
It will keep the old state as long as the transition to the new one was successfully finished
See attached the updated patch which can be applied without conflicts.
Best regards,
Timo
next prev parent reply other threads:[~2018-03-15 12:56 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 11:53 [PATCH - JACK PCM plugin] jack: Do not Xrun the ALSA buffer twischer
2018-02-26 8:14 ` Wischer, Timo (ADITG/ESB)
2018-02-27 8:48 ` Takashi Iwai
2018-03-01 13:14 ` [PATCH - JACK PCM plugin] Xrun handling twischer
2018-03-01 13:14 ` [PATCH - JACK plugin 1/4] jack: Do not Xrun the ALSA buffer twischer
2018-03-01 15:24 ` Takashi Iwai
2018-03-02 16:21 ` twischer
2018-03-02 16:21 ` [PATCH - PCM 2/3] pcm: ioplug: Provide hw_avail helper function for plugins twischer
2018-03-02 16:21 ` [PATCH - PCM 3/3] pcm: Provide areas_copy function which handles buffer wrap around twischer
2018-03-02 16:21 ` [PATCH - JACK 1/1] jack: Do not Xrun the ALSA buffer twischer
2018-03-13 8:34 ` [PATCH - JACK plugin] " twischer
2018-03-13 8:34 ` [PATCH - PCM 1/2] pcm: ioplug: Provide hw_avail helper function for plugins twischer
2018-03-13 8:34 ` [PATCH - PCM 2/2] pcm: Provide areas_copy function which handles buffer wrap around twischer
2018-03-13 8:34 ` [PATCH - JACK 1/1] jack: Do not Xrun the ALSA buffer twischer
2018-03-13 21:20 ` [PATCH - JACK plugin] " Takashi Iwai
2018-03-15 15:09 ` Wischer, Timo (ADITG/ESB)
2018-03-15 15:13 ` Takashi Iwai
2018-03-01 13:14 ` [PATCH - JACK plugin 2/4] jack: Use internal snd_pcm_state to reduce amount of additional variables twischer
2018-03-01 15:26 ` Takashi Iwai
2018-03-15 12:56 ` twischer [this message]
2018-03-15 12:56 ` [PATCH - JACK 1/1] " twischer
2018-03-15 13:14 ` Takashi Iwai
2018-03-15 14:05 ` Wischer, Timo (ADITG/ESB)
2018-03-15 14:20 ` Takashi Iwai
2018-03-15 15:07 ` Wischer, Timo (ADITG/ESB)
2018-03-15 15:49 ` Takashi Iwai
2018-03-16 10:02 ` [PATCH - IOPLUG] Update prepare and draining state correctly twischer
2018-03-16 10:02 ` [PATCH - IOPLUG 1/1] pcm: ioplug: update Prepare " twischer
2018-03-16 10:08 ` Takashi Iwai
2018-03-16 10:20 ` [PATCH - IOPLUG 1/1] pcm: ioplug: update prepare " twischer
2018-03-16 10:30 ` Takashi Iwai
2018-03-01 13:14 ` [PATCH - JACK plugin 3/4] jack: Report Xruns to user application twischer
2018-03-16 14:23 ` twischer
2018-03-16 14:23 ` [PATCH - JACK 1/1] " twischer
2018-03-16 14:41 ` Takashi Iwai
2018-03-16 14:47 ` Wischer, Timo (ADITG/ESB)
2018-03-16 14:57 ` Takashi Iwai
2018-03-01 13:14 ` [PATCH - JACK plugin 4/4] jack: Support snd_pcm_drain() twischer
2018-03-01 13:41 ` Jaroslav Kysela
2018-03-16 14:44 ` Wischer, Timo (ADITG/ESB)
2018-03-16 15:11 ` Jaroslav Kysela
2018-03-16 15:52 ` Wischer, Timo (ADITG/ESB)
2018-03-21 16:22 ` Wischer, Timo (ADITG/ESB)
2018-03-21 16:34 ` Takashi Iwai
2018-03-21 16:47 ` Wischer, Timo (ADITG/ESB)
2018-03-21 16:52 ` Takashi Iwai
2018-03-21 17:02 ` Wischer, Timo (ADITG/ESB)
2018-03-21 17:07 ` Takashi Iwai
2018-03-01 15:19 ` [PATCH - JACK PCM plugin] Xrun handling Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521118587-6319-1-git-send-email-twischer@de.adit-jv.com \
--to=twischer@de.adit-jv.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.