Re: [PATCH - IOPLUG 1/1] pcm: ioplug: update prepare and draining state correctly

From: Takashi Iwai <tiwai@suse.de>
To: twischer@de.adit-jv.com
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH - IOPLUG 1/1] pcm: ioplug: update prepare and draining state correctly
Date: Fri, 16 Mar 2018 11:30:00 +0100	[thread overview]
Message-ID: <s5hfu505n4n.wl-tiwai@suse.de> (raw)
In-Reply-To: <1521195646-21615-1-git-send-email-twischer@de.adit-jv.com>

On Fri, 16 Mar 2018 11:20:46 +0100,
<twischer@de.adit-jv.com> wrote:
> 
> From: Timo Wischer <twischer@de.adit-jv.com>
> 
> PREPARED should only be set when it is done and it was successfully.
> 
> DRAINING should be signalled when starting to drain. There is no need to
> check if draining was successfully because it will change to drop (SETUP)
> in any case.
> 
> Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
> 
> diff --git a/ChangeLog b/ChangeLog
> index 22df356..3dff7fb 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,4 @@
> +* Set IO plug state to PREPARED after calling the IO plugin prepare callback
>  * update to libtool 1.3.3
>  
>  0.1.3 -> 0.2.0

No, no, this wasn't what I meant.  This ChangeLog file is actually
dead, remaining only for historical reason.

In the previous patch, you didn't mention the exact change you've made
in the patch description.  That is, the behavior were silently
modified.  This must not be done, it fools the users.

So, if you want to change something, especially if it's about the
behavior change, it has to be clearly documented in the patch
description and/or in the code itself.

In anyway, no need for resend: I dropped the ChangeLog file change but
applied the rest.

thanks,

Takashi