From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Amit Nischal <anischal@codeaurora.org>
Subject: Re: [PATCH v2 1/4] clk: qcom: Clear hardware clock control bit of RCG
Date: Mon, 19 Mar 2018 15:55:21 -0700 [thread overview]
Message-ID: <152150012178.254778.7302484360542115877@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1520493495-3084-2-git-send-email-anischal@codeaurora.org>
Quoting Amit Nischal (2018-03-07 23:18:12)
> For upcoming targets like sdm845, POR value of the hardware clock control
> bit is set for most of root clocks which needs to be cleared for software
> to be able to control. For older targets like MSM8996, this bit is reserved
> bit and having POR value as 0 so this patch will work for the older targets
> too. So update the configuration mask to take care of the same to clear
> hardware clock control bit.
>
> Signed-off-by: Amit Nischal <anischal@codeaurora.org>
> ---
> drivers/clk/qcom/clk-rcg2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
> index bbeaf9c..e63db10 100644
> --- a/drivers/clk/qcom/clk-rcg2.c
> +++ b/drivers/clk/qcom/clk-rcg2.c
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2013, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2013, 2018, The Linux Foundation. All rights reserved.
It would be nice if lawyers over there could avoid forcing copyright
date updates when less than half the file changes.
> *
> * This software is licensed under the terms of the GNU General Public
> * License version 2, as published by the Free Software Foundation, and
> @@ -42,6 +42,7 @@
> #define CFG_MODE_SHIFT 12
> #define CFG_MODE_MASK (0x3 << CFG_MODE_SHIFT)
> #define CFG_MODE_DUAL_EDGE (0x2 << CFG_MODE_SHIFT)
> +#define CFG_HW_CLK_CTRL_MASK BIT(20)
>
> #define M_REG 0x8
> #define N_REG 0xc
> @@ -276,7 +277,7 @@ static int clk_rcg2_configure(struct clk_rcg2 *rcg, const struct freq_tbl *f)
> }
>
> mask = BIT(rcg->hid_width) - 1;
> - mask |= CFG_SRC_SEL_MASK | CFG_MODE_MASK;
> + mask |= CFG_SRC_SEL_MASK | CFG_MODE_MASK | CFG_HW_CLK_CTRL_MASK;
> cfg = f->pre_div << CFG_SRC_DIV_SHIFT;
> cfg |= rcg->parent_map[index].cfg << CFG_SRC_SEL_SHIFT;
> if (rcg->mnd_width && f->n && (f->m != f->n))
Is there going to be a future patch to update the RCGs to indicate they
support hardware control or not?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Amit Nischal <anischal@codeaurora.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Amit Nischal <anischal@codeaurora.org>
Subject: Re: [PATCH v2 1/4] clk: qcom: Clear hardware clock control bit of RCG
Date: Mon, 19 Mar 2018 15:55:21 -0700 [thread overview]
Message-ID: <152150012178.254778.7302484360542115877@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1520493495-3084-2-git-send-email-anischal@codeaurora.org>
Quoting Amit Nischal (2018-03-07 23:18:12)
> For upcoming targets like sdm845, POR value of the hardware clock control
> bit is set for most of root clocks which needs to be cleared for software
> to be able to control. For older targets like MSM8996, this bit is reserved
> bit and having POR value as 0 so this patch will work for the older targets
> too. So update the configuration mask to take care of the same to clear
> hardware clock control bit.
>
> Signed-off-by: Amit Nischal <anischal@codeaurora.org>
> ---
> drivers/clk/qcom/clk-rcg2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
> index bbeaf9c..e63db10 100644
> --- a/drivers/clk/qcom/clk-rcg2.c
> +++ b/drivers/clk/qcom/clk-rcg2.c
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2013, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2013, 2018, The Linux Foundation. All rights reserved.
It would be nice if lawyers over there could avoid forcing copyright
date updates when less than half the file changes.
> *
> * This software is licensed under the terms of the GNU General Public
> * License version 2, as published by the Free Software Foundation, and
> @@ -42,6 +42,7 @@
> #define CFG_MODE_SHIFT 12
> #define CFG_MODE_MASK (0x3 << CFG_MODE_SHIFT)
> #define CFG_MODE_DUAL_EDGE (0x2 << CFG_MODE_SHIFT)
> +#define CFG_HW_CLK_CTRL_MASK BIT(20)
>
> #define M_REG 0x8
> #define N_REG 0xc
> @@ -276,7 +277,7 @@ static int clk_rcg2_configure(struct clk_rcg2 *rcg, const struct freq_tbl *f)
> }
>
> mask = BIT(rcg->hid_width) - 1;
> - mask |= CFG_SRC_SEL_MASK | CFG_MODE_MASK;
> + mask |= CFG_SRC_SEL_MASK | CFG_MODE_MASK | CFG_HW_CLK_CTRL_MASK;
> cfg = f->pre_div << CFG_SRC_DIV_SHIFT;
> cfg |= rcg->parent_map[index].cfg << CFG_SRC_SEL_SHIFT;
> if (rcg->mnd_width && f->n && (f->m != f->n))
Is there going to be a future patch to update the RCGs to indicate they
support hardware control or not?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Amit Nischal <anischal@codeaurora.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Amit Nischal <anischal@codeaurora.org>
Subject: Re: [PATCH v2 1/4] clk: qcom: Clear hardware clock control bit of RCG
Date: Mon, 19 Mar 2018 15:55:21 -0700 [thread overview]
Message-ID: <152150012178.254778.7302484360542115877@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1520493495-3084-2-git-send-email-anischal@codeaurora.org>
Quoting Amit Nischal (2018-03-07 23:18:12)
> For upcoming targets like sdm845, POR value of the hardware clock control
> bit is set for most of root clocks which needs to be cleared for software
> to be able to control. For older targets like MSM8996, this bit is reserv=
ed
> bit and having POR value as 0 so this patch will work for the older targe=
ts
> too. So update the configuration mask to take care of the same to clear
> hardware clock control bit.
> =
> Signed-off-by: Amit Nischal <anischal@codeaurora.org>
> ---
> drivers/clk/qcom/clk-rcg2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> =
> diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
> index bbeaf9c..e63db10 100644
> --- a/drivers/clk/qcom/clk-rcg2.c
> +++ b/drivers/clk/qcom/clk-rcg2.c
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2013, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2013, 2018, The Linux Foundation. All rights reserved.
It would be nice if lawyers over there could avoid forcing copyright
date updates when less than half the file changes.
> *
> * This software is licensed under the terms of the GNU General Public
> * License version 2, as published by the Free Software Foundation, and
> @@ -42,6 +42,7 @@
> #define CFG_MODE_SHIFT 12
> #define CFG_MODE_MASK (0x3 << CFG_MODE_SHIFT)
> #define CFG_MODE_DUAL_EDGE (0x2 << CFG_MODE_SHIFT)
> +#define CFG_HW_CLK_CTRL_MASK BIT(20)
> =
> #define M_REG 0x8
> #define N_REG 0xc
> @@ -276,7 +277,7 @@ static int clk_rcg2_configure(struct clk_rcg2 *rcg, c=
onst struct freq_tbl *f)
> }
> =
> mask =3D BIT(rcg->hid_width) - 1;
> - mask |=3D CFG_SRC_SEL_MASK | CFG_MODE_MASK;
> + mask |=3D CFG_SRC_SEL_MASK | CFG_MODE_MASK | CFG_HW_CLK_CTRL_MASK;
> cfg =3D f->pre_div << CFG_SRC_DIV_SHIFT;
> cfg |=3D rcg->parent_map[index].cfg << CFG_SRC_SEL_SHIFT;
> if (rcg->mnd_width && f->n && (f->m !=3D f->n))
Is there going to be a future patch to update the RCGs to indicate they
support hardware control or not?
next prev parent reply other threads:[~2018-03-19 22:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 7:18 [PATCH v2 0/4] Misc patches to support clocks for SDM845 Amit Nischal
2018-03-08 7:18 ` [PATCH v2 1/4] clk: qcom: Clear hardware clock control bit of RCG Amit Nischal
2018-03-19 22:55 ` Stephen Boyd [this message]
2018-03-19 22:55 ` Stephen Boyd
2018-03-19 22:55 ` Stephen Boyd
2018-03-26 5:19 ` Nischal, Amit
2018-03-08 7:18 ` [PATCH v2 2/4] clk: qcom: Configure the RCGs to a safe source as needed Amit Nischal
2018-03-20 0:30 ` Stephen Boyd
2018-03-20 0:30 ` Stephen Boyd
2018-03-20 0:30 ` Stephen Boyd
2018-04-03 8:52 ` Amit Nischal
2018-03-08 7:18 ` [PATCH v2 3/4] clk: qcom: Add support for controlling Fabia PLL Amit Nischal
2018-03-19 23:33 ` Stephen Boyd
2018-03-19 23:33 ` Stephen Boyd
2018-03-19 23:33 ` Stephen Boyd
2018-03-08 7:18 ` [PATCH v2 4/4] clk: qcom: Add Global Clock controller (GCC) driver for SDM845 Amit Nischal
2018-03-20 0:42 ` Stephen Boyd
2018-03-20 0:42 ` Stephen Boyd
2018-03-20 0:42 ` Stephen Boyd
2018-04-03 12:24 ` Amit Nischal
2018-04-05 22:57 ` Stephen Boyd
2018-04-05 22:57 ` Stephen Boyd
2018-04-09 5:25 ` Amit Nischal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152150012178.254778.7302484360542115877@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=andy.gross@linaro.org \
--cc=anischal@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=okukatla@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.