From: Ryder Lee <ryder.lee@mediatek.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>,
"Garlic Tseng" <garlic.tseng@mediatek.com>
Subject: Re: [PATCH v4 3/6] clk: mediatek: add audsys support for MT2701
Date: Tue, 20 Mar 2018 14:38:52 +0800 [thread overview]
Message-ID: <1521527932.21199.4.camel@mtkswgap22> (raw)
In-Reply-To: <152149148431.242365.4625152577833480987@swboyd.mtv.corp.google.com>
On Mon, 2018-03-19 at 13:31 -0700, Stephen Boyd wrote:
> Quoting Ryder Lee (2018-03-06 01:09:28)
> > +
> > +static const struct of_device_id of_match_clk_mt2701_aud[] = {
> > + { .compatible = "mediatek,mt2701-audsys", },
> > + {}
> > +};
> > +
> > +static int clk_mt2701_aud_probe(struct platform_device *pdev)
> > +{
> > + struct clk_onecell_data *clk_data;
> > + struct device_node *node = pdev->dev.of_node;
> > + int r;
> > +
> > + clk_data = mtk_alloc_clk_data(CLK_AUD_NR);
> > +
> > + mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks),
> > + clk_data);
> > +
> > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
> > + if (r) {
> > + dev_err(&pdev->dev,
> > + "could not register clock provider: %s: %d\n",
> > + pdev->name, r);
> > +
> > + return r;
> > + }
>
> This fails to remove the clk provider when devm_of_platform_populate()
> returns an error.
>
> > +
> > + return devm_of_platform_populate(&pdev->dev);
> > +}
I've sent a new one to fix it.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Ryder Lee <ryder.lee@mediatek.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org,
Garlic Tseng <garlic.tseng@mediatek.com>
Subject: Re: [PATCH v4 3/6] clk: mediatek: add audsys support for MT2701
Date: Tue, 20 Mar 2018 14:38:52 +0800 [thread overview]
Message-ID: <1521527932.21199.4.camel@mtkswgap22> (raw)
In-Reply-To: <152149148431.242365.4625152577833480987@swboyd.mtv.corp.google.com>
On Mon, 2018-03-19 at 13:31 -0700, Stephen Boyd wrote:
> Quoting Ryder Lee (2018-03-06 01:09:28)
> > +
> > +static const struct of_device_id of_match_clk_mt2701_aud[] = {
> > + { .compatible = "mediatek,mt2701-audsys", },
> > + {}
> > +};
> > +
> > +static int clk_mt2701_aud_probe(struct platform_device *pdev)
> > +{
> > + struct clk_onecell_data *clk_data;
> > + struct device_node *node = pdev->dev.of_node;
> > + int r;
> > +
> > + clk_data = mtk_alloc_clk_data(CLK_AUD_NR);
> > +
> > + mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks),
> > + clk_data);
> > +
> > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
> > + if (r) {
> > + dev_err(&pdev->dev,
> > + "could not register clock provider: %s: %d\n",
> > + pdev->name, r);
> > +
> > + return r;
> > + }
>
> This fails to remove the clk provider when devm_of_platform_populate()
> returns an error.
>
> > +
> > + return devm_of_platform_populate(&pdev->dev);
> > +}
I've sent a new one to fix it.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: ryder.lee@mediatek.com (Ryder Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/6] clk: mediatek: add audsys support for MT2701
Date: Tue, 20 Mar 2018 14:38:52 +0800 [thread overview]
Message-ID: <1521527932.21199.4.camel@mtkswgap22> (raw)
In-Reply-To: <152149148431.242365.4625152577833480987@swboyd.mtv.corp.google.com>
On Mon, 2018-03-19 at 13:31 -0700, Stephen Boyd wrote:
> Quoting Ryder Lee (2018-03-06 01:09:28)
> > +
> > +static const struct of_device_id of_match_clk_mt2701_aud[] = {
> > + { .compatible = "mediatek,mt2701-audsys", },
> > + {}
> > +};
> > +
> > +static int clk_mt2701_aud_probe(struct platform_device *pdev)
> > +{
> > + struct clk_onecell_data *clk_data;
> > + struct device_node *node = pdev->dev.of_node;
> > + int r;
> > +
> > + clk_data = mtk_alloc_clk_data(CLK_AUD_NR);
> > +
> > + mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks),
> > + clk_data);
> > +
> > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
> > + if (r) {
> > + dev_err(&pdev->dev,
> > + "could not register clock provider: %s: %d\n",
> > + pdev->name, r);
> > +
> > + return r;
> > + }
>
> This fails to remove the clk provider when devm_of_platform_populate()
> returns an error.
>
> > +
> > + return devm_of_platform_populate(&pdev->dev);
> > +}
I've sent a new one to fix it.
Thanks
next prev parent reply other threads:[~2018-03-20 6:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1520327262.git.ryder.lee@mediatek.com>
2018-03-06 9:09 ` [PATCH v4 1/6] clk: mediatek: update missing clock data for MT7622 audsys Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-19 20:41 ` Stephen Boyd
2018-03-19 20:41 ` Stephen Boyd
2018-03-19 20:41 ` Stephen Boyd
2018-03-19 20:41 ` Stephen Boyd
2018-03-06 9:09 ` [PATCH v4 2/6] clk: mediatek: add devm_of_platform_populate() " Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-19 20:31 ` Stephen Boyd
2018-03-19 20:31 ` Stephen Boyd
2018-03-19 20:31 ` Stephen Boyd
2018-03-06 9:09 ` [PATCH v4 3/6] clk: mediatek: add audsys support for MT2701 Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-19 20:31 ` Stephen Boyd
2018-03-19 20:31 ` Stephen Boyd
2018-03-19 20:31 ` Stephen Boyd
2018-03-19 20:31 ` Stephen Boyd
2018-03-20 6:38 ` Ryder Lee [this message]
2018-03-20 6:38 ` Ryder Lee
2018-03-20 6:38 ` Ryder Lee
2018-03-06 9:09 ` [PATCH v4 4/6] dt-bindings: clock: mediatek: update audsys documentation to adapt MFD device Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-19 20:41 ` Stephen Boyd
2018-03-19 20:41 ` Stephen Boyd
2018-03-19 20:41 ` Stephen Boyd
2018-03-06 9:09 ` [PATCH v4 5/6] dt-bindings: clock: mediatek: add audsys support for MT2701 Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-19 20:41 ` Stephen Boyd
2018-03-19 20:41 ` Stephen Boyd
2018-03-19 20:41 ` Stephen Boyd
2018-03-06 9:09 ` [PATCH v4 6/6] arm: dts: mediatek: modify audio related nodes for both MT2701 and MT7623 Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-03-06 9:09 ` Ryder Lee
2018-04-17 14:26 ` Matthias Brugger
2018-04-17 14:26 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521527932.21199.4.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=garlic.tseng@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.