From: Dan Williams <dan.j.williams@intel.com>
To: linux-nvdimm@lists.01.org
Cc: "Michal Hocko" <mhocko@suse.com>,
jack@suse.cz, snitzer@redhat.com, david@fromorbit.com,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
"Jérôme Glisse" <jglisse@redhat.com>,
linux-fsdevel@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>
Subject: [PATCH v8 14/18] memremap: mark devm_memremap_pages() EXPORT_SYMBOL_GPL
Date: Fri, 30 Mar 2018 21:03:25 -0700 [thread overview]
Message-ID: <152246900495.36038.12673192605922080966.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <152246892890.36038.18436540150980653229.stgit@dwillia2-desk3.amr.corp.intel.com>
The devm_memremap_pages() facility is tightly integrated with the
kernel's memory hotplug functionality. It injects an altmap argument
deep into the architecture specific vmemmap implementation to allow
allocating from specific reserved pages, and it has Linux specific
assumptions about page structure reference counting relative to
get_user_pages() and get_user_pages_fast(). It was an oversight that
this was not marked EXPORT_SYMBOL_GPL from the outset.
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Jérôme Glisse" <jglisse@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
kernel/memremap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/memremap.c b/kernel/memremap.c
index 07a6a405cf3d..4b0e17df8981 100644
--- a/kernel/memremap.c
+++ b/kernel/memremap.c
@@ -257,7 +257,7 @@ void *devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap)
devres_free(pgmap);
return ERR_PTR(error);
}
-EXPORT_SYMBOL(devm_memremap_pages);
+EXPORT_SYMBOL_GPL(devm_memremap_pages);
unsigned long vmem_altmap_offset(struct vmem_altmap *altmap)
{
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: linux-nvdimm@lists.01.org
Cc: "Michal Hocko" <mhocko@suse.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Christoph Hellwig" <hch@lst.de>,
david@fromorbit.com, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
jack@suse.cz, snitzer@redhat.com
Subject: [PATCH v8 14/18] memremap: mark devm_memremap_pages() EXPORT_SYMBOL_GPL
Date: Fri, 30 Mar 2018 21:03:25 -0700 [thread overview]
Message-ID: <152246900495.36038.12673192605922080966.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <152246892890.36038.18436540150980653229.stgit@dwillia2-desk3.amr.corp.intel.com>
The devm_memremap_pages() facility is tightly integrated with the
kernel's memory hotplug functionality. It injects an altmap argument
deep into the architecture specific vmemmap implementation to allow
allocating from specific reserved pages, and it has Linux specific
assumptions about page structure reference counting relative to
get_user_pages() and get_user_pages_fast(). It was an oversight that
this was not marked EXPORT_SYMBOL_GPL from the outset.
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Jérôme Glisse" <jglisse@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
kernel/memremap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/memremap.c b/kernel/memremap.c
index 07a6a405cf3d..4b0e17df8981 100644
--- a/kernel/memremap.c
+++ b/kernel/memremap.c
@@ -257,7 +257,7 @@ void *devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap)
devres_free(pgmap);
return ERR_PTR(error);
}
-EXPORT_SYMBOL(devm_memremap_pages);
+EXPORT_SYMBOL_GPL(devm_memremap_pages);
unsigned long vmem_altmap_offset(struct vmem_altmap *altmap)
{
next prev parent reply other threads:[~2018-03-31 4:13 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-31 4:02 [PATCH v8 00/18] dax: fix dma vs truncate/hole-punch Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` [PATCH v8 01/18] dax: store pfns in the radix Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` [PATCH v8 02/18] fs, dax: prepare for dax-specific address_space_operations Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` [PATCH v8 03/18] block, dax: remove dead code in blkdev_writepages() Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` [PATCH v8 04/18] xfs, dax: introduce xfs_dax_aops Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` [PATCH v8 05/18] ext4, dax: introduce ext4_dax_aops Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-04-03 11:50 ` Jan Kara
2018-04-03 11:50 ` Jan Kara
2018-04-03 11:50 ` Jan Kara
2018-03-31 4:02 ` [PATCH v8 06/18] ext2, dax: introduce ext2_dax_aops Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-04-03 11:51 ` Jan Kara
2018-04-03 11:51 ` Jan Kara
2018-03-31 4:02 ` [PATCH v8 07/18] fs, dax: use page->mapping to warn if truncate collides with a busy page Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` [PATCH v8 08/18] dax: introduce CONFIG_DAX_DRIVER Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` [PATCH v8 09/18] dax, dm: allow device-mapper to operate without dax support Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:02 ` Dan Williams
2018-03-31 4:03 ` [PATCH v8 10/18] dax, dm: introduce ->fs_{claim, release}() dax_device infrastructure Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-04-03 18:24 ` Dan Williams
2018-04-03 18:24 ` Dan Williams
2018-04-03 19:39 ` Mike Snitzer
2018-04-03 19:39 ` Mike Snitzer
2018-04-03 19:47 ` Dan Williams
2018-04-03 19:47 ` Dan Williams
2018-04-03 20:36 ` [PATCH v9] " Dan Williams
2018-04-03 20:36 ` Dan Williams
2018-04-03 20:36 ` Dan Williams
2018-04-03 21:13 ` Mike Snitzer
2018-04-03 21:13 ` Mike Snitzer
2018-04-03 21:13 ` Mike Snitzer
2018-03-31 4:03 ` [PATCH v8 11/18] mm, dax: enable filesystems to trigger dev_pagemap ->page_free callbacks Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-04-04 21:23 ` [v8, " Andrei Vagin
2018-04-04 21:23 ` Andrei Vagin
2018-04-04 21:27 ` Dan Williams
2018-04-04 21:27 ` Dan Williams
2018-04-04 21:35 ` Dan Williams
2018-04-04 21:35 ` Dan Williams
2018-04-04 23:19 ` Stephen Rothwell
2018-04-04 21:40 ` Andrei Vagin
2018-04-04 21:40 ` Andrei Vagin
2018-03-31 4:03 ` [PATCH v8 12/18] memremap: split devm_memremap_pages() and memremap() infrastructure Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` [PATCH v8 13/18] mm, dev_pagemap: introduce CONFIG_DEV_PAGEMAP_OPS Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` Dan Williams [this message]
2018-03-31 4:03 ` [PATCH v8 14/18] memremap: mark devm_memremap_pages() EXPORT_SYMBOL_GPL Dan Williams
2018-03-31 4:03 ` [PATCH v8 15/18] mm, fs, dax: handle layout changes to pinned dax mappings Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-04-04 9:46 ` Jan Kara
2018-04-04 9:46 ` Jan Kara
2018-04-04 10:06 ` Jan Kara
2018-04-04 10:06 ` Jan Kara
2018-04-04 14:12 ` Dan Williams
2018-04-04 14:12 ` Dan Williams
2018-04-07 19:38 ` Dan Williams
2018-04-07 19:38 ` Dan Williams
2018-04-08 3:11 ` Paul E. McKenney
2018-04-08 3:11 ` Paul E. McKenney
2018-04-09 16:39 ` Jan Kara
2018-04-09 16:39 ` Jan Kara
2018-04-09 18:14 ` Paul E. McKenney
2018-04-09 18:14 ` Paul E. McKenney
2018-04-09 16:49 ` Jan Kara
2018-04-09 16:49 ` Jan Kara
2018-04-09 16:51 ` Dan Williams
2018-04-09 16:51 ` Dan Williams
2018-04-13 22:03 ` Dan Williams
2018-04-13 22:03 ` Dan Williams
2018-04-13 22:48 ` Paul E. McKenney
2018-04-13 22:48 ` Paul E. McKenney
2018-04-19 10:44 ` Jan Kara
2018-04-19 10:44 ` Jan Kara
2018-04-20 3:00 ` Dan Williams
2018-04-20 3:00 ` Dan Williams
2018-03-31 4:03 ` [PATCH v8 16/18] xfs: prepare xfs_break_layouts() to be called with XFS_MMAPLOCK_EXCL Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` [PATCH v8 17/18] xfs: prepare xfs_break_layouts() for another layout type Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` [PATCH v8 18/18] xfs, dax: introduce xfs_break_dax_layouts() Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-03-31 4:03 ` Dan Williams
2018-04-04 9:55 ` Jan Kara
2018-04-04 9:55 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152246900495.36038.12673192605922080966.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.