From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@lists.01.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, tony.luck@intel.com, hch@lst.de Subject: [PATCH 04/11] device-dax: set page->index Date: Tue, 22 May 2018 07:39:52 -0700 [thread overview] Message-ID: <152699999266.24093.18001031234939470569.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <152699997165.24093.12194490924829406111.stgit@dwillia2-desk3.amr.corp.intel.com> In support of enabling memory_failure() handling for device-dax mappings, set ->index to the pgoff of the page. The rmap implementation requires ->index to bound the search through the vma interval tree. The ->index value is never cleared. There is no possibility for the page to become associated with another pgoff while the device is enabled. When the device is disabled the 'struct page' array for the device is destroyed and ->index is reinitialized to zero. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/dax/device.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/dax/device.c b/drivers/dax/device.c index 8e986478d48d..b33e45ee4f70 100644 --- a/drivers/dax/device.c +++ b/drivers/dax/device.c @@ -418,7 +418,10 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, if (rc == VM_FAULT_NOPAGE) { unsigned long i; + pgoff_t pgoff; + pgoff = linear_page_index(vma, vmf->address + & ~(fault_size - 1)); for (i = 0; i < fault_size / PAGE_SIZE; i++) { struct page *page; @@ -426,6 +429,7 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, if (page->mapping) continue; page->mapping = filp->f_mapping; + page->index = pgoff + i; } } dax_read_unlock(id); _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@lists.01.org Cc: hch@lst.de, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tony.luck@intel.com Subject: [PATCH 04/11] device-dax: set page->index Date: Tue, 22 May 2018 07:39:52 -0700 [thread overview] Message-ID: <152699999266.24093.18001031234939470569.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <152699997165.24093.12194490924829406111.stgit@dwillia2-desk3.amr.corp.intel.com> In support of enabling memory_failure() handling for device-dax mappings, set ->index to the pgoff of the page. The rmap implementation requires ->index to bound the search through the vma interval tree. The ->index value is never cleared. There is no possibility for the page to become associated with another pgoff while the device is enabled. When the device is disabled the 'struct page' array for the device is destroyed and ->index is reinitialized to zero. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/dax/device.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/dax/device.c b/drivers/dax/device.c index 8e986478d48d..b33e45ee4f70 100644 --- a/drivers/dax/device.c +++ b/drivers/dax/device.c @@ -418,7 +418,10 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, if (rc == VM_FAULT_NOPAGE) { unsigned long i; + pgoff_t pgoff; + pgoff = linear_page_index(vma, vmf->address + & ~(fault_size - 1)); for (i = 0; i < fault_size / PAGE_SIZE; i++) { struct page *page; @@ -426,6 +429,7 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, if (page->mapping) continue; page->mapping = filp->f_mapping; + page->index = pgoff + i; } } dax_read_unlock(id);
next prev parent reply other threads:[~2018-05-22 14:49 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-22 14:39 [PATCH 00/11] mm: Teach memory_failure() about ZONE_DEVICE pages Dan Williams 2018-05-22 14:39 ` Dan Williams 2018-05-22 14:39 ` Dan Williams 2018-05-22 14:39 ` [PATCH 01/11] device-dax: convert to vmf_insert_mixed and vm_fault_t Dan Williams 2018-05-22 14:39 ` Dan Williams 2018-05-22 14:39 ` [PATCH 02/11] device-dax: cleanup vm_fault de-reference chains Dan Williams 2018-05-22 14:39 ` Dan Williams 2018-05-22 14:39 ` [PATCH 03/11] device-dax: enable page_mapping() Dan Williams 2018-05-22 14:39 ` Dan Williams 2018-05-23 9:03 ` Jan Kara 2018-05-23 9:03 ` Jan Kara 2018-05-30 19:54 ` kbuild test robot 2018-05-30 19:54 ` kbuild test robot 2018-05-22 14:39 ` Dan Williams [this message] 2018-05-22 14:39 ` [PATCH 04/11] device-dax: set page->index Dan Williams 2018-05-22 14:39 ` [PATCH 05/11] filesystem-dax: " Dan Williams 2018-05-22 14:39 ` Dan Williams 2018-05-23 8:40 ` Jan Kara 2018-05-23 8:40 ` Jan Kara 2018-05-30 1:38 ` Dan Williams 2018-05-30 1:38 ` Dan Williams 2018-05-30 8:13 ` Jan Kara 2018-05-30 8:13 ` Jan Kara 2018-05-30 23:21 ` Dan Williams 2018-05-30 23:21 ` Dan Williams 2018-05-31 10:08 ` Jan Kara 2018-05-31 10:08 ` Jan Kara 2018-05-31 21:49 ` Dan Williams 2018-05-31 21:49 ` Dan Williams 2018-05-22 14:40 ` [PATCH 06/11] filesystem-dax: perform __dax_invalidate_mapping_entry() under the page lock Dan Williams 2018-05-22 14:40 ` Dan Williams 2018-05-23 9:35 ` Jan Kara 2018-05-23 13:50 ` Dan Williams 2018-05-23 13:50 ` Dan Williams 2018-05-22 14:40 ` [PATCH 07/11] mm, madvise_inject_error: fix page count leak Dan Williams 2018-05-22 14:40 ` Dan Williams 2018-05-23 4:19 ` Naoya Horiguchi 2018-05-24 20:55 ` Dan Williams 2018-05-22 14:40 ` [PATCH 08/11] x86, memory_failure: introduce {set, clear}_mce_nospec() Dan Williams 2018-05-22 14:40 ` Dan Williams 2018-05-22 14:40 ` Dan Williams 2018-05-22 14:40 ` [08/11] " Dan Williams 2018-05-22 14:40 ` [PATCH 09/11] mm, memory_failure: pass page size to kill_proc() Dan Williams 2018-05-22 14:40 ` Dan Williams 2018-05-23 6:41 ` Naoya Horiguchi 2018-05-23 6:41 ` Naoya Horiguchi 2018-05-22 14:40 ` [PATCH 10/11] mm, memory_failure: teach memory_failure() about dev_pagemap pages Dan Williams 2018-05-22 14:40 ` Dan Williams 2018-05-22 14:40 ` Dan Williams 2018-05-23 6:48 ` Naoya Horiguchi 2018-05-23 6:48 ` Naoya Horiguchi 2018-05-22 14:40 ` [PATCH 11/11] libnvdimm, pmem: restore page attributes when clearing errors Dan Williams 2018-05-22 14:40 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=152699999266.24093.18001031234939470569.stgit@dwillia2-desk3.amr.corp.intel.com \ --to=dan.j.williams@intel.com \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nvdimm@lists.01.org \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.