From: "Kani, Toshi" <toshi.kani@hpe.com>
To: "ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>
Cc: "snitzer@redhat.com" <snitzer@redhat.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode
Date: Thu, 28 Jun 2018 19:40:14 +0000 [thread overview]
Message-ID: <1530214695.14039.316.camel@hpe.com> (raw)
In-Reply-To: <20180628190424.GC17758@linux.intel.com>
On Thu, 2018-06-28 at 13:04 -0600, Ross Zwisler wrote:
> On Thu, Jun 28, 2018 at 05:42:34PM +0000, Kani, Toshi wrote:
> > On Tue, 2018-06-26 at 16:04 -0600, Ross Zwisler wrote:
> > > On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote:
> > > > On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi <toshi.kani@hpe.com> wrote:
:
> > Your patches look good. But I am still not clear about the Fixes &
> > stable handling. Talking about user visible behavior, I do not think we
> > had any issue until dax support was dropped from raw mode. Until then,
> > the pmem driver supported dax for all modes, and the check for
> > direct_access worked.
>
> I agree that the fsdax + raw mode failure mode I mentioned in my cover letter
> only started when we restricted filesystem DAX to having struct page, but I
> think that the other failure mode, fsdax + some random block driver (I used
> brd) was present in DM from the beginning.
Ah, I see.
> In any case, I think both are fixed with the patches, and I think it's fine
> that all 3 get thrown at stable. Thanks, Mike, for the help.
Yup, agreed.
Thanks!
-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshi" <toshi.kani@hpe.com>
To: "ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode
Date: Thu, 28 Jun 2018 19:40:14 +0000 [thread overview]
Message-ID: <1530214695.14039.316.camel@hpe.com> (raw)
In-Reply-To: <20180628190424.GC17758@linux.intel.com>
On Thu, 2018-06-28 at 13:04 -0600, Ross Zwisler wrote:
> On Thu, Jun 28, 2018 at 05:42:34PM +0000, Kani, Toshi wrote:
> > On Tue, 2018-06-26 at 16:04 -0600, Ross Zwisler wrote:
> > > On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote:
> > > > On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi <toshi.kani@hpe.com> wrote:
:
> > Your patches look good. But I am still not clear about the Fixes &
> > stable handling. Talking about user visible behavior, I do not think we
> > had any issue until dax support was dropped from raw mode. Until then,
> > the pmem driver supported dax for all modes, and the check for
> > direct_access worked.
>
> I agree that the fsdax + raw mode failure mode I mentioned in my cover letter
> only started when we restricted filesystem DAX to having struct page, but I
> think that the other failure mode, fsdax + some random block driver (I used
> brd) was present in DM from the beginning.
Ah, I see.
> In any case, I think both are fixed with the patches, and I think it's fine
> that all 3 get thrown at stable. Thanks, Mike, for the help.
Yup, agreed.
Thanks!
-Toshi
WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshi" <toshi.kani-ZPxbGqLxI0U@public.gmane.org>
To: "ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
<ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: "snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org"
<linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode
Date: Thu, 28 Jun 2018 19:40:14 +0000 [thread overview]
Message-ID: <1530214695.14039.316.camel@hpe.com> (raw)
In-Reply-To: <20180628190424.GC17758-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Thu, 2018-06-28 at 13:04 -0600, Ross Zwisler wrote:
> On Thu, Jun 28, 2018 at 05:42:34PM +0000, Kani, Toshi wrote:
> > On Tue, 2018-06-26 at 16:04 -0600, Ross Zwisler wrote:
> > > On Tue, Jun 26, 2018 at 02:51:52PM -0700, Dan Williams wrote:
> > > > On Tue, Jun 26, 2018 at 2:31 PM, Kani, Toshi <toshi.kani-ZPxbGqLxI0U@public.gmane.org> wrote:
:
> > Your patches look good. But I am still not clear about the Fixes &
> > stable handling. Talking about user visible behavior, I do not think we
> > had any issue until dax support was dropped from raw mode. Until then,
> > the pmem driver supported dax for all modes, and the check for
> > direct_access worked.
>
> I agree that the fsdax + raw mode failure mode I mentioned in my cover letter
> only started when we restricted filesystem DAX to having struct page, but I
> think that the other failure mode, fsdax + some random block driver (I used
> brd) was present in DM from the beginning.
Ah, I see.
> In any case, I think both are fixed with the patches, and I think it's fine
> that all 3 get thrown at stable. Thanks, Mike, for the help.
Yup, agreed.
Thanks!
-Toshi
next prev parent reply other threads:[~2018-06-28 19:40 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 17:59 [PATCH v3 0/3] Fix DM DAX handling Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 18:52 ` Dan Williams
2018-06-26 18:52 ` Dan Williams
2018-06-26 18:52 ` Dan Williams
2018-06-26 18:58 ` Mike Snitzer
2018-06-26 18:58 ` Mike Snitzer
2018-06-26 19:07 ` Dan Williams
2018-06-26 19:07 ` Dan Williams
2018-06-26 19:07 ` Dan Williams
2018-06-26 19:12 ` Ross Zwisler
2018-06-26 19:12 ` Ross Zwisler
2018-06-26 19:12 ` Ross Zwisler
2018-06-26 19:13 ` Mike Snitzer
2018-06-26 19:13 ` Mike Snitzer
2018-06-26 19:13 ` Mike Snitzer
2018-06-26 19:19 ` Dan Williams
2018-06-26 19:19 ` Dan Williams
2018-06-26 19:19 ` Dan Williams
2018-06-26 20:54 ` Kani, Toshi
2018-06-26 20:54 ` Kani, Toshi
2018-06-26 20:54 ` Kani, Toshi
2018-06-26 21:02 ` Dan Williams
2018-06-26 21:02 ` Dan Williams
2018-06-26 21:02 ` Dan Williams
2018-06-26 21:23 ` Kani, Toshi
2018-06-26 21:23 ` Kani, Toshi
2018-06-26 21:23 ` Kani, Toshi
2018-06-26 21:28 ` Dan Williams
2018-06-26 21:28 ` Dan Williams
2018-06-26 21:28 ` Dan Williams
2018-06-26 21:31 ` Kani, Toshi
2018-06-26 21:31 ` Kani, Toshi
2018-06-26 21:51 ` Dan Williams
2018-06-26 21:51 ` Dan Williams
2018-06-26 21:51 ` Dan Williams
2018-06-26 22:04 ` Ross Zwisler
2018-06-26 22:04 ` Ross Zwisler
2018-06-28 17:42 ` Kani, Toshi
2018-06-28 17:42 ` Kani, Toshi
2018-06-28 17:42 ` Kani, Toshi
2018-06-28 17:48 ` Mike Snitzer
2018-06-28 17:48 ` Mike Snitzer
2018-06-28 17:59 ` Dan Williams
2018-06-28 17:59 ` Dan Williams
2018-06-28 17:59 ` Dan Williams
2018-06-28 18:01 ` Kani, Toshi
2018-06-28 18:01 ` Kani, Toshi
2018-06-28 18:01 ` Kani, Toshi
2018-06-28 19:04 ` Ross Zwisler
2018-06-28 19:04 ` Ross Zwisler
2018-06-28 19:04 ` Ross Zwisler
2018-06-28 19:40 ` Kani, Toshi [this message]
2018-06-28 19:40 ` Kani, Toshi
2018-06-28 19:40 ` Kani, Toshi
2018-06-26 19:11 ` Ross Zwisler
2018-06-26 19:11 ` Ross Zwisler
2018-06-26 19:11 ` Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 2/3] dax: bdev_dax_supported() check for QUEUE_FLAG_DAX Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 17:59 ` [PATCH v3 3/3] dm: prevent DAX mounts if not supported Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 17:59 ` Ross Zwisler
2018-06-26 18:17 ` Mike Snitzer
2018-06-26 18:17 ` Mike Snitzer
2018-06-26 18:17 ` Mike Snitzer
2018-06-26 19:01 ` [PATCH v4 " Ross Zwisler
2018-06-26 19:01 ` Ross Zwisler
2018-06-26 19:01 ` Ross Zwisler
2018-06-26 18:48 ` [PATCH v3 0/3] Fix DM DAX handling Mike Snitzer
2018-06-26 18:48 ` Mike Snitzer
2018-06-26 18:48 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530214695.14039.316.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.