All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Sodagudi Prasad <psodagud@codeaurora.org>,
	bjorn.andersson@linaro.org, linus.walleij@linaro.org,
	sboyd@codeaurora.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: protected pins and debugfs
Date: Sun, 07 Oct 2018 23:04:02 -0700	[thread overview]
Message-ID: <153897864285.119890.13024399324598460044@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <9aec322678417753fe4022691f4bfdbe@codeaurora.org>

Quoting Sodagudi Prasad (2018-10-03 05:38:24)
> 
>          for (i = 0; i < chip->ngpio; i++, gpio++) {
> +               label = gpiochip_is_requested(chip, i);
> +               if (!label)
> +                       continue;
>                  msm_gpio_dbg_show_one(s, NULL, chip, i, gpio);
> -               seq_puts(s, "\n");
>          }
>   }
> 

Does something not work with the following code in
msm_gpio_dbg_show_one()?


        if (!gpiochip_line_is_valid(chip, offset))
		return;

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Sodagudi Prasad <psodagud@codeaurora.org>,
	bjorn.andersson@linaro.org, linus.walleij@linaro.org,
	linux-gpio@vger.kernel.org, sboyd@codeaurora.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: protected pins and debugfs
Date: Sun, 07 Oct 2018 23:04:02 -0700	[thread overview]
Message-ID: <153897864285.119890.13024399324598460044@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <9aec322678417753fe4022691f4bfdbe@codeaurora.org>

Quoting Sodagudi Prasad (2018-10-03 05:38:24)
> 
>          for (i = 0; i < chip->ngpio; i++, gpio++) {
> +               label = gpiochip_is_requested(chip, i);
> +               if (!label)
> +                       continue;
>                  msm_gpio_dbg_show_one(s, NULL, chip, i, gpio);
> -               seq_puts(s, "\n");
>          }
>   }
> 

Does something not work with the following code in
msm_gpio_dbg_show_one()?


        if (!gpiochip_line_is_valid(chip, offset))
		return;


  parent reply	other threads:[~2018-10-08  6:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 12:38 protected pins and debugfs Sodagudi Prasad
2018-10-03 12:38 ` Sodagudi Prasad
2018-10-04  8:34 ` Linus Walleij
2018-10-08  6:04 ` Stephen Boyd [this message]
2018-10-08  6:04   ` Stephen Boyd
2018-10-10 19:40   ` Sodagudi Prasad
2018-10-17  2:00     ` Sodagudi Prasad
2018-10-17  7:28       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153897864285.119890.13024399324598460044@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=psodagud@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.