From: Bart Van Assche <bvanassche@acm.org>
To: Alexander Duyck <alexander.h.duyck@linux.intel.com>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Cc: len.brown@intel.com, linux-pm@vger.kernel.org, rafael@kernel.org,
jiangshanlai@gmail.com, linux-nvdimm@lists.01.org, pavel@ucw.cz,
zwisler@kernel.org, tj@kernel.org, akpm@linux-foundation.org
Subject: Re: [driver-core PATCH v5 7/9] driver core: Attach devices on CPU local to device node
Date: Tue, 06 Nov 2018 16:24:12 -0800 [thread overview]
Message-ID: <1541550252.196084.200.camel@acm.org> (raw)
In-Reply-To: <154145233508.29224.9891071445860629874.stgit@ahduyck-desk1.jf.intel.com>
On Mon, 2018-11-05 at 13:12 -0800, Alexander Duyck wrote:
> This change makes it so that we call the asynchronous probe routines on a
> CPU local to the device node. By doing this we should be able to improve
> our initialization time significantly as we can avoid having to access the
> device from a remote node which may introduce higher latency.
>
> For example, in the case of initializing memory for NVDIMM this can have a
> significant impact as initialing 3TB on remote node can take up to 39
> seconds while initialing it on a local node only takes 23 seconds. It is
> situations like this where we will see the biggest improvement.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> ---
> drivers/base/dd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 2fdfe45bb6ea..cf7681309ee3 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -834,7 +834,7 @@ static int __device_attach(struct device *dev, bool allow_async)
> dev_dbg(dev, "scheduling asynchronous probe\n");
> get_device(dev);
> dev->async_probe = true;
> - async_schedule(__device_attach_async_helper, dev);
> + async_schedule_dev(__device_attach_async_helper, dev);
> } else {
> pm_request_idle(dev);
> }
> @@ -992,7 +992,7 @@ static int __driver_attach(struct device *dev, void *data)
> if (!dev->driver) {
> get_device(dev);
> dev_set_drv_async(dev, drv);
> - async_schedule(__driver_attach_async_helper, dev);
> + async_schedule_dev(__driver_attach_async_helper, dev);
> }
> device_unlock(dev);
> return 0;
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Alexander Duyck <alexander.h.duyck@linux.intel.com>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Cc: linux-nvdimm@lists.01.org, tj@kernel.org,
akpm@linux-foundation.org, linux-pm@vger.kernel.org,
jiangshanlai@gmail.com, rafael@kernel.org, len.brown@intel.com,
pavel@ucw.cz, zwisler@kernel.org, dan.j.williams@intel.com,
dave.jiang@intel.com
Subject: Re: [driver-core PATCH v5 7/9] driver core: Attach devices on CPU local to device node
Date: Tue, 06 Nov 2018 16:24:12 -0800 [thread overview]
Message-ID: <1541550252.196084.200.camel@acm.org> (raw)
In-Reply-To: <154145233508.29224.9891071445860629874.stgit@ahduyck-desk1.jf.intel.com>
On Mon, 2018-11-05 at 13:12 -0800, Alexander Duyck wrote:
> This change makes it so that we call the asynchronous probe routines on a
> CPU local to the device node. By doing this we should be able to improve
> our initialization time significantly as we can avoid having to access the
> device from a remote node which may introduce higher latency.
>
> For example, in the case of initializing memory for NVDIMM this can have a
> significant impact as initialing 3TB on remote node can take up to 39
> seconds while initialing it on a local node only takes 23 seconds. It is
> situations like this where we will see the biggest improvement.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> ---
> drivers/base/dd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 2fdfe45bb6ea..cf7681309ee3 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -834,7 +834,7 @@ static int __device_attach(struct device *dev, bool allow_async)
> dev_dbg(dev, "scheduling asynchronous probe\n");
> get_device(dev);
> dev->async_probe = true;
> - async_schedule(__device_attach_async_helper, dev);
> + async_schedule_dev(__device_attach_async_helper, dev);
> } else {
> pm_request_idle(dev);
> }
> @@ -992,7 +992,7 @@ static int __driver_attach(struct device *dev, void *data)
> if (!dev->driver) {
> get_device(dev);
> dev_set_drv_async(dev, drv);
> - async_schedule(__driver_attach_async_helper, dev);
> + async_schedule_dev(__driver_attach_async_helper, dev);
> }
> device_unlock(dev);
> return 0;
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Alexander Duyck
<alexander.h.duyck-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org
Cc: len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
jiangshanlai-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
pavel-+ZI9xUNit7I@public.gmane.org,
zwisler-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [driver-core PATCH v5 7/9] driver core: Attach devices on CPU local to device node
Date: Tue, 06 Nov 2018 16:24:12 -0800 [thread overview]
Message-ID: <1541550252.196084.200.camel@acm.org> (raw)
In-Reply-To: <154145233508.29224.9891071445860629874.stgit-+uVpp3jiz/RcxmDmkzA3yGt3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
On Mon, 2018-11-05 at 13:12 -0800, Alexander Duyck wrote:
> This change makes it so that we call the asynchronous probe routines on a
> CPU local to the device node. By doing this we should be able to improve
> our initialization time significantly as we can avoid having to access the
> device from a remote node which may introduce higher latency.
>
> For example, in the case of initializing memory for NVDIMM this can have a
> significant impact as initialing 3TB on remote node can take up to 39
> seconds while initialing it on a local node only takes 23 seconds. It is
> situations like this where we will see the biggest improvement.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
> drivers/base/dd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 2fdfe45bb6ea..cf7681309ee3 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -834,7 +834,7 @@ static int __device_attach(struct device *dev, bool allow_async)
> dev_dbg(dev, "scheduling asynchronous probe\n");
> get_device(dev);
> dev->async_probe = true;
> - async_schedule(__device_attach_async_helper, dev);
> + async_schedule_dev(__device_attach_async_helper, dev);
> } else {
> pm_request_idle(dev);
> }
> @@ -992,7 +992,7 @@ static int __driver_attach(struct device *dev, void *data)
> if (!dev->driver) {
> get_device(dev);
> dev_set_drv_async(dev, drv);
> - async_schedule(__driver_attach_async_helper, dev);
> + async_schedule_dev(__driver_attach_async_helper, dev);
> }
> device_unlock(dev);
> return 0;
Reviewed-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
next prev parent reply other threads:[~2018-11-07 0:24 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 21:11 [driver-core PATCH v5 0/9] Add NUMA aware async_schedule calls Alexander Duyck
2018-11-05 21:11 ` Alexander Duyck
2018-11-05 21:11 ` [driver-core PATCH v5 1/9] workqueue: Provide queue_work_node to queue work near a given NUMA node Alexander Duyck
2018-11-05 21:11 ` Alexander Duyck
2018-11-05 21:11 ` Alexander Duyck
2018-11-06 0:42 ` Bart Van Assche
2018-11-06 0:42 ` Bart Van Assche
2018-11-06 0:42 ` Bart Van Assche
2018-11-06 16:27 ` Alexander Duyck
2018-11-06 16:27 ` Alexander Duyck
2018-11-06 16:27 ` Alexander Duyck
2018-11-05 21:11 ` [driver-core PATCH v5 2/9] async: Add support for queueing on specific " Alexander Duyck
2018-11-05 21:11 ` Alexander Duyck
2018-11-05 21:11 ` Alexander Duyck
2018-11-07 0:50 ` Bart Van Assche
2018-11-07 0:50 ` Bart Van Assche
2018-11-07 0:50 ` Bart Van Assche
2018-11-05 21:11 ` [driver-core PATCH v5 3/9] device core: Consolidate locking and unlocking of parent and device Alexander Duyck
2018-11-05 21:11 ` Alexander Duyck
2018-11-05 21:11 ` Alexander Duyck
2018-11-05 21:11 ` [driver-core PATCH v5 4/9] driver core: Move async_synchronize_full call Alexander Duyck
2018-11-05 21:11 ` Alexander Duyck
2018-11-06 1:04 ` Bart Van Assche
2018-11-06 1:04 ` Bart Van Assche
2018-11-06 1:04 ` Bart Van Assche
2018-11-06 16:18 ` Alexander Duyck
2018-11-06 16:18 ` Alexander Duyck
2018-11-06 16:18 ` Alexander Duyck
2018-11-06 17:22 ` Bart Van Assche
2018-11-06 17:22 ` Bart Van Assche
2018-11-06 17:22 ` Bart Van Assche
2018-11-05 21:12 ` [driver-core PATCH v5 5/9] driver core: Establish clear order of operations for deferred probe and remove Alexander Duyck
2018-11-05 21:12 ` Alexander Duyck
2018-11-05 21:12 ` Alexander Duyck
2018-11-06 4:10 ` kbuild test robot
2018-11-06 4:10 ` kbuild test robot
2018-11-06 4:10 ` kbuild test robot
2018-11-06 23:51 ` Bart Van Assche
2018-11-06 23:51 ` Bart Van Assche
2018-11-06 23:51 ` Bart Van Assche
2018-11-07 0:52 ` Alexander Duyck
2018-11-07 0:52 ` Alexander Duyck
2018-11-23 1:23 ` Rong Chen
2018-11-23 1:23 ` Rong Chen
2018-11-23 1:23 ` Rong Chen
2018-11-23 14:19 ` Bart Van Assche
2018-11-23 14:19 ` Bart Van Assche
2018-11-06 23:48 ` Bart Van Assche
2018-11-06 23:48 ` Bart Van Assche
2018-11-06 23:48 ` Bart Van Assche
2018-11-07 1:34 ` Joe Perches
2018-11-07 1:34 ` Joe Perches
2018-11-07 1:34 ` Joe Perches
2018-11-08 23:42 ` Bart Van Assche
2018-11-08 23:42 ` Bart Van Assche
2018-11-08 23:42 ` Bart Van Assche
2018-11-11 14:31 ` Pavel Machek
2018-11-27 2:35 ` Dan Williams
2018-11-27 2:35 ` Dan Williams
2018-11-27 16:49 ` Alexander Duyck
2018-11-27 16:49 ` Alexander Duyck
2018-11-05 21:12 ` [driver-core PATCH v5 6/9] driver core: Probe devices asynchronously instead of the driver Alexander Duyck
2018-11-05 21:12 ` Alexander Duyck
2018-11-05 21:12 ` Alexander Duyck
2018-11-07 0:22 ` Bart Van Assche
2018-11-07 0:22 ` Bart Van Assche
2018-11-07 0:22 ` Bart Van Assche
2018-11-05 21:12 ` [driver-core PATCH v5 7/9] driver core: Attach devices on CPU local to device node Alexander Duyck
2018-11-05 21:12 ` Alexander Duyck
2018-11-05 21:12 ` Alexander Duyck
2018-11-07 0:24 ` Bart Van Assche [this message]
2018-11-07 0:24 ` Bart Van Assche
2018-11-07 0:24 ` Bart Van Assche
2018-11-05 21:12 ` [driver-core PATCH v5 8/9] PM core: Use new async_schedule_dev command Alexander Duyck
2018-11-05 21:12 ` Alexander Duyck
2018-11-05 21:12 ` Alexander Duyck
2018-11-07 0:24 ` Bart Van Assche
2018-11-07 0:24 ` Bart Van Assche
2018-11-07 0:24 ` Bart Van Assche
2018-11-05 21:12 ` [driver-core PATCH v5 9/9] libnvdimm: Schedule device registration on node local to the device Alexander Duyck
2018-11-05 21:12 ` Alexander Duyck
2018-11-07 0:26 ` Bart Van Assche
2018-11-07 0:26 ` Bart Van Assche
2018-11-07 0:26 ` Bart Van Assche
2018-11-06 0:50 ` [driver-core PATCH v5 0/9] Add NUMA aware async_schedule calls Bart Van Assche
2018-11-06 0:50 ` Bart Van Assche
2018-11-06 0:50 ` Bart Van Assche
2018-11-06 16:25 ` Alexander Duyck
2018-11-06 16:25 ` Alexander Duyck
2018-11-06 16:25 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541550252.196084.200.camel@acm.org \
--to=bvanassche@acm.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=tj@kernel.org \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.