From: Lucas Stach <l.stach@pengutronix.de> To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-pci@vger.kernel.org Cc: bhelgaas@google.com, Fabio Estevam <fabio.estevam@nxp.com>, cphealy@gmail.com, Leonard Crestez <leonard.crestez@nxp.com>, "A.s. Dong" <aisheng.dong@nxp.com>, Richard Zhu <hongxing.zhu@nxp.com>, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] PCI: imx: No-op imx6_pcie_reset_phy() on i.MX7D Date: Thu, 06 Dec 2018 10:41:53 +0100 [thread overview] Message-ID: <1544089313.3709.54.camel@pengutronix.de> (raw) In-Reply-To: <20181206073545.10967-3-andrew.smirnov@gmail.com> Am Mittwoch, den 05.12.2018, 23:35 -0800 schrieb Andrey Smirnov: > PCIE PHY IP block on i.MX7D differs from the one used on i.MX6 family, > so none of the code in current implementation of imx6_pcie_reset_phy() > is applicable. > > Cc: bhelgaas@google.com > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: cphealy@gmail.com > Cc: l.stach@pengutronix.de > > Cc: Leonard Crestez <leonard.crestez@nxp.com> > > Cc: "A.s. Dong" <aisheng.dong@nxp.com> > > Cc: Richard Zhu <hongxing.zhu@nxp.com> > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org > > Tested-by: Trent Piepho <tpiepho@impinj.com> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/pci/controller/dwc/pci-imx6.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index c140f7987598..3c3002861d25 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -245,6 +245,9 @@ static void imx6_pcie_reset_phy(struct imx6_pcie *imx6_pcie) > { > > u32 tmp; > > > + if (imx6_pcie->variant == IMX7D) > > + return; > + > > pcie_phy_read(imx6_pcie, PHY_RX_OVRD_IN_LO, &tmp); > > tmp |= (PHY_RX_OVRD_IN_LO_RX_DATA_EN | > > PHY_RX_OVRD_IN_LO_RX_PLL_EN);
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-pci@vger.kernel.org Cc: "A.s. Dong" <aisheng.dong@nxp.com>, Richard Zhu <hongxing.zhu@nxp.com>, linux-kernel@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>, linux-imx@nxp.com, bhelgaas@google.com, Leonard Crestez <leonard.crestez@nxp.com>, cphealy@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] PCI: imx: No-op imx6_pcie_reset_phy() on i.MX7D Date: Thu, 06 Dec 2018 10:41:53 +0100 [thread overview] Message-ID: <1544089313.3709.54.camel@pengutronix.de> (raw) In-Reply-To: <20181206073545.10967-3-andrew.smirnov@gmail.com> Am Mittwoch, den 05.12.2018, 23:35 -0800 schrieb Andrey Smirnov: > PCIE PHY IP block on i.MX7D differs from the one used on i.MX6 family, > so none of the code in current implementation of imx6_pcie_reset_phy() > is applicable. > > Cc: bhelgaas@google.com > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: cphealy@gmail.com > Cc: l.stach@pengutronix.de > > Cc: Leonard Crestez <leonard.crestez@nxp.com> > > Cc: "A.s. Dong" <aisheng.dong@nxp.com> > > Cc: Richard Zhu <hongxing.zhu@nxp.com> > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org > > Tested-by: Trent Piepho <tpiepho@impinj.com> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/pci/controller/dwc/pci-imx6.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index c140f7987598..3c3002861d25 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -245,6 +245,9 @@ static void imx6_pcie_reset_phy(struct imx6_pcie *imx6_pcie) > { > > u32 tmp; > > > + if (imx6_pcie->variant == IMX7D) > > + return; > + > > pcie_phy_read(imx6_pcie, PHY_RX_OVRD_IN_LO, &tmp); > > tmp |= (PHY_RX_OVRD_IN_LO_RX_DATA_EN | > > PHY_RX_OVRD_IN_LO_RX_PLL_EN); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-06 9:42 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-06 7:35 [PATCH v2 0/3] PCIE support for i.MX8MQ Andrey Smirnov 2018-12-06 7:35 ` Andrey Smirnov 2018-12-06 7:35 ` [PATCH v2 1/3] PCI: imx: No-op imx6_setup_phy_mpll() on i.MX7D Andrey Smirnov 2018-12-06 7:35 ` Andrey Smirnov 2018-12-06 9:41 ` Lucas Stach 2018-12-06 9:41 ` Lucas Stach 2018-12-06 7:35 ` [PATCH v2 2/3] PCI: imx: No-op imx6_pcie_reset_phy() " Andrey Smirnov 2018-12-06 7:35 ` Andrey Smirnov 2018-12-06 9:41 ` Lucas Stach [this message] 2018-12-06 9:41 ` Lucas Stach 2018-12-06 7:35 ` [PATCH v2 3/3] PCI: imx: Add support for i.MX8MQ Andrey Smirnov 2018-12-06 7:35 ` Andrey Smirnov 2018-12-06 10:23 ` Lucas Stach 2018-12-06 10:23 ` Lucas Stach 2018-12-14 20:30 ` Bjorn Helgaas 2018-12-14 20:30 ` Bjorn Helgaas 2018-12-14 20:55 ` Gustavo A. R. Silva 2018-12-14 20:55 ` Gustavo A. R. Silva 2018-12-15 5:22 ` Andrey Smirnov 2018-12-15 5:22 ` Andrey Smirnov 2018-12-15 5:22 ` Andrey Smirnov 2018-12-06 12:15 ` [PATCH v2 0/3] PCIE " Lorenzo Pieralisi 2018-12-06 12:15 ` Lorenzo Pieralisi 2018-12-07 2:44 ` Andrey Smirnov 2018-12-07 2:44 ` Andrey Smirnov 2018-12-07 2:44 ` Andrey Smirnov 2018-12-14 20:38 ` Bjorn Helgaas 2018-12-14 20:38 ` Bjorn Helgaas 2018-12-15 5:25 ` Andrey Smirnov 2018-12-15 5:25 ` Andrey Smirnov 2018-12-15 5:25 ` Andrey Smirnov 2018-12-17 10:12 ` Lucas Stach 2018-12-17 10:12 ` Lucas Stach 2018-12-17 10:12 ` Lucas Stach 2018-12-17 10:26 ` Lorenzo Pieralisi 2018-12-17 10:26 ` Lorenzo Pieralisi 2018-12-17 10:26 ` Lorenzo Pieralisi 2018-12-17 11:11 ` Lorenzo Pieralisi 2018-12-17 11:11 ` Lorenzo Pieralisi 2018-12-17 11:11 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1544089313.3709.54.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=aisheng.dong@nxp.com \ --cc=andrew.smirnov@gmail.com \ --cc=bhelgaas@google.com \ --cc=cphealy@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=hongxing.zhu@nxp.com \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.