Re: [PATCH 0/3] clk: imx: Make all the parent_names arrays be const pointers

From: Stephen Boyd <sboyd@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 0/3] clk: imx: Make all the parent_names arrays be const pointers
Date: Mon, 17 Dec 2018 10:40:52 -0800	[thread overview]
Message-ID: <154507205230.19322.658078387500141910@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181217113539.nfwp4knbx3luxoqn@fsr-ub1664-175>

Quoting Abel Vesa (2018-12-17 03:35:40)
> On 18-12-14 13:08:37, Stephen Boyd wrote:
> > Quoting Abel Vesa (2018-12-14 07:30:08)
> > > This is mainly to shut up the checkpatch.pl script warnings about the
> > > "static const char *" needing to be "static const char * const".
> > > 
> > > Abel Vesa (3):
> > >   clk: imx: Make parent_names const pointer in composite-8m
> > >   clk: imx: Make parents const pointer in mux wrappers
> > >   clk: imx8mq: Make parent names arrays const pointers
> > > 
> > 
> > I still see warnings though so there seems to be some more work to do.
> > 
> > drivers/clk/imx/clk-imx8mq.c:401:89: warning: passing argument 5 of 'imx_clk_mux2' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> >   clks[IMX8MQ_CLK_GPU_SHADER_SRC] = imx_clk_mux2("gpu_shader_src", base + 0x8200, 24, 3, imx8mq_gpu_shader_sels,  ARRAY_SIZE(imx8mq_gpu_shader_sels));
> > 
> Hmm, I guess you applied this on top of clk-imx8mq, right ?
> This change is against linux-next. The actual problem is the imx_clk_mux2
> which looks like this on branch clk-imx8mq:

Yes. It would be great if you could indicate where patches are
generated. In fact, I see that 'git format-patch' now has an option to
do just this!

	git format-patch --base=commit

> 
> static inline struct clk *imx_clk_mux2(const char *name, void __iomem *reg,  
>                 u8 shift, u8 width, const char **parents, int num_parents)   
> 
> but it looks like this on linux-next (which is exactly the same on clk-next):
> 
> static inline struct clk *imx_clk_mux2(const char *name, void __iomem *reg,  
>                         u8 shift, u8 width, const char * const *parents,     
>                         int num_parents)                                     

Hrmm ok. I'll have to rejigger things and I probably won't be getting to
it until early next year.