From: Lucas Stach <l.stach@pengutronix.de> To: Andrey Smirnov <andrew.smirnov@gmail.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com>, Fabio Estevam <fabio.estevam@nxp.com>, Chris Healy <cphealy@gmail.com>, Leonard Crestez <leonard.crestez@nxp.com>, "A.s. Dong" <aisheng.dong@nxp.com>, Richard Zhu <hongxing.zhu@nxp.com>, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v4 3/4] PCI: imx6: Convert DIRECT_SPEED_CHANGE quirk code to use a flag Date: Tue, 08 Jan 2019 09:21:38 +0100 [thread overview] Message-ID: <1546935698.3580.21.camel@pengutronix.de> (raw) In-Reply-To: <20190104165335.13205-4-andrew.smirnov@gmail.com> Am Freitag, den 04.01.2019, 08:53 -0800 schrieb Andrey Smirnov: > Both i.MX7D and i.MX8MQ have the same behaviour when it comes to > clearing DIRECT_SPEED_CHANGE bit when no speed change occur. To > account for that change the code handling that to use a generic flag > instead of checking IP block variant. > > > Cc: Bjorn Helgaas <bhelgaas@google.com> > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > > Cc: Chris Healy <cphealy@gmail.com> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Leonard Crestez <leonard.crestez@nxp.com> > > Cc: "A.s. Dong" <aisheng.dong@nxp.com> > > Cc: Richard Zhu <hongxing.zhu@nxp.com> > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/pci/controller/dwc/pci-imx6.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index c55d93c1187d..75ee0cd7af3b 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -42,6 +42,7 @@ enum imx6_pcie_variants { > }; > > > #define IMX6_PCIE_FLAG_IMX6_PHY BIT(0) > > +#define IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE BIT(1) > > struct imx6_pcie_drvdata { > > enum imx6_pcie_variants variant; > @@ -711,7 +712,8 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie) > > tmp |= PORT_LOGIC_SPEED_CHANGE; > > dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, tmp); > > > - if (imx6_pcie->drvdata->variant != IMX7D) { > > + if (imx6_pcie->drvdata->flags & > > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE) { > > /* > > * On i.MX7, DIRECT_SPEED_CHANGE behaves differently > > * from i.MX6 family when no link speed transition > @@ -1097,15 +1099,18 @@ static void imx6_pcie_shutdown(struct platform_device *pdev) > static const struct imx6_pcie_drvdata drvdata[] = { > > [IMX6Q] = { > > .variant = IMX6Q, > > - .flags = IMX6_PCIE_FLAG_IMX6_PHY, > > + .flags = IMX6_PCIE_FLAG_IMX6_PHY | > > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > > }, > > [IMX6SX] = { > > .variant = IMX6SX, > > - .flags = IMX6_PCIE_FLAG_IMX6_PHY, > > + .flags = IMX6_PCIE_FLAG_IMX6_PHY | > > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > > }, > > [IMX6QP] = { > > .variant = IMX6QP, > > - .flags = IMX6_PCIE_FLAG_IMX6_PHY, > > + .flags = IMX6_PCIE_FLAG_IMX6_PHY | > > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > > }, > > [IMX7D] = { > > .variant = IMX7D,
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Andrey Smirnov <andrew.smirnov@gmail.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: "A.s. Dong" <aisheng.dong@nxp.com>, Richard Zhu <hongxing.zhu@nxp.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>, linux-imx@nxp.com, Bjorn Helgaas <bhelgaas@google.com>, Leonard Crestez <leonard.crestez@nxp.com>, Chris Healy <cphealy@gmail.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/4] PCI: imx6: Convert DIRECT_SPEED_CHANGE quirk code to use a flag Date: Tue, 08 Jan 2019 09:21:38 +0100 [thread overview] Message-ID: <1546935698.3580.21.camel@pengutronix.de> (raw) In-Reply-To: <20190104165335.13205-4-andrew.smirnov@gmail.com> Am Freitag, den 04.01.2019, 08:53 -0800 schrieb Andrey Smirnov: > Both i.MX7D and i.MX8MQ have the same behaviour when it comes to > clearing DIRECT_SPEED_CHANGE bit when no speed change occur. To > account for that change the code handling that to use a generic flag > instead of checking IP block variant. > > > Cc: Bjorn Helgaas <bhelgaas@google.com> > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > > Cc: Chris Healy <cphealy@gmail.com> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Leonard Crestez <leonard.crestez@nxp.com> > > Cc: "A.s. Dong" <aisheng.dong@nxp.com> > > Cc: Richard Zhu <hongxing.zhu@nxp.com> > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/pci/controller/dwc/pci-imx6.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index c55d93c1187d..75ee0cd7af3b 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -42,6 +42,7 @@ enum imx6_pcie_variants { > }; > > > #define IMX6_PCIE_FLAG_IMX6_PHY BIT(0) > > +#define IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE BIT(1) > > struct imx6_pcie_drvdata { > > enum imx6_pcie_variants variant; > @@ -711,7 +712,8 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie) > > tmp |= PORT_LOGIC_SPEED_CHANGE; > > dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, tmp); > > > - if (imx6_pcie->drvdata->variant != IMX7D) { > > + if (imx6_pcie->drvdata->flags & > > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE) { > > /* > > * On i.MX7, DIRECT_SPEED_CHANGE behaves differently > > * from i.MX6 family when no link speed transition > @@ -1097,15 +1099,18 @@ static void imx6_pcie_shutdown(struct platform_device *pdev) > static const struct imx6_pcie_drvdata drvdata[] = { > > [IMX6Q] = { > > .variant = IMX6Q, > > - .flags = IMX6_PCIE_FLAG_IMX6_PHY, > > + .flags = IMX6_PCIE_FLAG_IMX6_PHY | > > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > > }, > > [IMX6SX] = { > > .variant = IMX6SX, > > - .flags = IMX6_PCIE_FLAG_IMX6_PHY, > > + .flags = IMX6_PCIE_FLAG_IMX6_PHY | > > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > > }, > > [IMX6QP] = { > > .variant = IMX6QP, > > - .flags = IMX6_PCIE_FLAG_IMX6_PHY, > > + .flags = IMX6_PCIE_FLAG_IMX6_PHY | > > + IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE, > > }, > > [IMX7D] = { > > .variant = IMX7D, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-08 8:21 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-04 16:53 [PATCH v4 0/4] PCIE support for i.MX8MQ Andrey Smirnov 2019-01-04 16:53 ` Andrey Smirnov 2019-01-04 16:53 ` [PATCH v4 1/4] PCI: imx6: introduce drvdata Andrey Smirnov 2019-01-04 16:53 ` Andrey Smirnov 2019-01-04 16:53 ` [PATCH v4 2/4] PCI: imx6: Mark PHY functions as i.MX6 specific Andrey Smirnov 2019-01-04 16:53 ` Andrey Smirnov 2019-01-04 16:53 ` [PATCH v4 3/4] PCI: imx6: Convert DIRECT_SPEED_CHANGE quirk code to use a flag Andrey Smirnov 2019-01-04 16:53 ` Andrey Smirnov 2019-01-08 8:21 ` Lucas Stach [this message] 2019-01-08 8:21 ` Lucas Stach 2019-01-04 16:53 ` [PATCH v4 4/4] PCI: imx6: Add support for i.MX8MQ Andrey Smirnov 2019-01-04 16:53 ` Andrey Smirnov 2019-01-08 8:23 ` Lucas Stach 2019-01-08 8:23 ` Lucas Stach 2019-01-11 19:53 ` Rob Herring 2019-01-11 19:53 ` Rob Herring 2019-01-11 19:53 ` Rob Herring 2019-01-12 21:28 ` Andrey Smirnov 2019-01-12 21:28 ` Andrey Smirnov 2019-01-12 21:28 ` Andrey Smirnov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1546935698.3580.21.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=aisheng.dong@nxp.com \ --cc=andrew.smirnov@gmail.com \ --cc=bhelgaas@google.com \ --cc=cphealy@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=hongxing.zhu@nxp.com \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.