From: Lucas Stach <l.stach@pengutronix.de> To: Andrey Smirnov <andrew.smirnov@gmail.com> Cc: Shawn Guo <shawnguo@kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>, Chris Healy <cphealy@gmail.com>, Leonard Crestez <leonard.crestez@nxp.com>, "A.s. Dong" <aisheng.dong@nxp.com>, Richard Zhu <hongxing.zhu@nxp.com>, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 5/5] arm64: dts: imx8mq-evk: Enable PCIE0 interface Date: Fri, 08 Feb 2019 10:54:20 +0100 [thread overview] Message-ID: <1549619660.2544.89.camel@pengutronix.de> (raw) In-Reply-To: <20190208002941.30343-6-andrew.smirnov@gmail.com> Am Donnerstag, den 07.02.2019, 16:29 -0800 schrieb Andrey Smirnov: > Enable PCIE0 interface connected to BCM4356 WiFi/Bluetooth module. > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Leonard Crestez <leonard.crestez@nxp.com> > Cc: "A.s. Dong" <aisheng.dong@nxp.com> > Cc: Richard Zhu <hongxing.zhu@nxp.com> > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 34 ++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > index 64acccc4bfcb..20afdb9ffdd9 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > @@ -31,6 +31,12 @@ > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > + > + pcie0_refclk: pcie0-refclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <100000000>; > + }; > }; > > &fec1 { > @@ -40,6 +46,14 @@ > > status = "okay"; > }; > > +&gpio5 { > + wl-reg-on { > + gpio-hog; > + gpios = <29 GPIO_ACTIVE_HIGH>; > + output-high; > + }; > +}; > + > &i2c1 { > > clock-frequency = <100000>; > > pinctrl-names = "default"; > @@ -131,6 +145,18 @@ > > }; > }; > > +&pcie0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pcie0>; > + reset-gpio = <&gpio5 28 GPIO_ACTIVE_LOW>; > + clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>, > + <&clk IMX8MQ_CLK_PCIE1_AUX>, > + <&clk IMX8MQ_CLK_PCIE1_PHY>, > + <&pcie0_refclk>; > + clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > + status = "okay"; > +}; From a PCIe PoV I think this is fine. Please send a patch for the PCIe driver to use the pcie_aux clock. > + > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1>; > @@ -195,6 +221,14 @@ > >; > }; > > + pinctrl_pcie0: pcie0grp { > + fsl,pins = < > + MX8MQ_IOMUXC_I2C4_SCL_PCIE1_CLKREQ_B 0x76 > + MX8MQ_IOMUXC_UART4_TXD_GPIO5_IO29 0x16 Shouldn't this GPIO be separated in a pinctrl group for gpio5? > + MX8MQ_IOMUXC_UART4_RXD_GPIO5_IO28 0x16 > + >; > + }; > + > pinctrl_reg_usdhc2: regusdhc2grpgpio { > fsl,pins = < > MX8MQ_IOMUXC_SD2_RESET_B_GPIO2_IO19 0x41
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Andrey Smirnov <andrew.smirnov@gmail.com> Cc: "A.s. Dong" <aisheng.dong@nxp.com>, Richard Zhu <hongxing.zhu@nxp.com>, linux-kernel@vger.kernel.org, linux-imx@nxp.com, Fabio Estevam <fabio.estevam@nxp.com>, Leonard Crestez <leonard.crestez@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Chris Healy <cphealy@gmail.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC v2 5/5] arm64: dts: imx8mq-evk: Enable PCIE0 interface Date: Fri, 08 Feb 2019 10:54:20 +0100 [thread overview] Message-ID: <1549619660.2544.89.camel@pengutronix.de> (raw) In-Reply-To: <20190208002941.30343-6-andrew.smirnov@gmail.com> Am Donnerstag, den 07.02.2019, 16:29 -0800 schrieb Andrey Smirnov: > Enable PCIE0 interface connected to BCM4356 WiFi/Bluetooth module. > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Leonard Crestez <leonard.crestez@nxp.com> > Cc: "A.s. Dong" <aisheng.dong@nxp.com> > Cc: Richard Zhu <hongxing.zhu@nxp.com> > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 34 ++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > index 64acccc4bfcb..20afdb9ffdd9 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts > @@ -31,6 +31,12 @@ > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > + > + pcie0_refclk: pcie0-refclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <100000000>; > + }; > }; > > &fec1 { > @@ -40,6 +46,14 @@ > > status = "okay"; > }; > > +&gpio5 { > + wl-reg-on { > + gpio-hog; > + gpios = <29 GPIO_ACTIVE_HIGH>; > + output-high; > + }; > +}; > + > &i2c1 { > > clock-frequency = <100000>; > > pinctrl-names = "default"; > @@ -131,6 +145,18 @@ > > }; > }; > > +&pcie0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pcie0>; > + reset-gpio = <&gpio5 28 GPIO_ACTIVE_LOW>; > + clocks = <&clk IMX8MQ_CLK_PCIE1_ROOT>, > + <&clk IMX8MQ_CLK_PCIE1_AUX>, > + <&clk IMX8MQ_CLK_PCIE1_PHY>, > + <&pcie0_refclk>; > + clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > + status = "okay"; > +}; From a PCIe PoV I think this is fine. Please send a patch for the PCIe driver to use the pcie_aux clock. > + > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1>; > @@ -195,6 +221,14 @@ > >; > }; > > + pinctrl_pcie0: pcie0grp { > + fsl,pins = < > + MX8MQ_IOMUXC_I2C4_SCL_PCIE1_CLKREQ_B 0x76 > + MX8MQ_IOMUXC_UART4_TXD_GPIO5_IO29 0x16 Shouldn't this GPIO be separated in a pinctrl group for gpio5? > + MX8MQ_IOMUXC_UART4_RXD_GPIO5_IO28 0x16 > + >; > + }; > + > pinctrl_reg_usdhc2: regusdhc2grpgpio { > fsl,pins = < > MX8MQ_IOMUXC_SD2_RESET_B_GPIO2_IO19 0x41 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-08 9:54 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-08 0:29 [RFC v2 0/5] PCIE support for i.MX8MQ (DT changes) Andrey Smirnov 2019-02-08 0:29 ` Andrey Smirnov 2019-02-08 0:29 ` [RFC v2 1/5] arm64: dts: imx8mq: Mark iomuxc_gpr as i.MX6Q compatible Andrey Smirnov 2019-02-08 0:29 ` Andrey Smirnov 2019-02-08 9:40 ` Lucas Stach 2019-02-08 9:40 ` Lucas Stach 2019-02-08 0:29 ` [RFC v2 2/5] arm64: dts: imx8mq: Add a node for SRC IP block Andrey Smirnov 2019-02-08 0:29 ` Andrey Smirnov 2019-02-08 9:41 ` Lucas Stach 2019-02-08 9:41 ` Lucas Stach 2019-02-08 0:29 ` [RFC v2 3/5] arm64: dts: imx8mq: Combine PCIE power domains Andrey Smirnov 2019-02-08 0:29 ` Andrey Smirnov 2019-02-08 9:45 ` Lucas Stach 2019-02-08 9:45 ` Lucas Stach 2019-02-08 0:29 ` [RFC v2 4/5] arm64: dts: imx8mq: Add nodes for PCIe IP blocks Andrey Smirnov 2019-02-08 0:29 ` Andrey Smirnov 2019-02-08 9:47 ` Lucas Stach 2019-02-08 9:47 ` Lucas Stach 2019-02-08 0:29 ` [RFC v2 5/5] arm64: dts: imx8mq-evk: Enable PCIE0 interface Andrey Smirnov 2019-02-08 0:29 ` Andrey Smirnov 2019-02-08 9:54 ` Lucas Stach [this message] 2019-02-08 9:54 ` Lucas Stach
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1549619660.2544.89.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=aisheng.dong@nxp.com \ --cc=andrew.smirnov@gmail.com \ --cc=cphealy@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=hongxing.zhu@nxp.com \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.