From: Anshuman Gupta <anshuman.gupta@intel.com>
To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 1/2] tests/pm_rpm: Enable PC8+ residency test for ICL and GEN9.
Date: Thu, 21 Feb 2019 22:37:57 +0530 [thread overview]
Message-ID: <1550768878-20598-2-git-send-email-anshuman.gupta@intel.com> (raw)
In-Reply-To: <1550768878-20598-1-git-send-email-anshuman.gupta@intel.com>
Enabled has_pc8 global for ICL and Gen9.
Added PC8+ residency test for display enabled case as well.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
tests/pm_rpm.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index be296f5..c84f199 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -686,7 +686,8 @@ static void setup_pc8(void)
has_pc8 = false;
/* Only Haswell supports the PC8 feature. */
- if (!IS_HASWELL(ms_data.devid) && !IS_BROADWELL(ms_data.devid))
+ if (!IS_HASWELL(ms_data.devid) && !IS_BROADWELL(ms_data.devid)
+ && !IS_GEN9(ms_data.devid) && !IS_ICELAKE(ms_data.devid))
return;
/* Make sure our Kernel supports MSR and the module is loaded. */
@@ -806,11 +807,15 @@ static void pc8_residency_subtest(void)
igt_assert_f(pc8_plus_residency_changed(30),
"Machine is not reaching PC8+ states, please check its "
"configuration.\n");
-
- /* Make sure PC8+ residencies stop! */
enable_one_screen(&ms_data);
- igt_assert_f(!pc8_plus_residency_changed(10),
+ if (IS_HASWELL(ms_data.devid) && IS_BROADWELL(ms_data.devid)) {
+ /* Make sure PC8+ residencies stop! */
+ igt_assert_f(!pc8_plus_residency_changed(10),
+ "PC8+ residency didn't stop with screen enabled.\n");
+ } else {
+ igt_assert_f(pc8_plus_residency_changed(10),
"PC8+ residency didn't stop with screen enabled.\n");
+ }
}
static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Gupta <anshuman.gupta@intel.com>
To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org
Cc: anshuman.gupta@intel.com
Subject: [igt-dev] [PATCH i-g-t 1/2] tests/pm_rpm: Enable PC8+ residency test for ICL and GEN9.
Date: Thu, 21 Feb 2019 22:37:57 +0530 [thread overview]
Message-ID: <1550768878-20598-2-git-send-email-anshuman.gupta@intel.com> (raw)
In-Reply-To: <1550768878-20598-1-git-send-email-anshuman.gupta@intel.com>
Enabled has_pc8 global for ICL and Gen9.
Added PC8+ residency test for display enabled case as well.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
tests/pm_rpm.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index be296f5..c84f199 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -686,7 +686,8 @@ static void setup_pc8(void)
has_pc8 = false;
/* Only Haswell supports the PC8 feature. */
- if (!IS_HASWELL(ms_data.devid) && !IS_BROADWELL(ms_data.devid))
+ if (!IS_HASWELL(ms_data.devid) && !IS_BROADWELL(ms_data.devid)
+ && !IS_GEN9(ms_data.devid) && !IS_ICELAKE(ms_data.devid))
return;
/* Make sure our Kernel supports MSR and the module is loaded. */
@@ -806,11 +807,15 @@ static void pc8_residency_subtest(void)
igt_assert_f(pc8_plus_residency_changed(30),
"Machine is not reaching PC8+ states, please check its "
"configuration.\n");
-
- /* Make sure PC8+ residencies stop! */
enable_one_screen(&ms_data);
- igt_assert_f(!pc8_plus_residency_changed(10),
+ if (IS_HASWELL(ms_data.devid) && IS_BROADWELL(ms_data.devid)) {
+ /* Make sure PC8+ residencies stop! */
+ igt_assert_f(!pc8_plus_residency_changed(10),
+ "PC8+ residency didn't stop with screen enabled.\n");
+ } else {
+ igt_assert_f(pc8_plus_residency_changed(10),
"PC8+ residency didn't stop with screen enabled.\n");
+ }
}
static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-21 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 17:07 [PATCH i-g-t 0/2] Enabling PC8+ residency for ICL and GEN9 Anshuman Gupta
2019-02-21 17:07 ` [igt-dev] " Anshuman Gupta
2019-02-21 17:07 ` Anshuman Gupta [this message]
2019-02-21 17:07 ` [igt-dev] [PATCH i-g-t 1/2] tests/pm_rpm: Enable PC8+ residency test " Anshuman Gupta
2019-02-25 15:16 ` Imre Deak
2019-02-25 15:16 ` [igt-dev] " Imre Deak
2019-02-21 17:07 ` [PATCH i-g-t 2/2] tests/pm_rpm: Enable modeset-pc8-residency-stress " Anshuman Gupta
2019-02-21 17:07 ` [igt-dev] " Anshuman Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550768878-20598-2-git-send-email-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.