From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] selftests/ima: kexec_file_load syscall test
Date: Sun, 10 Mar 2019 13:48:24 -0400 [thread overview]
Message-ID: <1552240104.5062.10.camel@linux.ibm.com> (raw)
In-Reply-To: <20190228220039.GC20335@dell5510>
On Thu, 2019-02-28 at 23:00 +0100, Petr Vorel wrote:
> > + local keypair1="$2"
> > + local keypair2="$3"
> > +
> > + mount_securityfs
> > +
> > + local ima_policy=$SECURITYFS/ima/policy
> > + if [ ! -e $ima_policy ]; then
> > + log_fail "$ima_policy not found"
> > + fi
> > +
> > + if [ -n $keypair2 ]; then
> > + grep -e "^$action.*$keypair1" "$ima_policy" | \
> > + grep -q -e "$keypair2"
> > + else
> > + grep -q -e "^$action.*$keypair1" "$ima_policy"
> > + fi
> > +
> > + [ $? -eq 0 ] && ret=1 || ret=0
> > + return $ret
> return $? is enough here (+ ret was not defined as local and mixing tabs with spaces)
"grep -q" exits with zero if any match is found. This line inverts
the result so that 1 is returned for found. v3 will make "ret" local
and fix the tabs/spaces.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: zohar at linux.ibm.com (Mimi Zohar)
Subject: [PATCH v2 4/5] selftests/ima: kexec_file_load syscall test
Date: Sun, 10 Mar 2019 13:48:24 -0400 [thread overview]
Message-ID: <1552240104.5062.10.camel@linux.ibm.com> (raw)
In-Reply-To: <20190228220039.GC20335@dell5510>
On Thu, 2019-02-28 at 23:00 +0100, Petr Vorel wrote:
> > + local keypair1="$2"
> > + local keypair2="$3"
> > +
> > + mount_securityfs
> > +
> > + local ima_policy=$SECURITYFS/ima/policy
> > + if [ ! -e $ima_policy ]; then
> > + log_fail "$ima_policy not found"
> > + fi
> > +
> > + if [ -n $keypair2 ]; then
> > + grep -e "^$action.*$keypair1" "$ima_policy" | \
> > + grep -q -e "$keypair2"
> > + else
> > + grep -q -e "^$action.*$keypair1" "$ima_policy"
> > + fi
> > +
> > + [ $? -eq 0 ] && ret=1 || ret=0
> > + return $ret
> return $? is enough here (+ ret was not defined as local and mixing tabs with spaces)
"grep -q" exits with zero if any match is found. This line inverts
the result so that 1 is returned for found. v3 will make "ret" local
and fix the tabs/spaces.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: zohar@linux.ibm.com (Mimi Zohar)
Subject: [PATCH v2 4/5] selftests/ima: kexec_file_load syscall test
Date: Sun, 10 Mar 2019 13:48:24 -0400 [thread overview]
Message-ID: <1552240104.5062.10.camel@linux.ibm.com> (raw)
Message-ID: <20190310174824.dCkKi_EI2_rbvm4D3usi4ciVtPbKg2cpSW4jcZAnIPI@z> (raw)
In-Reply-To: <20190228220039.GC20335@dell5510>
On Thu, 2019-02-28@23:00 +0100, Petr Vorel wrote:
> > + local keypair1="$2"
> > + local keypair2="$3"
> > +
> > + mount_securityfs
> > +
> > + local ima_policy=$SECURITYFS/ima/policy
> > + if [ ! -e $ima_policy ]; then
> > + log_fail "$ima_policy not found"
> > + fi
> > +
> > + if [ -n $keypair2 ]; then
> > + grep -e "^$action.*$keypair1" "$ima_policy" | \
> > + grep -q -e "$keypair2"
> > + else
> > + grep -q -e "^$action.*$keypair1" "$ima_policy"
> > + fi
> > +
> > + [ $? -eq 0 ] && ret=1 || ret=0
> > + return $ret
> return $? is enough here (+ ret was not defined as local and mixing tabs with spaces)
"grep -q" exits with zero if any match is found. This line inverts
the result so that 1 is returned for found. v3 will make "ret" local
and fix the tabs/spaces.
Mimi
next prev parent reply other threads:[~2019-03-10 17:48 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 23:26 [PATCH v2 0/5] selftests/ima: add kexec and kernel module tests Mimi Zohar
2019-02-26 23:26 ` Mimi Zohar
2019-02-26 23:26 ` zohar
2019-02-26 23:26 ` [PATCH v2 1/5] selftests/ima: cleanup the kexec selftest Mimi Zohar
2019-02-26 23:26 ` Mimi Zohar
2019-02-26 23:26 ` zohar
2019-02-27 0:57 ` shuah
2019-02-27 0:57 ` shuah
2019-02-27 0:57 ` shuah
2019-02-26 23:26 ` [PATCH v2 2/5] selftests/ima: define a set of common functions Mimi Zohar
2019-02-26 23:26 ` Mimi Zohar
2019-02-26 23:26 ` zohar
2019-02-27 1:01 ` shuah
2019-02-27 1:01 ` shuah
2019-02-27 1:01 ` shuah
2019-02-28 19:54 ` Petr Vorel
2019-02-28 19:54 ` Petr Vorel
2019-02-28 19:54 ` pvorel
2019-02-26 23:26 ` [PATCH v2 3/5] selftests/ima: define common logging functions Mimi Zohar
2019-02-26 23:26 ` Mimi Zohar
2019-02-26 23:26 ` zohar
2019-02-27 1:39 ` shuah
2019-02-27 1:39 ` shuah
2019-02-27 1:39 ` shuah
2019-02-28 20:18 ` Petr Vorel
2019-02-28 20:18 ` Petr Vorel
2019-02-28 20:18 ` pvorel
2019-02-28 21:01 ` Petr Vorel
2019-02-28 21:01 ` Petr Vorel
2019-02-28 21:01 ` pvorel
2019-02-26 23:26 ` [PATCH v2 4/5] selftests/ima: kexec_file_load syscall test Mimi Zohar
2019-02-26 23:26 ` Mimi Zohar
2019-02-26 23:26 ` zohar
2019-02-27 1:54 ` shuah
2019-02-27 1:54 ` shuah
2019-02-27 1:54 ` shuah
2019-02-28 22:00 ` Petr Vorel
2019-02-28 22:00 ` Petr Vorel
2019-02-28 22:00 ` pvorel
2019-03-10 17:48 ` Mimi Zohar [this message]
2019-03-10 17:48 ` Mimi Zohar
2019-03-10 17:48 ` zohar
2019-03-11 8:34 ` Petr Vorel
2019-03-11 8:34 ` Petr Vorel
2019-03-11 8:34 ` pvorel
2019-03-11 11:49 ` Mimi Zohar
2019-03-11 11:49 ` Mimi Zohar
2019-03-11 11:49 ` zohar
2019-02-28 22:20 ` Petr Vorel
2019-02-28 22:20 ` Petr Vorel
2019-02-28 22:20 ` pvorel
2019-02-26 23:27 ` [PATCH v2 5/5] selftests/ima: loading kernel modules Mimi Zohar
2019-02-26 23:27 ` Mimi Zohar
2019-02-26 23:27 ` zohar
2019-02-27 1:59 ` shuah
2019-02-27 1:59 ` shuah
2019-02-27 1:59 ` shuah
2019-02-27 14:14 ` Mimi Zohar
2019-02-27 14:14 ` Mimi Zohar
2019-02-27 14:14 ` zohar
2019-02-27 15:33 ` shuah
2019-02-27 15:33 ` shuah
2019-02-27 15:33 ` shuah
2019-02-27 18:37 ` Mimi Zohar
2019-02-27 18:37 ` Mimi Zohar
2019-02-27 18:37 ` zohar
2019-02-28 23:14 ` Petr Vorel
2019-02-28 23:14 ` Petr Vorel
2019-02-28 23:14 ` pvorel
2019-02-28 22:32 ` Petr Vorel
2019-02-28 22:32 ` Petr Vorel
2019-02-28 22:32 ` pvorel
2019-03-10 17:48 ` Mimi Zohar
2019-03-10 17:48 ` Mimi Zohar
2019-03-10 17:48 ` zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552240104.5062.10.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.