From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>, Dave Young <dyoung@redhat.com>
Cc: linux-integrity@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] selftests/ima: kexec_file_load syscall test
Date: Thu, 14 Mar 2019 14:38:37 -0400 [thread overview]
Message-ID: <1552588717.8658.5.camel@linux.ibm.com> (raw)
In-Reply-To: <20190313101436.GB25643@dell5510>
On Wed, 2019-03-13 at 11:14 +0100, Petr Vorel wrote:
> > > So if split kexec tests to another folder is not doable please just
> > > ignore the comment.
>
> > Left in the selftests/ima is a similar test for kernel modules, which
> > uses the "common" functions. So either we wait to move the kexec
> > tests or allow them to reach into the ima directory and use the
> > ima_common_lib functions.
> I guess just load ima_common_lib.sh for now would be good enough.
After thinking about it some more, I've decided to remove the kernel
module test from this patch set and to simply move everything from the
selftests/ima to selftests/kexec.
The kernel module test will access scripts/kexec/kexec_common_lib.sh
until there is a generic set of functions.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: zohar at linux.ibm.com (Mimi Zohar)
Subject: [PATCH v3 5/7] selftests/ima: kexec_file_load syscall test
Date: Thu, 14 Mar 2019 14:38:37 -0400 [thread overview]
Message-ID: <1552588717.8658.5.camel@linux.ibm.com> (raw)
In-Reply-To: <20190313101436.GB25643@dell5510>
On Wed, 2019-03-13 at 11:14 +0100, Petr Vorel wrote:
> > > So if split kexec tests to another folder is not doable please just
> > > ignore the comment.
>
> > Left in the selftests/ima is a similar test for kernel modules, which
> > uses the "common" functions. So either we wait to move the kexec
> > tests or allow them to reach into the ima directory and use the
> > ima_common_lib functions.
> I guess just load ima_common_lib.sh for now would be good enough.
After thinking about it some more, I've decided to remove the kernel
module test from this patch set and to simply move everything from the
selftests/ima to selftests/kexec.
The kernel module test will access scripts/kexec/kexec_common_lib.sh
until there is a generic set of functions.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: zohar@linux.ibm.com (Mimi Zohar)
Subject: [PATCH v3 5/7] selftests/ima: kexec_file_load syscall test
Date: Thu, 14 Mar 2019 14:38:37 -0400 [thread overview]
Message-ID: <1552588717.8658.5.camel@linux.ibm.com> (raw)
Message-ID: <20190314183837.PxV4QYRRrQH7QSJmr6pq2eEWxrhIis1XsMOzn-jqjps@z> (raw)
In-Reply-To: <20190313101436.GB25643@dell5510>
On Wed, 2019-03-13@11:14 +0100, Petr Vorel wrote:
> > > So if split kexec tests to another folder is not doable please just
> > > ignore the comment.
>
> > Left in the selftests/ima is a similar test for kernel modules, which
> > uses the "common" functions. So either we wait to move the kexec
> > tests or allow them to reach into the ima directory and use the
> > ima_common_lib functions.
> I guess just load ima_common_lib.sh for now would be good enough.
After thinking about it some more, I've decided to remove the kernel
module test from this patch set and to simply move everything from the
selftests/ima to selftests/kexec.
The kernel module test will access scripts/kexec/kexec_common_lib.sh
until there is a generic set of functions.
Mimi
next prev parent reply other threads:[~2019-03-14 18:38 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 11:41 [PATCH v3 0/7] selftests/ima: add kexec and kernel module tests Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` zohar
2019-03-11 11:41 ` [PATCH v3 1/7] selftests/ima: cleanup the kexec selftest Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` zohar
2019-03-11 11:41 ` [PATCH v3 2/7] selftests/ima: define a set of common functions Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` zohar
2019-03-11 21:39 ` Petr Vorel
2019-03-11 21:39 ` Petr Vorel
2019-03-11 21:39 ` Petr Vorel
2019-03-11 21:39 ` pvorel
2019-03-11 11:41 ` [PATCH v3 3/7] selftests/ima: define common logging functions Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` zohar
2019-03-11 11:41 ` [PATCH v3 4/7] kselftest/ima: define "require_root_privileges" Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` zohar
2019-03-11 11:41 ` [PATCH v3 5/7] selftests/ima: kexec_file_load syscall test Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` zohar
2019-03-12 12:10 ` Dave Young
2019-03-12 12:10 ` Dave Young
2019-03-12 12:10 ` Dave Young
2019-03-12 12:10 ` dyoung
2019-03-12 16:51 ` Mimi Zohar
2019-03-12 16:51 ` Mimi Zohar
2019-03-12 16:51 ` Mimi Zohar
2019-03-12 16:51 ` zohar
2019-03-13 10:14 ` Petr Vorel
2019-03-13 10:14 ` Petr Vorel
2019-03-13 10:14 ` pvorel
2019-03-14 18:38 ` Mimi Zohar [this message]
2019-03-14 18:38 ` Mimi Zohar
2019-03-14 18:38 ` zohar
2019-03-11 11:41 ` [PATCH v3 6/7] selftests/ima: loading kernel modules Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` zohar
2019-03-11 11:41 ` [PATCH v3 7/7] selftests/ima: Add missing '=y' to config options Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` Mimi Zohar
2019-03-11 11:41 ` zohar
2019-03-11 21:51 ` [PATCH v3 0/7] selftests/ima: add kexec and kernel module tests Petr Vorel
2019-03-11 21:51 ` Petr Vorel
2019-03-11 21:51 ` Petr Vorel
2019-03-11 21:51 ` pvorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552588717.8658.5.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dyoung@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.