From: Dan Williams <dan.j.williams@intel.com>
To: keyrings@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
linux-nvdimm@lists.01.org
Subject: [PATCH 6/6] security/keys/encrypted: Drop export of key_type_encrypted
Date: Mon, 18 Mar 2019 23:06:47 -0700 [thread overview]
Message-ID: <155297560738.2276575.13044997734939158888.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <155297557534.2276575.16264199708584900090.stgit@dwillia2-desk3.amr.corp.intel.com>
Now that all users lookup the key type by name, drop the export and the
direct module dependency.
Cc: Mimi Zohar <zohar@linux.ibm.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
include/keys/encrypted-type.h | 2 --
security/keys/encrypted-keys/encrypted.c | 3 +--
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/keys/encrypted-type.h b/include/keys/encrypted-type.h
index 1d4541370a64..dd509835b4a4 100644
--- a/include/keys/encrypted-type.h
+++ b/include/keys/encrypted-type.h
@@ -33,6 +33,4 @@ struct encrypted_key_payload {
u8 payload_data[0]; /* payload data + datablob + hmac */
};
-extern struct key_type key_type_encrypted;
-
#endif /* _KEYS_ENCRYPTED_TYPE_H */
diff --git a/security/keys/encrypted-keys/encrypted.c b/security/keys/encrypted-keys/encrypted.c
index 06925d3b30c9..c3999d5e2a19 100644
--- a/security/keys/encrypted-keys/encrypted.c
+++ b/security/keys/encrypted-keys/encrypted.c
@@ -1012,7 +1012,7 @@ static void encrypted_destroy(struct key *key)
kzfree(key->payload.data[0]);
}
-struct key_type key_type_encrypted = {
+static struct key_type key_type_encrypted = {
.name = "encrypted",
.instantiate = encrypted_instantiate,
.update = encrypted_update,
@@ -1020,7 +1020,6 @@ struct key_type key_type_encrypted = {
.describe = user_describe,
.read = encrypted_read,
};
-EXPORT_SYMBOL_GPL(key_type_encrypted);
static int __init init_encrypted(void)
{
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: keyrings@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
linux-nvdimm@lists.01.org
Subject: [PATCH 6/6] security/keys/encrypted: Drop export of key_type_encrypted
Date: Tue, 19 Mar 2019 06:06:47 +0000 [thread overview]
Message-ID: <155297560738.2276575.13044997734939158888.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <155297557534.2276575.16264199708584900090.stgit@dwillia2-desk3.amr.corp.intel.com>
Now that all users lookup the key type by name, drop the export and the
direct module dependency.
Cc: Mimi Zohar <zohar@linux.ibm.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
include/keys/encrypted-type.h | 2 --
security/keys/encrypted-keys/encrypted.c | 3 +--
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/keys/encrypted-type.h b/include/keys/encrypted-type.h
index 1d4541370a64..dd509835b4a4 100644
--- a/include/keys/encrypted-type.h
+++ b/include/keys/encrypted-type.h
@@ -33,6 +33,4 @@ struct encrypted_key_payload {
u8 payload_data[0]; /* payload data + datablob + hmac */
};
-extern struct key_type key_type_encrypted;
-
#endif /* _KEYS_ENCRYPTED_TYPE_H */
diff --git a/security/keys/encrypted-keys/encrypted.c b/security/keys/encrypted-keys/encrypted.c
index 06925d3b30c9..c3999d5e2a19 100644
--- a/security/keys/encrypted-keys/encrypted.c
+++ b/security/keys/encrypted-keys/encrypted.c
@@ -1012,7 +1012,7 @@ static void encrypted_destroy(struct key *key)
kzfree(key->payload.data[0]);
}
-struct key_type key_type_encrypted = {
+static struct key_type key_type_encrypted = {
.name = "encrypted",
.instantiate = encrypted_instantiate,
.update = encrypted_update,
@@ -1020,7 +1020,6 @@ struct key_type key_type_encrypted = {
.describe = user_describe,
.read = encrypted_read,
};
-EXPORT_SYMBOL_GPL(key_type_encrypted);
static int __init init_encrypted(void)
{
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com>
To: keyrings@vger.kernel.org
Cc: Mimi Zohar <zohar@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
vishal.l.verma@intel.com, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 6/6] security/keys/encrypted: Drop export of key_type_encrypted
Date: Mon, 18 Mar 2019 23:06:47 -0700 [thread overview]
Message-ID: <155297560738.2276575.13044997734939158888.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <155297557534.2276575.16264199708584900090.stgit@dwillia2-desk3.amr.corp.intel.com>
Now that all users lookup the key type by name, drop the export and the
direct module dependency.
Cc: Mimi Zohar <zohar@linux.ibm.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
include/keys/encrypted-type.h | 2 --
security/keys/encrypted-keys/encrypted.c | 3 +--
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/keys/encrypted-type.h b/include/keys/encrypted-type.h
index 1d4541370a64..dd509835b4a4 100644
--- a/include/keys/encrypted-type.h
+++ b/include/keys/encrypted-type.h
@@ -33,6 +33,4 @@ struct encrypted_key_payload {
u8 payload_data[0]; /* payload data + datablob + hmac */
};
-extern struct key_type key_type_encrypted;
-
#endif /* _KEYS_ENCRYPTED_TYPE_H */
diff --git a/security/keys/encrypted-keys/encrypted.c b/security/keys/encrypted-keys/encrypted.c
index 06925d3b30c9..c3999d5e2a19 100644
--- a/security/keys/encrypted-keys/encrypted.c
+++ b/security/keys/encrypted-keys/encrypted.c
@@ -1012,7 +1012,7 @@ static void encrypted_destroy(struct key *key)
kzfree(key->payload.data[0]);
}
-struct key_type key_type_encrypted = {
+static struct key_type key_type_encrypted = {
.name = "encrypted",
.instantiate = encrypted_instantiate,
.update = encrypted_update,
@@ -1020,7 +1020,6 @@ struct key_type key_type_encrypted = {
.describe = user_describe,
.read = encrypted_read,
};
-EXPORT_SYMBOL_GPL(key_type_encrypted);
static int __init init_encrypted(void)
{
next prev parent reply other threads:[~2019-03-19 6:19 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 6:06 [PATCH 0/6] security/keys/encrypted: Break module dependency chain Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` [PATCH 1/6] security/keys/encrypted: Allow operation without trusted.ko Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` [PATCH 2/6] security/keys/encrypted: Clean up request_trusted_key() Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-20 0:06 ` Mimi Zohar
2019-03-20 0:06 ` Mimi Zohar
2019-03-20 0:06 ` Mimi Zohar
2019-03-20 0:20 ` Dan Williams
2019-03-20 0:20 ` Dan Williams
2019-03-20 0:20 ` Dan Williams
2019-03-20 1:10 ` Mimi Zohar
2019-03-20 1:10 ` Mimi Zohar
2019-03-20 1:10 ` Mimi Zohar
2019-03-20 1:34 ` Dan Williams
2019-03-20 1:34 ` Dan Williams
2019-03-20 1:34 ` Dan Williams
2019-03-20 1:37 ` Dan Williams
2019-03-20 1:37 ` Dan Williams
2019-03-20 1:37 ` Dan Williams
2019-03-20 2:35 ` Mimi Zohar
2019-03-20 2:35 ` Mimi Zohar
2019-03-20 2:35 ` Mimi Zohar
2019-03-20 5:48 ` Dan Williams
2019-03-20 5:48 ` Dan Williams
2019-03-20 5:48 ` Dan Williams
2019-03-20 12:06 ` Mimi Zohar
2019-03-20 12:06 ` Mimi Zohar
2019-03-20 12:06 ` Mimi Zohar
2019-03-20 15:27 ` Dan Williams
2019-03-20 15:27 ` Dan Williams
2019-03-20 15:27 ` Dan Williams
2019-03-19 6:06 ` [PATCH 3/6] libnvdimm/security: Drop direct dependency on key_type_encrypted Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 16:46 ` Dave Jiang
2019-03-19 16:46 ` Dave Jiang
2019-03-19 16:46 ` Dave Jiang
2019-03-19 6:06 ` [PATCH 4/6] security/keys/ecryptfs: " Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` [PATCH 5/6] security/integrity/evm: " Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 6:06 ` Dan Williams [this message]
2019-03-19 6:06 ` [PATCH 6/6] security/keys/encrypted: Drop export of key_type_encrypted Dan Williams
2019-03-19 6:06 ` Dan Williams
2019-03-19 21:01 ` [PATCH 0/6] security/keys/encrypted: Break module dependency chain Dan Williams
2019-03-19 21:01 ` Dan Williams
2019-03-19 21:08 ` James Bottomley
2019-03-19 21:08 ` James Bottomley
2019-03-19 21:08 ` James Bottomley
2019-03-19 21:23 ` Dan Williams
2019-03-19 21:23 ` Dan Williams
2019-03-19 21:23 ` Dan Williams
2019-03-20 1:20 ` Mimi Zohar
2019-03-20 1:20 ` Mimi Zohar
2019-03-20 1:20 ` Mimi Zohar
2019-03-20 1:20 ` Mimi Zohar
2019-03-21 13:45 ` Jarkko Sakkinen
2019-03-21 13:45 ` Jarkko Sakkinen
2019-03-21 13:45 ` Jarkko Sakkinen
2019-03-21 13:48 ` Jarkko Sakkinen
2019-03-21 13:48 ` Jarkko Sakkinen
2019-03-21 13:48 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155297560738.2276575.13044997734939158888.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=dhowells@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.