All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC
Date: Tue, 02 Apr 2019 22:16:15 +0200	[thread overview]
Message-ID: <1554236175.2828.5.camel@suse.de> (raw)
In-Reply-To: <20190402130153.338e59c6cfda1ed3ec882517@linux-foundation.org>

On Tue, 2019-04-02 at 13:01 -0700, Andrew Morton wrote:
> It took a bit of sleuthing to figure out that this patch applies to
> Mike's "hugetlbfs: fix potential over/underflow setting node specific
> nr_hugepages".  Should they be folded together?  I'm thinking not.

Sorry Andrew, I should have mentioned that this patch was based on
Mike's "hugetlb fix potential over/underflow" patch.

Given said that, I would keep the two patches separated, as that one
is a fix, and this one is a cleanup.

> (Also, should "hugetlbfs: fix potential over/underflow setting node
> specific nr_hugepages" have been -stableified?  I also think not, but
> I
> bet it happens anyway).

I am not sure of the consequences in older branches, but if it is not
too much of a hassle, it might be worth? Mike might know better here.

-- 
Oscar Salvador
SUSE L3

  parent reply	other threads:[~2019-04-02 20:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02 13:34 [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC Oscar Salvador
2019-04-02 18:37 ` Mike Kravetz
2019-04-02 20:01 ` Andrew Morton
2019-04-02 20:09   ` Mike Kravetz
2019-04-02 20:16   ` Oscar Salvador [this message]
2019-04-02 20:16     ` Oscar Salvador
2019-04-03  5:44 ` Naoya Horiguchi
2019-04-03  7:52 ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554236175.2828.5.camel@suse.de \
    --to=osalvador@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.