From: Robin Gong <yibin.gong@nxp.com> To: "broonie@kernel.org" <broonie@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "plyatov@gmail.com" <plyatov@gmail.com>, "sean.nyekjaer@prevas.dk" <sean.nyekjaer@prevas.dk> Cc: dl-linux-imx <linux-imx@nxp.com>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de> Subject: [PATCH v1 00/15] add ecspi ERR009165 for i.mx6/7 soc family Date: Tue, 23 Apr 2019 13:50:34 +0000 [thread overview] Message-ID: <1556027045-5269-1-git-send-email-yibin.gong@nxp.com> (raw) There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO transfer to be send twice in DMA mode. Please get more information from: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding new sdma ram script which works in XCH mode as PIO inside sdma instead of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0. The issue should be exist on all legacy i.mx6/7 soc family before i.mx6ul, NXP fix this design issue from i.mx6ul, so newer chips such as i.mx6ull/ i.mx8mq/i.mx8mm, don't need this workaroud anymore. This patch set add new 'fsl,imx6ul-ecspi' for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need errata or not. The first two reverted patches should be the same issue, though, it seems 'fixed' by changing to other shp script. Hope Sean or Sascha could have the chance to test this patch set if could fix their issues. Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work on i.mx8mm because the event id is zero. PS: Please get sdma firmware from below linux-firmware and copy it to your local rootfs /lib/firmware/imx/sdma. https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma Robin Gong (15): Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Revert "dmaengine: imx-sdma: refine to load context only once" dmaengine: imx-sdma: remove dupilicated sdma_load_context dma: engine: imx-sdma: add mcu_2_ecspi script spi: imx: fix ERR009165 spi: imx: remove ERR009165 workaround on i.mx6ul dt-bindings: spi: imx: add i.mx6ul to state errata fixed dmaengine: imx-sdma: remove ERR009165 on i.mx6ul dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm ARM64: dts: freescale: imx8mm/8mq: update new compatible name for ecspi and sdma ARM: dts: imx6ul: add dma support on ecspi ARM: dts: imx6sll: correct ecspi/sdma compatible arm64: defconfig: Enable SDMA on i.mx8mq/8mm .../devicetree/bindings/dma/fsl-imx-sdma.txt | 2 + .../devicetree/bindings/spi/fsl-imx-cspi.txt | 2 + arch/arm/boot/dts/imx6q.dtsi | 2 +- arch/arm/boot/dts/imx6qdl.dtsi | 8 +-- arch/arm/boot/dts/imx6sll.dtsi | 10 ++-- arch/arm/boot/dts/imx6ul.dtsi | 8 +++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 14 ++--- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 +- arch/arm64/configs/defconfig | 3 + drivers/dma/imx-sdma.c | 67 ++++++++++++++++------ drivers/spi/spi-imx.c | 46 ++++++++++++--- include/linux/platform_data/dma-imx-sdma.h | 1 + 12 files changed, 124 insertions(+), 45 deletions(-) -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Robin Gong <yibin.gong@nxp.com> To: "broonie@kernel.org" <broonie@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "plyatov@gmail.com" <plyatov@gmail.com>, "sean.nyekjaer@prevas.dk" <sean.nyekjaer@prevas.dk> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: [PATCH v1 00/15] add ecspi ERR009165 for i.mx6/7 soc family Date: Tue, 23 Apr 2019 13:50:34 +0000 [thread overview] Message-ID: <1556027045-5269-1-git-send-email-yibin.gong@nxp.com> (raw) There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO transfer to be send twice in DMA mode. Please get more information from: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding new sdma ram script which works in XCH mode as PIO inside sdma instead of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0. The issue should be exist on all legacy i.mx6/7 soc family before i.mx6ul, NXP fix this design issue from i.mx6ul, so newer chips such as i.mx6ull/ i.mx8mq/i.mx8mm, don't need this workaroud anymore. This patch set add new 'fsl,imx6ul-ecspi' for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need errata or not. The first two reverted patches should be the same issue, though, it seems 'fixed' by changing to other shp script. Hope Sean or Sascha could have the chance to test this patch set if could fix their issues. Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work on i.mx8mm because the event id is zero. PS: Please get sdma firmware from below linux-firmware and copy it to your local rootfs /lib/firmware/imx/sdma. https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma Robin Gong (15): Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Revert "dmaengine: imx-sdma: refine to load context only once" dmaengine: imx-sdma: remove dupilicated sdma_load_context dma: engine: imx-sdma: add mcu_2_ecspi script spi: imx: fix ERR009165 spi: imx: remove ERR009165 workaround on i.mx6ul dt-bindings: spi: imx: add i.mx6ul to state errata fixed dmaengine: imx-sdma: remove ERR009165 on i.mx6ul dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm ARM64: dts: freescale: imx8mm/8mq: update new compatible name for ecspi and sdma ARM: dts: imx6ul: add dma support on ecspi ARM: dts: imx6sll: correct ecspi/sdma compatible arm64: defconfig: Enable SDMA on i.mx8mq/8mm .../devicetree/bindings/dma/fsl-imx-sdma.txt | 2 + .../devicetree/bindings/spi/fsl-imx-cspi.txt | 2 + arch/arm/boot/dts/imx6q.dtsi | 2 +- arch/arm/boot/dts/imx6qdl.dtsi | 8 +-- arch/arm/boot/dts/imx6sll.dtsi | 10 ++-- arch/arm/boot/dts/imx6ul.dtsi | 8 +++ arch/arm64/boot/dts/freescale/imx8mm.dtsi | 14 ++--- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 +- arch/arm64/configs/defconfig | 3 + drivers/dma/imx-sdma.c | 67 ++++++++++++++++------ drivers/spi/spi-imx.c | 46 ++++++++++++--- include/linux/platform_data/dma-imx-sdma.h | 1 + 12 files changed, 124 insertions(+), 45 deletions(-) -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-04-23 13:50 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-23 13:50 Robin Gong [this message] 2019-04-23 13:50 ` [PATCH v1 00/15] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong 2019-04-23 13:50 ` Robin Gong 2019-04-23 13:50 ` [v1,01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong 2019-04-23 13:50 ` [PATCH v1 01/15] " Robin Gong 2019-04-23 13:50 ` Robin Gong 2019-04-23 13:50 ` Robin Gong 2022-05-19 17:57 ` Vinod Koul 2022-05-19 17:57 ` Vinod Koul 2019-04-23 13:50 ` [v1,03/15] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong 2019-04-23 13:50 ` [PATCH v1 03/15] " Robin Gong 2019-04-23 13:50 ` Robin Gong 2019-04-23 13:50 ` Robin Gong 2022-05-19 17:58 ` Vinod Koul 2022-05-19 17:58 ` Vinod Koul 2019-04-23 13:50 [v1,02/15] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong 2019-04-23 13:50 ` [PATCH v1 02/15] " Robin Gong 2019-04-23 13:50 ` Robin Gong 2019-04-23 13:50 ` Robin Gong 2019-04-23 13:50 [v1,04/15] dmaengine: imx-sdma: remove dupilicated sdma_load_context Robin Gong 2019-04-23 13:50 ` [PATCH v1 04/15] " Robin Gong 2019-04-23 13:50 ` Robin Gong 2019-04-23 13:50 ` Robin Gong 2019-04-23 13:51 [v1,05/15] dma: engine: imx-sdma: add mcu_2_ecspi script Robin Gong 2019-04-23 13:51 ` [PATCH v1 05/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,06/15] spi: imx: fix ERR009165 Robin Gong 2019-04-23 13:51 ` [PATCH v1 06/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,07/15] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong 2019-04-23 13:51 ` [PATCH v1 07/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed Robin Gong 2019-04-23 13:51 ` [PATCH v1 08/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,09/15] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong 2019-04-23 13:51 ` [PATCH v1 09/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,10/15] dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name Robin Gong 2019-04-23 13:51 ` [PATCH v1 10/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Robin Gong 2019-04-23 13:51 ` [PATCH v1 11/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,12/15] ARM64: dts: freescale: imx8mm/8mq: update new compatible name for ecspi and sdma Robin Gong 2019-04-23 13:51 ` [PATCH v1 12/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,13/15] ARM: dts: imx6ul: add dma support on ecspi Robin Gong 2019-04-23 13:51 ` [PATCH v1 13/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,14/15] ARM: dts: imx6sll: correct ecspi/sdma compatible Robin Gong 2019-04-23 13:51 ` [PATCH v1 14/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 [v1,15/15] arm64: defconfig: Enable SDMA on i.mx8mq/8mm Robin Gong 2019-04-23 13:51 ` [PATCH v1 15/15] " Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 13:51 ` Robin Gong 2019-04-23 14:02 [v1,01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Fabio Estevam 2019-04-23 14:02 ` [PATCH v1 01/15] " Fabio Estevam 2019-04-23 14:02 ` Fabio Estevam 2019-04-23 14:02 ` Fabio Estevam 2019-04-23 14:02 ` Fabio Estevam 2019-04-23 14:03 [v1,02/15] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Fabio Estevam 2019-04-23 14:03 ` [PATCH v1 02/15] " Fabio Estevam 2019-04-23 14:03 ` Fabio Estevam 2019-04-23 14:03 ` Fabio Estevam 2019-04-23 14:03 ` Fabio Estevam 2019-04-23 14:12 [v1,09/15] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Fabio Estevam 2019-04-23 14:12 ` [PATCH v1 09/15] " Fabio Estevam 2019-04-23 14:12 ` Fabio Estevam 2019-04-23 14:12 ` Fabio Estevam 2019-04-23 14:12 ` Fabio Estevam 2019-04-24 2:59 [v1,01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong 2019-04-24 2:59 ` [EXT] Re: [PATCH v1 01/15] " Robin Gong 2019-04-24 2:59 ` Robin Gong 2019-04-24 2:59 ` Robin Gong 2019-04-24 2:59 ` Robin Gong 2019-04-24 6:32 [v1,07/15] spi: imx: remove ERR009165 workaround on i.mx6ul Sascha Hauer 2019-04-24 6:32 ` [PATCH v1 07/15] " s.hauer 2019-04-24 6:32 ` s.hauer 2019-04-24 6:32 ` s.hauer 2019-04-24 6:32 ` s.hauer 2019-04-24 6:37 [v1,14/15] ARM: dts: imx6sll: correct ecspi/sdma compatible Sascha Hauer 2019-04-24 6:37 ` [PATCH v1 14/15] " s.hauer 2019-04-24 6:37 ` s.hauer 2019-04-24 6:37 ` s.hauer 2019-04-24 9:06 [v1,14/15] " Robin Gong 2019-04-24 9:06 ` [EXT] Re: [PATCH v1 14/15] " Robin Gong 2019-04-24 9:06 ` Robin Gong 2019-04-24 9:06 ` Robin Gong 2019-04-24 9:06 ` Robin Gong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1556027045-5269-1-git-send-email-yibin.gong@nxp.com \ --to=yibin.gong@nxp.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=plyatov@gmail.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=sean.nyekjaer@prevas.dk \ --cc=shawnguo@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.