From: Abhishek Ambure <aambure@codeaurora.org>
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Abhishek Ambure <aambure@codeaurora.org>
Subject: [PATCH 1/2] ath10k: move pktlog connect service before htc start
Date: Fri, 17 May 2019 15:35:15 +0530 [thread overview]
Message-ID: <1558087516-666-2-git-send-email-aambure@codeaurora.org> (raw)
In-Reply-To: <1558087516-666-1-git-send-email-aambure@codeaurora.org>
WCN3990 supports HTC service for pktlog. PKTLOG service should be
connected before HTC start. Hence move connect pktlog service before
HTC start
Fixes: 713358c321f4 ("ath10k: enable pktlog for WCN3990 target")
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/htc.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c
index 805a7f8..e2980fe9 100644
--- a/drivers/net/wireless/ath/ath10k/htc.c
+++ b/drivers/net/wireless/ath/ath10k/htc.c
@@ -893,6 +893,14 @@ int ath10k_htc_start(struct ath10k_htc *htc)
int status = 0;
struct ath10k_htc_msg *msg;
+ if (ath10k_htc_pktlog_svc_supported(ar)) {
+ status = ath10k_htc_pktlog_connect(ar);
+ if (status) {
+ ath10k_err(ar, "failed to connect to pktlog: %d\n", status);
+ return status;
+ }
+ }
+
skb = ath10k_htc_build_tx_ctrl_skb(htc->ar);
if (!skb)
return -ENOMEM;
@@ -919,14 +927,6 @@ int ath10k_htc_start(struct ath10k_htc *htc)
return status;
}
- if (ath10k_htc_pktlog_svc_supported(ar)) {
- status = ath10k_htc_pktlog_connect(ar);
- if (status) {
- ath10k_err(ar, "failed to connect to pktlog: %d\n", status);
- return status;
- }
- }
-
return 0;
}
--
1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Abhishek Ambure <aambure@codeaurora.org>
To: ath10k@lists.infradead.org
Cc: Abhishek Ambure <aambure@codeaurora.org>, linux-wireless@vger.kernel.org
Subject: [PATCH 1/2] ath10k: move pktlog connect service before htc start
Date: Fri, 17 May 2019 15:35:15 +0530 [thread overview]
Message-ID: <1558087516-666-2-git-send-email-aambure@codeaurora.org> (raw)
In-Reply-To: <1558087516-666-1-git-send-email-aambure@codeaurora.org>
WCN3990 supports HTC service for pktlog. PKTLOG service should be
connected before HTC start. Hence move connect pktlog service before
HTC start
Fixes: 713358c321f4 ("ath10k: enable pktlog for WCN3990 target")
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00963-QCAHLSWMTPL-1
Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/htc.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c
index 805a7f8..e2980fe9 100644
--- a/drivers/net/wireless/ath/ath10k/htc.c
+++ b/drivers/net/wireless/ath/ath10k/htc.c
@@ -893,6 +893,14 @@ int ath10k_htc_start(struct ath10k_htc *htc)
int status = 0;
struct ath10k_htc_msg *msg;
+ if (ath10k_htc_pktlog_svc_supported(ar)) {
+ status = ath10k_htc_pktlog_connect(ar);
+ if (status) {
+ ath10k_err(ar, "failed to connect to pktlog: %d\n", status);
+ return status;
+ }
+ }
+
skb = ath10k_htc_build_tx_ctrl_skb(htc->ar);
if (!skb)
return -ENOMEM;
@@ -919,14 +927,6 @@ int ath10k_htc_start(struct ath10k_htc *htc)
return status;
}
- if (ath10k_htc_pktlog_svc_supported(ar)) {
- status = ath10k_htc_pktlog_connect(ar);
- if (status) {
- ath10k_err(ar, "failed to connect to pktlog: %d\n", status);
- return status;
- }
- }
-
return 0;
}
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-05-17 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 10:05 [PATCH 0/2] correction in pktlog service connect and pktlog enable command Abhishek Ambure
2019-05-17 10:05 ` Abhishek Ambure
2019-05-17 10:05 ` Abhishek Ambure [this message]
2019-05-17 10:05 ` [PATCH 1/2] ath10k: move pktlog connect service before htc start Abhishek Ambure
2019-05-17 10:05 ` [PATCH 2/2] ath10k: correct wmi_tlv command params to enable pktlog for WCN3990 Abhishek Ambure
2019-05-17 10:05 ` Abhishek Ambure
2019-09-18 13:45 ` Kalle Valo
2019-09-18 13:45 ` Kalle Valo
2019-09-23 7:53 ` Kalle Valo
2019-09-23 7:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558087516-666-2-git-send-email-aambure@codeaurora.org \
--to=aambure@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.