Re: [Qemu-devel] [PULL 00/19] Migration patches - no-reply

From: no-reply@patchew.org
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, thuth@redhat.com,
	kvm@vger.kernel.org, quintela@redhat.com, dgilbert@redhat.com,
	pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PULL 00/19] Migration patches
Date: Fri, 12 Jul 2019 07:33:01 -0700 (PDT)	[thread overview]
Message-ID: <156294197990.12463.16232422939322749551@c4a48874b076> (raw)
In-Reply-To: <20190711104412.31233-1-quintela@redhat.com>

Patchew URL: https://patchew.org/QEMU/20190711104412.31233-1-quintela@redhat.com/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190711104412.31233-1-quintela@redhat.com
Type: series
Subject: [Qemu-devel] [PULL 00/19] Migration patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
209c284 migration: allow private destination ram with x-ignore-shared
c008de3 migration: Split log_clear() into smaller chunks
1b98b96 kvm: Support KVM_CLEAR_DIRTY_LOG
6850c34 kvm: Introduce slots lock for memory listener
787a3e9 kvm: Persistent per kvmslot dirty bitmap
18fb631 kvm: Update comments for sync_dirty_bitmap
86d95e6 memory: Introduce memory listener hook log_clear()
d1063f1 memory: Pass mr into snapshot_and_clear_dirty
3fafbda bitmap: Add bitmap_copy_with_{src|dst}_offset()
78c643f memory: Don't set migration bitmap when without migration
c5bac6d migration: No need to take rcu during sync_dirty_bitmap
ea445e2 migratioin/ram.c: reset complete_round when we gets a queued page
e8e5e91 migration/multifd: sync packet_num after all thread are done
e5c62ba cutils: remove one unnecessary pointer operation
5914c83 migration/xbzrle: update cache and current_data in one place
404656a migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS
fd522f6 migration-test: Add migration multifd test
410a42b migration-test: rename parameter to parameter_int
c4c921a migration: fix multifd_recv event typo

=== OUTPUT BEGIN ===
1/19 Checking commit c4c921ae438d (migration: fix multifd_recv event typo)
2/19 Checking commit 410a42b0779f (migration-test: rename parameter to parameter_int)
3/19 Checking commit fd522f622bf7 (migration-test: Add migration multifd test)
4/19 Checking commit 404656a2b029 (migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS)
5/19 Checking commit 5914c835270c (migration/xbzrle: update cache and current_data in one place)
6/19 Checking commit e5c62ba89d60 (cutils: remove one unnecessary pointer operation)
7/19 Checking commit e8e5e91626d2 (migration/multifd: sync packet_num after all thread are done)
8/19 Checking commit ea445e253364 (migratioin/ram.c: reset complete_round when we gets a queued page)
9/19 Checking commit c5bac6deb363 (migration: No need to take rcu during sync_dirty_bitmap)
10/19 Checking commit 78c643f8c785 (memory: Don't set migration bitmap when without migration)
11/19 Checking commit 3fafbda5afa5 (bitmap: Add bitmap_copy_with_{src|dst}_offset())
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#67: 
new file mode 100644

total: 0 errors, 1 warnings, 193 lines checked

Patch 11/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/19 Checking commit d1063f1461e2 (memory: Pass mr into snapshot_and_clear_dirty)
13/19 Checking commit 86d95e6ce000 (memory: Introduce memory listener hook log_clear())
14/19 Checking commit 18fb63138295 (kvm: Update comments for sync_dirty_bitmap)
15/19 Checking commit 787a3e91dbe7 (kvm: Persistent per kvmslot dirty bitmap)
16/19 Checking commit 6850c3495802 (kvm: Introduce slots lock for memory listener)
17/19 Checking commit 1b98b966ec31 (kvm: Support KVM_CLEAR_DIRTY_LOG)
WARNING: line over 80 characters
#201: FILE: accel/kvm/kvm-all.c:1054:
+    KVMMemoryListener *kml = container_of(listener, KVMMemoryListener, listener);

total: 0 errors, 1 warnings, 217 lines checked

Patch 17/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/19 Checking commit c008de3513ac (migration: Split log_clear() into smaller chunks)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

ERROR: trailing whitespace
#48: FILE: include/exec/memory.h.rej:6:
+ $

ERROR: trailing whitespace
#670: FILE: memory.c.rej:6:
+ $

ERROR: trailing whitespace
#5765: FILE: migration/ram.c.rej:4:
+ $

ERROR: trailing whitespace
#5772: FILE: migration/ram.c.rej:11:
+ $

total: 4 errors, 1 warnings, 6000 lines checked

Patch 18/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

19/19 Checking commit 209c2845db95 (migration: allow private destination ram with x-ignore-shared)
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20190711104412.31233-1-quintela@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com