From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Stephen Boyd <swboyd@chromium.org>, cgel.zte@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run Cc: robdclark@gmail.com, airlied@linux.ie, daniel@ffwll.ch, angelogioacchino.delregno@collabora.com, daniel.thompson@linaro.org, linmq006@gmail.com, christophe.jaillet@wanadoo.fr, lv.ruyi@zte.com.cn, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn> Subject: Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map() Date: Tue, 26 Apr 2022 00:11:20 +0300 [thread overview] Message-ID: <1564e2b1-e205-aa44-6a30-38a5160b0ec3@linaro.org> (raw) In-Reply-To: <CAE-0n53xBM+n__eKKGaCuB+3Ea4O+rNk2PUQbD2bjW3JS7YJBA@mail.gmail.com> On 25/04/2022 23:11, Stephen Boyd wrote: > Quoting cgel.zte@gmail.com (2022-04-25 02:18:31) >> From: Lv Ruyi <lv.ruyi@zte.com.cn> >> >> The irq_of_parse_and_map() function returns 0 on failure, and does not >> return a negative value anyhow, so never enter this conditional branch. >> >> Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains") >> Reported-by: Zeal Robot <zealci@zte.com.cn> >> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> >> --- > > This one fixes a commit that moved away from platform APIs! The change was introduced in 2014 in the commit f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains"). I can suspect that at that time platform irq code wasn't fully compatible with IRQ domains. > Reviewed-by: Stephen Boyd <swboyd@chromium.org> -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Stephen Boyd <swboyd@chromium.org>, cgel.zte@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run Cc: linmq006@gmail.com, airlied@linux.ie, linux-arm-msm@vger.kernel.org, lv.ruyi@zte.com.cn, daniel.thompson@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, christophe.jaillet@wanadoo.fr, freedreno@lists.freedesktop.org, Zeal Robot <zealci@zte.com.cn>, angelogioacchino.delregno@collabora.com Subject: Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map() Date: Tue, 26 Apr 2022 00:11:20 +0300 [thread overview] Message-ID: <1564e2b1-e205-aa44-6a30-38a5160b0ec3@linaro.org> (raw) In-Reply-To: <CAE-0n53xBM+n__eKKGaCuB+3Ea4O+rNk2PUQbD2bjW3JS7YJBA@mail.gmail.com> On 25/04/2022 23:11, Stephen Boyd wrote: > Quoting cgel.zte@gmail.com (2022-04-25 02:18:31) >> From: Lv Ruyi <lv.ruyi@zte.com.cn> >> >> The irq_of_parse_and_map() function returns 0 on failure, and does not >> return a negative value anyhow, so never enter this conditional branch. >> >> Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains") >> Reported-by: Zeal Robot <zealci@zte.com.cn> >> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> >> --- > > This one fixes a commit that moved away from platform APIs! The change was introduced in 2014 in the commit f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains"). I can suspect that at that time platform irq code wasn't fully compatible with IRQ domains. > Reviewed-by: Stephen Boyd <swboyd@chromium.org> -- With best wishes Dmitry
next prev parent reply other threads:[~2022-04-25 21:11 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-25 9:18 [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map() cgel.zte 2022-04-25 9:18 ` cgel.zte 2022-04-25 20:11 ` Stephen Boyd 2022-04-25 20:11 ` Stephen Boyd 2022-04-25 21:11 ` Dmitry Baryshkov [this message] 2022-04-25 21:11 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1564e2b1-e205-aa44-6a30-38a5160b0ec3@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@linux.ie \ --cc=angelogioacchino.delregno@collabora.com \ --cc=cgel.zte@gmail.com \ --cc=christophe.jaillet@wanadoo.fr \ --cc=daniel.thompson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linmq006@gmail.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lv.ruyi@zte.com.cn \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ --cc=zealci@zte.com.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.