All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Eugen.Hristev@microchip.com>
To: <wsa@the-dreams.de>, <peda@axentia.se>, <mark.rutland@arm.com>,
	<Ludovic.Desroches@microchip.com>, <linux-i2c@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <pierre-yves.mordret@st.com>,
	<alexandre.belloni@bootlin.com>, <robh+dt@kernel.org>
Cc: <Nicolas.Ferre@microchip.com>, <Eugen.Hristev@microchip.com>
Subject: [PATCH v4 3/9] i2c: add support for filter-width-ns optional property
Date: Mon, 2 Sep 2019 10:12:03 +0000	[thread overview]
Message-ID: <1567418773-2427-4-git-send-email-eugen.hristev@microchip.com> (raw)
In-Reply-To: <1567418773-2427-1-git-send-email-eugen.hristev@microchip.com>

From: Eugen Hristev <eugen.hristev@microchip.com>

This optional timing property specifies the width of the spikes on the i2c
lines (in ns) that can be filtered out by built-in analog or digital filters
which are embedded in some i2c controllers.
Include it in the timings structure and read it as integer property.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 drivers/i2c/i2c-core-base.c | 2 ++
 include/linux/i2c.h         | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index f26ed49..804197e 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1658,6 +1658,8 @@ void i2c_parse_fw_timings(struct device *dev, struct i2c_timings *t, bool use_de
 		t->sda_fall_ns = t->scl_fall_ns;
 
 	device_property_read_u32(dev, "i2c-sda-hold-time-ns", &t->sda_hold_ns);
+
+	device_property_read_u32(dev, "i2c-filter-width-ns", &t->filter_width_ns);
 }
 EXPORT_SYMBOL_GPL(i2c_parse_fw_timings);
 
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index fa5552c..b1e9c39 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -575,6 +575,7 @@ struct i2c_lock_operations {
  * @scl_int_delay_ns: time IP core additionally needs to setup SCL in ns
  * @sda_fall_ns: time SDA signal takes to fall in ns; t(f) in the I2C specification
  * @sda_hold_ns: time IP core additionally needs to hold SDA in ns
+ * @filter_width_ns: width in ns of spikes on i2c lines that the IP core can filter out
  */
 struct i2c_timings {
 	u32 bus_freq_hz;
@@ -583,6 +584,7 @@ struct i2c_timings {
 	u32 scl_int_delay_ns;
 	u32 sda_fall_ns;
 	u32 sda_hold_ns;
+	u32 filter_width_ns;
 };
 
 /**
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: <Eugen.Hristev@microchip.com>
To: wsa@the-dreams.de, peda@axentia.se, mark.rutland@arm.com,
	Ludovic.Desroches@microchip.com, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, pierre-yves.mordret@st.com,
	alexandre.belloni@bootlin.com, robh+dt@kernel.org
Cc: Nicolas.Ferre@microchip.com, Eugen.Hristev@microchip.com
Subject: [PATCH v4 3/9] i2c: add support for filter-width-ns optional property
Date: Mon, 2 Sep 2019 10:12:03 +0000	[thread overview]
Message-ID: <1567418773-2427-4-git-send-email-eugen.hristev@microchip.com> (raw)
In-Reply-To: <1567418773-2427-1-git-send-email-eugen.hristev@microchip.com>

From: Eugen Hristev <eugen.hristev@microchip.com>

This optional timing property specifies the width of the spikes on the i2c
lines (in ns) that can be filtered out by built-in analog or digital filters
which are embedded in some i2c controllers.
Include it in the timings structure and read it as integer property.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 drivers/i2c/i2c-core-base.c | 2 ++
 include/linux/i2c.h         | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index f26ed49..804197e 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1658,6 +1658,8 @@ void i2c_parse_fw_timings(struct device *dev, struct i2c_timings *t, bool use_de
 		t->sda_fall_ns = t->scl_fall_ns;
 
 	device_property_read_u32(dev, "i2c-sda-hold-time-ns", &t->sda_hold_ns);
+
+	device_property_read_u32(dev, "i2c-filter-width-ns", &t->filter_width_ns);
 }
 EXPORT_SYMBOL_GPL(i2c_parse_fw_timings);
 
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index fa5552c..b1e9c39 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -575,6 +575,7 @@ struct i2c_lock_operations {
  * @scl_int_delay_ns: time IP core additionally needs to setup SCL in ns
  * @sda_fall_ns: time SDA signal takes to fall in ns; t(f) in the I2C specification
  * @sda_hold_ns: time IP core additionally needs to hold SDA in ns
+ * @filter_width_ns: width in ns of spikes on i2c lines that the IP core can filter out
  */
 struct i2c_timings {
 	u32 bus_freq_hz;
@@ -583,6 +584,7 @@ struct i2c_timings {
 	u32 scl_int_delay_ns;
 	u32 sda_fall_ns;
 	u32 sda_hold_ns;
+	u32 filter_width_ns;
 };
 
 /**
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: <Eugen.Hristev@microchip.com>
To: <wsa@the-dreams.de>, <peda@axentia.se>, <mark.rutland@arm.com>,
	<Ludovic.Desroches@microchip.com>, <linux-i2c@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <pierre-yves.mordret@st.com>,
	<alexandre.belloni@bootlin.com>, <robh+dt@kernel.org>
Cc: Eugen.Hristev@microchip.com
Subject: [PATCH v4 3/9] i2c: add support for filter-width-ns optional property
Date: Mon, 2 Sep 2019 10:12:03 +0000	[thread overview]
Message-ID: <1567418773-2427-4-git-send-email-eugen.hristev@microchip.com> (raw)
In-Reply-To: <1567418773-2427-1-git-send-email-eugen.hristev@microchip.com>

From: Eugen Hristev <eugen.hristev@microchip.com>

This optional timing property specifies the width of the spikes on the i2c
lines (in ns) that can be filtered out by built-in analog or digital filters
which are embedded in some i2c controllers.
Include it in the timings structure and read it as integer property.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 drivers/i2c/i2c-core-base.c | 2 ++
 include/linux/i2c.h         | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index f26ed49..804197e 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1658,6 +1658,8 @@ void i2c_parse_fw_timings(struct device *dev, struct i2c_timings *t, bool use_de
 		t->sda_fall_ns = t->scl_fall_ns;
 
 	device_property_read_u32(dev, "i2c-sda-hold-time-ns", &t->sda_hold_ns);
+
+	device_property_read_u32(dev, "i2c-filter-width-ns", &t->filter_width_ns);
 }
 EXPORT_SYMBOL_GPL(i2c_parse_fw_timings);
 
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index fa5552c..b1e9c39 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -575,6 +575,7 @@ struct i2c_lock_operations {
  * @scl_int_delay_ns: time IP core additionally needs to setup SCL in ns
  * @sda_fall_ns: time SDA signal takes to fall in ns; t(f) in the I2C specification
  * @sda_hold_ns: time IP core additionally needs to hold SDA in ns
+ * @filter_width_ns: width in ns of spikes on i2c lines that the IP core can filter out
  */
 struct i2c_timings {
 	u32 bus_freq_hz;
@@ -583,6 +584,7 @@ struct i2c_timings {
 	u32 scl_int_delay_ns;
 	u32 sda_fall_ns;
 	u32 sda_hold_ns;
+	u32 filter_width_ns;
 };
 
 /**
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-09-02 10:12 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02 10:11 [PATCH v4 0/9] i2c: add support for filters Eugen.Hristev
2019-09-02 10:11 ` Eugen.Hristev
2019-09-02 10:11 ` Eugen.Hristev
2019-09-02 10:11 ` [PATCH v4 1/9] dt-bindings: i2c: at91: add new compatible Eugen.Hristev
2019-09-02 10:11   ` Eugen.Hristev
2019-09-02 10:11   ` Eugen.Hristev
2019-09-02 10:44   ` Peter Rosin
2019-09-02 10:44     ` Peter Rosin
2019-09-02 10:44     ` Peter Rosin
2019-09-02 14:12     ` Eugen.Hristev
2019-09-02 14:12       ` Eugen.Hristev
2019-09-02 14:12       ` Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:49   ` Peter Rosin
2019-09-02 10:49     ` Peter Rosin
2019-09-02 10:49     ` Peter Rosin
2019-09-02 14:15     ` Eugen.Hristev
2019-09-02 14:15       ` Eugen.Hristev
2019-09-02 14:15       ` Eugen.Hristev
2019-09-02 14:22       ` Alexandre Belloni
2019-09-02 14:22         ` Alexandre Belloni
2019-09-02 14:40       ` Peter Rosin
2019-09-02 14:40         ` Peter Rosin
2019-09-02 14:40         ` Peter Rosin
2019-09-02 15:47       ` Wolfram Sang
2019-09-02 15:47         ` Wolfram Sang
2019-09-02 10:12 ` Eugen.Hristev [this message]
2019-09-02 10:12   ` [PATCH v4 3/9] i2c: add support for filter-width-ns optional property Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 4/9] i2c: at91: add new platform support for sam9x60 Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 5/9] i2c: at91: add support for digital filtering Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 6/9] i2c: at91: add support for advanced " Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 7/9] i2c: at91: add support for analog filtering Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 8/9] ARM: dts: at91: sama5d2_xplained: add analog and digital filter for i2c Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12 ` [PATCH v4 9/9] ARM: dts: at91: sama5d4_xplained: add " Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev
2019-09-02 10:12   ` Eugen.Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1567418773-2427-4-git-send-email-eugen.hristev@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    --cc=pierre-yves.mordret@st.com \
    --cc=robh+dt@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.