From: Stanley Chu <stanley.chu@mediatek.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"pedrom.sousa@synopsys.com" <pedrom.sousa@synopsys.com>,
"sthumma@codeaurora.org" <sthumma@codeaurora.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel-team@android.com" <kernel-team@android.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"evgreen@chromium.org" <evgreen@chromium.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
"subhashj@codeaurora.org" <subhashj@codeaurora.org>,
"vivek.gautam@codeaurora.org" <vivek.gautam@codeaurora.org>,
"Kuohong Wang (王國鴻)" <kuohong.wang@mediatek.com>,
"Peter Wang (王信友)" <peter.wang@mediatek.com>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
"Andy Teng (鄧如宏)" <Andy.Teng@mediatek.com>
Subject: Re: [PATCH v3 1/3] scsi: core: allow auto suspend override by low-level driver
Date: Mon, 16 Sep 2019 23:55:36 +0800 [thread overview]
Message-ID: <1568649336.16730.22.camel@mtkswgap22> (raw)
In-Reply-To: <bebea62f-8ab0-528f-5634-9b3c06f47ef7@acm.org>
Hi Bart,
> > -
> > + unsigned rpm_autosuspend_on:1; /* Runtime autosuspend */
> > atomic_t disk_events_disable_depth; /* disable depth for disk events */
> The "_on" part in the variable name "rpm_autosuspend_on" is probably
> redundant and the comment could have been more elaborate. Anyway:
OK! Thanks for suggestions. Will fix both in next version.
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Thanks,
Stanley
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "sthumma@codeaurora.org" <sthumma@codeaurora.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
"vivek.gautam@codeaurora.org" <vivek.gautam@codeaurora.org>,
"kernel-team@android.com" <kernel-team@android.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
"Kuohong Wang (王國鴻)" <kuohong.wang@mediatek.com>,
"subhashj@codeaurora.org" <subhashj@codeaurora.org>,
"evgreen@chromium.org" <evgreen@chromium.org>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Peter Wang (王信友)" <peter.wang@mediatek.com>,
alim.akhtar@samsung.
Subject: Re: [PATCH v3 1/3] scsi: core: allow auto suspend override by low-level driver
Date: Mon, 16 Sep 2019 23:55:36 +0800 [thread overview]
Message-ID: <1568649336.16730.22.camel@mtkswgap22> (raw)
In-Reply-To: <bebea62f-8ab0-528f-5634-9b3c06f47ef7@acm.org>
Hi Bart,
> > -
> > + unsigned rpm_autosuspend_on:1; /* Runtime autosuspend */
> > atomic_t disk_events_disable_depth; /* disable depth for disk events */
> The "_on" part in the variable name "rpm_autosuspend_on" is probably
> redundant and the comment could have been more elaborate. Anyway:
OK! Thanks for suggestions. Will fix both in next version.
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Thanks,
Stanley
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "sthumma@codeaurora.org" <sthumma@codeaurora.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
"vivek.gautam@codeaurora.org" <vivek.gautam@codeaurora.org>,
"kernel-team@android.com" <kernel-team@android.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
"Kuohong Wang (王國鴻)" <kuohong.wang@mediatek.com>,
"subhashj@codeaurora.org" <subhashj@codeaurora.org>,
"evgreen@chromium.org" <evgreen@chromium.org>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Peter Wang (王信友)" <peter.wang@mediatek.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"Andy Teng (鄧如宏)" <Andy.Teng@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"pedrom.sousa@synopsys.com" <pedrom.sousa@synopsys.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"beanhuo@micron.com" <beanhuo@micron.com>
Subject: Re: [PATCH v3 1/3] scsi: core: allow auto suspend override by low-level driver
Date: Mon, 16 Sep 2019 23:55:36 +0800 [thread overview]
Message-ID: <1568649336.16730.22.camel@mtkswgap22> (raw)
In-Reply-To: <bebea62f-8ab0-528f-5634-9b3c06f47ef7@acm.org>
Hi Bart,
> > -
> > + unsigned rpm_autosuspend_on:1; /* Runtime autosuspend */
> > atomic_t disk_events_disable_depth; /* disable depth for disk events */
> The "_on" part in the variable name "rpm_autosuspend_on" is probably
> redundant and the comment could have been more elaborate. Anyway:
OK! Thanks for suggestions. Will fix both in next version.
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Thanks,
Stanley
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-16 15:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 6:47 [PATCH v3 0/3] scsi: core: allow auto suspend override by low-level driver Stanley Chu
2019-09-16 6:47 ` Stanley Chu
2019-09-16 6:47 ` Stanley Chu
2019-09-16 6:47 ` [PATCH v3 1/3] " Stanley Chu
2019-09-16 6:47 ` Stanley Chu
2019-09-16 6:47 ` Stanley Chu
2019-09-16 15:16 ` Bart Van Assche
2019-09-16 15:16 ` Bart Van Assche
2019-09-16 15:16 ` Bart Van Assche
2019-09-16 15:55 ` Stanley Chu [this message]
2019-09-16 15:55 ` Stanley Chu
2019-09-16 15:55 ` Stanley Chu
2019-09-16 6:47 ` [PATCH v3 2/3] scsi: ufs: override auto suspend tunables for ufs Stanley Chu
2019-09-16 6:47 ` Stanley Chu
2019-09-16 6:47 ` Stanley Chu
2019-09-16 12:33 ` [EXT] " Bean Huo (beanhuo)
2019-09-16 12:33 ` Bean Huo (beanhuo)
2019-09-16 12:33 ` Bean Huo (beanhuo)
2019-09-16 6:47 ` [PATCH v3 3/3] scsi: ufs-mediatek: enable auto suspend capability Stanley Chu
2019-09-16 6:47 ` Stanley Chu
2019-09-16 6:47 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568649336.16730.22.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=Andy.Teng@mediatek.com \
--cc=Chun-hung.Wu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=evgreen@chromium.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=pedrom.sousa@synopsys.com \
--cc=peter.wang@mediatek.com \
--cc=sthumma@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.