Re: [PATCH RESEND v7 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

From: Min Guo <min.guo@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Bin Liu <b-liu@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	<chunfeng.yun@mediatek.com>, <linux-usb@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>, <tony@atomide.com>,
	<hdegoede@redhat.com>
Subject: Re: [PATCH RESEND v7 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller
Date: Fri, 18 Oct 2019 11:41:20 +0800	[thread overview]
Message-ID: <1571370080.28949.5.camel@mhfsdcap03> (raw)
In-Reply-To: <20191017140841.GA20279@bogus>

On Thu, 2019-10-17 at 09:08 -0500, Rob Herring wrote:
> On Thu, 17 Oct 2019 16:25:49 +0800, <min.guo@mediatek.com> wrote:
> > From: Min Guo <min.guo@mediatek.com>
> > 
> > This adds support for MediaTek musb controller in
> > host, peripheral and otg mode.
> > 
> > Signed-off-by: Min Guo <min.guo@mediatek.com>
> > ---
> > changes in v7:
> > 1. Modify compatible as
> > - compatible : should be one of:
> >                "mediatek,mt2701-musb"
> >                ...
> >                followed by "mediatek,mtk-musb"
> > 2. Change usb connector child node compatible as "gpio-usb-b-connector" 
> > 
> > changes in v6:
> > 1. Modify usb connector child node
> > 
> > changes in v5:
> > suggested by Rob:
> > 1. Modify compatible as 
> > - compatible : should be one of:
> >                "mediatek,mt-2701"
> >                ...
> >                followed by "mediatek,mtk-musb"
> > 2. Add usb connector child node
> > 
> > changes in v4:
> > suggested by Sergei:
> > 1. String alignment
> > 
> > changes in v3:
> > 1. no changes
> > 
> > changes in v2:
> > suggested by Bin:
> > 1. Modify DRC to DRD
> > suggested by Rob:
> > 2. Drop the "<soc-model>-musb" in compatible
> > 3. Remove phy-names
> > 4. Add space after comma in clock-names
> > ---
> >  .../devicetree/bindings/usb/mediatek,musb.txt      | 55 ++++++++++++++++++++++
> >  1 file changed, 55 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > 
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.

> If a tag was not added on purpose, please state why and what changed.
OK,thanks. I will add Acked-by/Reviewed-by tags in the next version.