From: Mimi Zohar <zohar@linux.ibm.com> To: "Serge E. Hallyn" <serge@hallyn.com>, Petr Vorel <pvorel@suse.cz> Cc: "Jerry Snitselaar" <jsnitsel@redhat.com>, "Jarkko Sakkinen" <jarkko.sakkinen@linux.intel.com>, Nayna <nayna@linux.vnet.ibm.com>, linux-integrity <linux-integrity@vger.kernel.org>, ltp@lists.linux.it, "Piotr Król" <piotr.krol@3mdeb.com>, "Peter Huewe" <peterhuewe@gmx.de>, "Jason Gunthorpe" <jgg@ziepe.ca> Subject: Re: [LTP] [PATCH] ima: skip verifying TPM 2.0 PCR values Date: Fri, 25 Oct 2019 09:22:15 -0400 [thread overview] Message-ID: <1572009735.4532.17.camel@linux.ibm.com> (raw) In-Reply-To: <20191025125202.GA1966@mail.hallyn.com> On Fri, 2019-10-25 at 07:52 -0500, Serge E. Hallyn wrote: > On Fri, Oct 25, 2019 at 10:56:17AM +0200, Petr Vorel wrote: > > Hi, > > > > > /sys/kernel/security/tpmX/major_version (on fedora and rhel at > least, is it elsewhere on other distros?) This patch doesn't define a securityfs file. It must be a soft link to the actual file. > > > versus > > > > > /sys/class/tpm/tpmX/major_version This is a softlink to the TPM device (eg. /sys/devices/xxxx/.../tpm/tpm0). > > > > Is it more HW related (/sys/class/tpm/tpmX) or LSM related > > (/sys/kernel/security/tpmX)? > > I guess /sys/kernel/security/tpmX might be better. > > This is purely about whether the phsyical TPM chip is 1.2 or 2., > right? /sys/class/tpm/tpmX is where I would expect to find that. > > > Thanks for implementing this, I'll try to test it soon. > > Yes, it's been a pain point, and someone (..., I) should have done this years > ago - thanks! +1
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com> To: ltp@lists.linux.it Subject: [LTP] [PATCH] ima: skip verifying TPM 2.0 PCR values Date: Fri, 25 Oct 2019 09:22:15 -0400 [thread overview] Message-ID: <1572009735.4532.17.camel@linux.ibm.com> (raw) In-Reply-To: <20191025125202.GA1966@mail.hallyn.com> On Fri, 2019-10-25 at 07:52 -0500, Serge E. Hallyn wrote: > On Fri, Oct 25, 2019 at 10:56:17AM +0200, Petr Vorel wrote: > > Hi, > > > > > /sys/kernel/security/tpmX/major_version (on fedora and rhel at > least, is it elsewhere on other distros?) This patch doesn't define a securityfs file.??It must be a soft link to the actual file. > > > versus > > > > > /sys/class/tpm/tpmX/major_version This is a softlink to the TPM device (eg. /sys/devices/xxxx/.../tpm/tpm0). > > > > Is it more HW related (/sys/class/tpm/tpmX) or LSM related > > (/sys/kernel/security/tpmX)? > > I guess /sys/kernel/security/tpmX might be better. > > This is purely about whether the phsyical TPM chip is 1.2 or 2., > right? /sys/class/tpm/tpmX is where I would expect to find that. > > > Thanks for implementing this, I'll try to test it soon. > > Yes, it's been a pain point, and someone (..., I) should have done this years > ago - thanks! +1
next prev parent reply other threads:[~2019-10-25 13:22 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-16 21:12 [PATCH] ima: skip verifying TPM 2.0 PCR values Mimi Zohar 2019-05-16 21:12 ` [LTP] " Mimi Zohar 2019-05-17 6:51 ` Petr Vorel 2019-05-17 6:51 ` [LTP] " Petr Vorel 2019-05-17 11:19 ` Mimi Zohar 2019-05-17 11:19 ` [LTP] " Mimi Zohar 2019-05-17 11:28 ` Petr Vorel 2019-05-17 11:28 ` [LTP] " Petr Vorel 2019-05-17 13:50 ` Nayna 2019-05-17 13:50 ` [LTP] " Nayna 2019-05-17 15:04 ` Petr Vorel 2019-05-17 15:04 ` [LTP] " Petr Vorel 2019-10-24 12:18 ` Petr Vorel 2019-10-24 12:18 ` Petr Vorel 2019-10-24 17:20 ` Jarkko Sakkinen 2019-10-24 17:20 ` Jarkko Sakkinen 2019-10-24 18:20 ` Jason Gunthorpe 2019-10-24 18:20 ` Jason Gunthorpe 2019-10-24 19:14 ` Jarkko Sakkinen 2019-10-24 19:14 ` Jarkko Sakkinen 2019-10-24 23:36 ` Jason Gunthorpe 2019-10-24 23:36 ` Jason Gunthorpe 2019-10-28 20:51 ` Jarkko Sakkinen 2019-10-28 20:51 ` Jarkko Sakkinen 2019-10-24 21:38 ` Jerry Snitselaar 2019-10-24 21:38 ` Jerry Snitselaar 2019-10-24 23:26 ` Jason Gunthorpe 2019-10-24 23:26 ` Jason Gunthorpe 2019-10-25 0:47 ` Mimi Zohar 2019-10-25 0:47 ` Mimi Zohar 2019-10-25 2:11 ` Jerry Snitselaar 2019-10-25 2:11 ` Jerry Snitselaar 2019-10-25 8:56 ` Petr Vorel 2019-10-25 8:56 ` Petr Vorel 2019-10-25 12:52 ` Serge E. Hallyn 2019-10-25 12:52 ` Serge E. Hallyn 2019-10-25 13:22 ` Mimi Zohar [this message] 2019-10-25 13:22 ` Mimi Zohar 2019-10-25 13:25 ` Petr Vorel 2019-10-25 13:25 ` Petr Vorel 2019-10-25 14:13 ` Jerry Snitselaar 2019-10-25 14:13 ` Jerry Snitselaar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1572009735.4532.17.camel@linux.ibm.com \ --to=zohar@linux.ibm.com \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=jgg@ziepe.ca \ --cc=jsnitsel@redhat.com \ --cc=linux-integrity@vger.kernel.org \ --cc=ltp@lists.linux.it \ --cc=nayna@linux.vnet.ibm.com \ --cc=peterhuewe@gmx.de \ --cc=piotr.krol@3mdeb.com \ --cc=pvorel@suse.cz \ --cc=serge@hallyn.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.