From: no-reply@patchew.org
To: philmd@redhat.com
Cc: sstabellini@kernel.org, ehabkost@redhat.com, paul@xen.org,
mst@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com,
hpoussin@reactos.org, amarkovic@wavecomp.com,
imammedo@redhat.com, anthony.perard@citrix.com,
xen-devel@lists.xenproject.org, aleksandar.rikalo@rt-rk.com,
philmd@redhat.com, aurelien@aurel32.net, rth@twiddle.net
Subject: Re: [Xen-devel] [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge
Date: Wed, 30 Oct 2019 05:41:15 -0700 (PDT) [thread overview]
Message-ID: <157243927314.32191.16877694454505392132@37313f22b938> (raw)
In-Reply-To: <20191026180143.7369-1-philmd@redhat.com>
Patchew URL: https://patchew.org/QEMU/20191026180143.7369-1-philmd@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Xen-devel] [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge
Type: series
Message-id: 20191026180143.7369-1-philmd@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
1688439..844178e master -> master
Switched to a new branch 'test'
dff7d02 hw/pci-host/i440fx: Remove the last PIIX3 traces
1867a85 hw/pci-host: Rename incorrectly named 'piix' as 'i440fx'
474b121 hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c
2be85e3 hw/pci-host/piix: Fix code style issues
8d47836 hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h
486b8c8 hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers
3b8d9a8 hw/pci-host/piix: Move RCR_IOPORT register definition
81f9a29 hw/pci-host/piix: Extract piix3_create()
c52f9e8 hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers
f1f8cc1 hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c
b3e67a2 hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()
010fea9 hw/mips/mips_malta: Create IDE hard drive array dynamically
7eb4ef4 piix4: Add a MC146818 RTC Controller as specified in datasheet
081681a piix4: Add an i8254 PIT Controller as specified in datasheet
1324e3c piix4: Add an i8257 DMA Controller as specified in datasheet
1575c16 piix4: Rename PIIX4 object to piix4-isa
94e1fc6 Revert "irq: introduce qemu_irq_proxy()"
97363d5 piix4: Add an i8259 Interrupt Controller as specified in datasheet
a4fae07 piix4: Add the Reset Control Register
cdf07cc MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets
=== OUTPUT BEGIN ===
1/20 Checking commit cdf07cc06443 (MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets)
2/20 Checking commit a4fae0781590 (piix4: Add the Reset Control Register)
3/20 Checking commit 97363d58b691 (piix4: Add an i8259 Interrupt Controller as specified in datasheet)
4/20 Checking commit 94e1fc693918 (Revert "irq: introduce qemu_irq_proxy()")
5/20 Checking commit 1575c16a5e0a (piix4: Rename PIIX4 object to piix4-isa)
6/20 Checking commit 1324e3c5245d (piix4: Add an i8257 DMA Controller as specified in datasheet)
7/20 Checking commit 081681a42b68 (piix4: Add an i8254 PIT Controller as specified in datasheet)
8/20 Checking commit 7eb4ef4e008c (piix4: Add a MC146818 RTC Controller as specified in datasheet)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#195:
deleted file mode 100644
total: 0 errors, 1 warnings, 166 lines checked
Patch 8/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/20 Checking commit 010fea91a9c0 (hw/mips/mips_malta: Create IDE hard drive array dynamically)
10/20 Checking commit b3e67a2aee92 (hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create())
11/20 Checking commit f1f8cc125a08 (hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c)
12/20 Checking commit c52f9e82acd5 (hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers)
13/20 Checking commit 81f9a29fcead (hw/pci-host/piix: Extract piix3_create())
14/20 Checking commit 3b8d9a8dcae0 (hw/pci-host/piix: Move RCR_IOPORT register definition)
15/20 Checking commit 486b8c8b809e (hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers)
16/20 Checking commit 8d47836f5a7e (hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#100:
new file mode 100644
total: 0 errors, 1 warnings, 101 lines checked
Patch 16/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/20 Checking commit 2be85e397d14 (hw/pci-host/piix: Fix code style issues)
18/20 Checking commit 474b121662e8 (hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#67:
new file mode 100644
ERROR: spaces required around that '*' (ctx:VxV)
#316: FILE: hw/isa/piix3.c:245:
+ .subsections = (const VMStateDescription*[]) {
^
total: 1 errors, 1 warnings, 937 lines checked
Patch 18/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/20 Checking commit 1867a8558d6e (hw/pci-host: Rename incorrectly named 'piix' as 'i440fx')
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
rename from hw/pci-host/piix.c
total: 0 errors, 1 warnings, 32 lines checked
Patch 19/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/20 Checking commit dff7d02fcc42 (hw/pci-host/i440fx: Remove the last PIIX3 traces)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191026180143.7369-1-philmd@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: no-reply@patchew.org
To: philmd@redhat.com
Cc: sstabellini@kernel.org, ehabkost@redhat.com, paul@xen.org,
mst@redhat.com, qemu-devel@nongnu.org,
marcel.apfelbaum@gmail.com, pbonzini@redhat.com,
hpoussin@reactos.org, amarkovic@wavecomp.com,
imammedo@redhat.com, anthony.perard@citrix.com,
xen-devel@lists.xenproject.org, aleksandar.rikalo@rt-rk.com,
philmd@redhat.com, aurelien@aurel32.net, rth@twiddle.net
Subject: Re: [Xen-devel] [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge
Date: Wed, 30 Oct 2019 05:41:15 -0700 (PDT) [thread overview]
Message-ID: <157243927314.32191.16877694454505392132@37313f22b938> (raw)
In-Reply-To: <20191026180143.7369-1-philmd@redhat.com>
Patchew URL: https://patchew.org/QEMU/20191026180143.7369-1-philmd@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Xen-devel] [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge
Type: series
Message-id: 20191026180143.7369-1-philmd@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
1688439..844178e master -> master
Switched to a new branch 'test'
dff7d02 hw/pci-host/i440fx: Remove the last PIIX3 traces
1867a85 hw/pci-host: Rename incorrectly named 'piix' as 'i440fx'
474b121 hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c
2be85e3 hw/pci-host/piix: Fix code style issues
8d47836 hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h
486b8c8 hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers
3b8d9a8 hw/pci-host/piix: Move RCR_IOPORT register definition
81f9a29 hw/pci-host/piix: Extract piix3_create()
c52f9e8 hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers
f1f8cc1 hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c
b3e67a2 hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()
010fea9 hw/mips/mips_malta: Create IDE hard drive array dynamically
7eb4ef4 piix4: Add a MC146818 RTC Controller as specified in datasheet
081681a piix4: Add an i8254 PIT Controller as specified in datasheet
1324e3c piix4: Add an i8257 DMA Controller as specified in datasheet
1575c16 piix4: Rename PIIX4 object to piix4-isa
94e1fc6 Revert "irq: introduce qemu_irq_proxy()"
97363d5 piix4: Add an i8259 Interrupt Controller as specified in datasheet
a4fae07 piix4: Add the Reset Control Register
cdf07cc MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets
=== OUTPUT BEGIN ===
1/20 Checking commit cdf07cc06443 (MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets)
2/20 Checking commit a4fae0781590 (piix4: Add the Reset Control Register)
3/20 Checking commit 97363d58b691 (piix4: Add an i8259 Interrupt Controller as specified in datasheet)
4/20 Checking commit 94e1fc693918 (Revert "irq: introduce qemu_irq_proxy()")
5/20 Checking commit 1575c16a5e0a (piix4: Rename PIIX4 object to piix4-isa)
6/20 Checking commit 1324e3c5245d (piix4: Add an i8257 DMA Controller as specified in datasheet)
7/20 Checking commit 081681a42b68 (piix4: Add an i8254 PIT Controller as specified in datasheet)
8/20 Checking commit 7eb4ef4e008c (piix4: Add a MC146818 RTC Controller as specified in datasheet)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#195:
deleted file mode 100644
total: 0 errors, 1 warnings, 166 lines checked
Patch 8/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/20 Checking commit 010fea91a9c0 (hw/mips/mips_malta: Create IDE hard drive array dynamically)
10/20 Checking commit b3e67a2aee92 (hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create())
11/20 Checking commit f1f8cc125a08 (hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c)
12/20 Checking commit c52f9e82acd5 (hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers)
13/20 Checking commit 81f9a29fcead (hw/pci-host/piix: Extract piix3_create())
14/20 Checking commit 3b8d9a8dcae0 (hw/pci-host/piix: Move RCR_IOPORT register definition)
15/20 Checking commit 486b8c8b809e (hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers)
16/20 Checking commit 8d47836f5a7e (hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#100:
new file mode 100644
total: 0 errors, 1 warnings, 101 lines checked
Patch 16/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/20 Checking commit 2be85e397d14 (hw/pci-host/piix: Fix code style issues)
18/20 Checking commit 474b121662e8 (hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#67:
new file mode 100644
ERROR: spaces required around that '*' (ctx:VxV)
#316: FILE: hw/isa/piix3.c:245:
+ .subsections = (const VMStateDescription*[]) {
^
total: 1 errors, 1 warnings, 937 lines checked
Patch 18/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/20 Checking commit 1867a8558d6e (hw/pci-host: Rename incorrectly named 'piix' as 'i440fx')
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71:
rename from hw/pci-host/piix.c
total: 0 errors, 1 warnings, 32 lines checked
Patch 19/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/20 Checking commit dff7d02fcc42 (hw/pci-host/i440fx: Remove the last PIIX3 traces)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20191026180143.7369-1-philmd@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-30 12:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 18:01 [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 01/20] MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 02/20] piix4: Add the Reset Control Register Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 03/20] piix4: Add an i8259 Interrupt Controller as specified in datasheet Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 04/20] Revert "irq: introduce qemu_irq_proxy()" Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 05/20] piix4: Rename PIIX4 object to piix4-isa Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 06/20] piix4: Add an i8257 DMA Controller as specified in datasheet Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 07/20] piix4: Add an i8254 PIT " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 08/20] piix4: Add a MC146818 RTC " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 09/20] hw/mips/mips_malta: Create IDE hard drive array dynamically Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 10/20] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create() Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 11/20] hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 12/20] hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 13/20] hw/pci-host/piix: Extract piix3_create() Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 14/20] hw/pci-host/piix: Move RCR_IOPORT register definition Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 15/20] hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 16/20] hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 17/20] hw/pci-host/piix: Fix code style issues Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 18/20] hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 19/20] hw/pci-host: Rename incorrectly named 'piix' as 'i440fx' Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-26 18:01 ` [PATCH v3 20/20] hw/pci-host/i440fx: Remove the last PIIX3 traces Philippe Mathieu-Daudé
2019-10-26 18:01 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-27 7:44 ` [PATCH v3 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge Aleksandar Markovic
2019-10-27 7:44 ` [Xen-devel] " Aleksandar Markovic
2019-10-30 9:53 ` Philippe Mathieu-Daudé
2019-10-30 9:53 ` [Xen-devel] " Philippe Mathieu-Daudé
2019-10-30 13:48 ` Aleksandar Markovic
2019-10-30 13:48 ` [Xen-devel] " Aleksandar Markovic
2019-10-30 12:41 ` no-reply [this message]
2019-10-30 12:41 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157243927314.32191.16877694454505392132@37313f22b938 \
--to=no-reply@patchew.org \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=anthony.perard@citrix.com \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.