Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Don't select BROKEN
Date: Wed, 06 Nov 2019 12:24:03 +0200	[thread overview]
Message-ID: <157303584321.10062.10632976886717947313@jlahtine-desk.ger.corp.intel.com> (raw)
In-Reply-To: <157298841686.18566.729698423669886628@skylake-alporthouse-com>

Quoting Chris Wilson (2019-11-05 23:13:36)
> Quoting Daniel Vetter (2019-11-05 20:58:25)
> > On Tue, Nov 5, 2019 at 9:38 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Quoting Daniel Vetter (2019-11-05 19:38:29)
> > > > It's broken.
> > > >
> > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > References: https://lists.freedesktop.org/archives/dri-devel/2019-November/242625.html
> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > ---
> > > > Note: Probably best to apply this directly onto drm-next to avoid
> > > > having drm-next dropped from linux-next until the next pull request.
> > > > -Daniel
> > > > ---
> > > >  drivers/gpu/drm/i915/Kconfig.debug | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> > > > index ef123eb29168..d2ba8f7e5e50 100644
> > > > --- a/drivers/gpu/drm/i915/Kconfig.debug
> > > > +++ b/drivers/gpu/drm/i915/Kconfig.debug
> > > > @@ -44,7 +44,6 @@ config DRM_I915_DEBUG
> > > >         select DRM_I915_SELFTEST
> > > >         select DRM_I915_DEBUG_RUNTIME_PM
> > > >         select DRM_I915_DEBUG_MMIO
> > > > -       select BROKEN # for prototype uAPI
> > >
> > > You have to replace it with another secret bool as you cannot otherwise
> > > enable CONFIG_BROKEN in .config.
> > 
> > Or this:
> > 
> > diff --git a/init/Kconfig b/init/Kconfig
> > index b4daad2bac23..4dbea1b9e6bb 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -75,6 +75,7 @@ menu "General setup"
> > 
> >  config BROKEN
> >         bool
> > +       default y
> > 
> >  config BROKEN_ON_SMP
> >         bool
> > 
> > Either way it needs to be in topic/core-for-CI, not in any official
> > tree. Because if you allow autobuilders to enable CONFIG_BROKEN, no
> > matter how well hidden, they'll all break. You can also just revert my
> > patch that Dave pushed to drm-next (to get us back into the linux-next
> > club).
> 
> Fwiw, I think the revert in core-for-CI is reasonable, as that gives
> devs the ability to toggle on the hidden menus, while at the same time
> requiring them to have the minimal debug setup.

I've now reverted this in core-for-CI.

Regards, Joonas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel