From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/i915: change to_mock() to an inline function
Date: Fri, 08 Nov 2019 09:12:07 +0000 [thread overview]
Message-ID: <157320432699.9461.10436519336108145423@skylake-alporthouse-com> (raw)
In-Reply-To: <20191108051356.29980-1-yamada.masahiro@socionext.com>
Quoting Masahiro Yamada (2019-11-08 05:13:55)
> Since this function is defined in a header file, it should be
> 'static inline' instead of 'static'.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/i915: change to_mock() to an inline function
Date: Fri, 08 Nov 2019 09:12:07 +0000 [thread overview]
Message-ID: <157320432699.9461.10436519336108145423@skylake-alporthouse-com> (raw)
In-Reply-To: <20191108051356.29980-1-yamada.masahiro@socionext.com>
Quoting Masahiro Yamada (2019-11-08 05:13:55)
> Since this function is defined in a header file, it should be
> 'static inline' instead of 'static'.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH 1/2] drm/i915: change to_mock() to an inline function
Date: Fri, 08 Nov 2019 09:12:07 +0000 [thread overview]
Message-ID: <157320432699.9461.10436519336108145423@skylake-alporthouse-com> (raw)
Message-ID: <20191108091207.G8E-yvh0vhP379TMAFCdDdgVaiRWKNrV1pTrJJS7YQQ@z> (raw)
In-Reply-To: <20191108051356.29980-1-yamada.masahiro@socionext.com>
Quoting Masahiro Yamada (2019-11-08 05:13:55)
> Since this function is defined in a header file, it should be
> 'static inline' instead of 'static'.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: change to_mock() to an inline function
Date: Fri, 08 Nov 2019 09:12:07 +0000 [thread overview]
Message-ID: <157320432699.9461.10436519336108145423@skylake-alporthouse-com> (raw)
Message-ID: <20191108091207.d-kf-w_UH0p6UAsPYwRgHBvyBIUqYNGE7av29NjuazY@z> (raw)
In-Reply-To: <20191108051356.29980-1-yamada.masahiro@socionext.com>
Quoting Masahiro Yamada (2019-11-08 05:13:55)
> Since this function is defined in a header file, it should be
> 'static inline' instead of 'static'.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-08 9:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 5:13 [PATCH 1/2] drm/i915: change to_mock() to an inline function Masahiro Yamada
2019-11-08 5:13 ` [Intel-gfx] " Masahiro Yamada
2019-11-08 5:13 ` Masahiro Yamada
2019-11-08 5:13 ` [PATCH 2/2] drm/i915: make more headers self-contained Masahiro Yamada
2019-11-08 5:13 ` [Intel-gfx] " Masahiro Yamada
2019-11-08 5:13 ` Masahiro Yamada
2019-11-08 5:42 ` Masahiro Yamada
2019-11-08 5:42 ` [Intel-gfx] " Masahiro Yamada
2019-11-08 5:42 ` Masahiro Yamada
2019-11-08 8:16 ` Chris Wilson
2019-11-08 8:16 ` [Intel-gfx] " Chris Wilson
2019-11-08 8:16 ` Chris Wilson
2019-11-08 5:34 ` ✗ Fi.CI.BUILD: failure for series starting with [1/2] drm/i915: change to_mock() to an inline function Patchwork
2019-11-08 5:34 ` [Intel-gfx] " Patchwork
2019-11-08 9:12 ` Chris Wilson [this message]
2019-11-08 9:12 ` [Intel-gfx] [PATCH 1/2] " Chris Wilson
2019-11-08 9:12 ` Chris Wilson
2019-11-08 9:12 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157320432699.9461.10436519336108145423@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.kuoppala@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.