From: Giovanni Gherdovich <ggherdovich@suse.cz> To: kbuild test robot <lkp@intel.com> Cc: kbuild-all@lists.01.org, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@suse.de>, Len Brown <lenb@kernel.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Mel Gorman <mgorman@techsingularity.net>, Matt Fleming <matt@codeblueprint.co.uk>, Viresh Kumar <viresh.kumar@linaro.org>, Juri Lelli <juri.lelli@redhat.com>, Paul Turner <pjt@google.com>, Vincent Guittot <vincent.guittot@linaro.org>, Quentin Perret <qperret@qperret.net>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Doug Smythies <dsmythies@telus.net> Subject: Re: [PATCH 6/6] x86: intel_pstate: handle runtime turbo disablement/enablement in freq. invariance Date: Wed, 13 Nov 2019 13:26:15 +0100 [thread overview] Message-ID: <1573647975.2933.17.camel@suse.cz> (raw) In-Reply-To: <201911130542.dtVRgDKU%lkp@intel.com> On Wed, 2019-11-13 at 05:28 +0800, kbuild test robot wrote: > Hi Giovanni, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on tip/sched/core] > [cannot apply to v5.4-rc7 next-20191111] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Giovanni-Gherdovich/Add-support-for-frequency-invariance-for-some-x86/20191113-035438 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a0e813f26ebcb25c0b5e504498fbd796cca1a4ba > config: i386-randconfig-e001-201945 (attached as .config) > compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > drivers/cpufreq/intel_pstate.c: In function 'intel_pstate_update_limits': > > > drivers/cpufreq/intel_pstate.c:925:3: error: implicit declaration of function 'set_arch_max_freq' [-Werror=implicit-function-declaration] > > set_arch_max_freq(global.turbo_disabled); > ^~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > Good bot. I'm defining the function set_arch_max_freq only if CONFIG_SMP, I forgot to provide a definition (with empty body) in the other case. Resending. Giovanni > vim +/set_arch_max_freq +925 drivers/cpufreq/intel_pstate.c > > 913 > 914 static void intel_pstate_update_limits(unsigned int cpu) > 915 { > 916 mutex_lock(&intel_pstate_driver_lock); > 917 > 918 update_turbo_state(); > 919 /* > 920 * If turbo has been turned on or off globally, policy limits for > 921 * all CPUs need to be updated to reflect that. > 922 */ > 923 if (global.turbo_disabled_mf != global.turbo_disabled) { > 924 global.turbo_disabled_mf = global.turbo_disabled; > > 925 set_arch_max_freq(global.turbo_disabled); > 926 for_each_possible_cpu(cpu) > 927 intel_pstate_update_max_freq(cpu); > 928 } else { > 929 cpufreq_update_policy(cpu); > 930 } > 931 > 932 mutex_unlock(&intel_pstate_driver_lock); > 933 } > 934 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Giovanni Gherdovich <ggherdovich@suse.cz> To: kbuild-all@lists.01.org Subject: Re: [PATCH 6/6] x86: intel_pstate: handle runtime turbo disablement/enablement in freq. invariance Date: Wed, 13 Nov 2019 13:26:15 +0100 [thread overview] Message-ID: <1573647975.2933.17.camel@suse.cz> (raw) In-Reply-To: <201911130542.dtVRgDKU%lkp@intel.com> [-- Attachment #1: Type: text/plain, Size: 2643 bytes --] On Wed, 2019-11-13 at 05:28 +0800, kbuild test robot wrote: > Hi Giovanni, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on tip/sched/core] > [cannot apply to v5.4-rc7 next-20191111] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Giovanni-Gherdovich/Add-support-for-frequency-invariance-for-some-x86/20191113-035438 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a0e813f26ebcb25c0b5e504498fbd796cca1a4ba > config: i386-randconfig-e001-201945 (attached as .config) > compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > drivers/cpufreq/intel_pstate.c: In function 'intel_pstate_update_limits': > > > drivers/cpufreq/intel_pstate.c:925:3: error: implicit declaration of function 'set_arch_max_freq' [-Werror=implicit-function-declaration] > > set_arch_max_freq(global.turbo_disabled); > ^~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > Good bot. I'm defining the function set_arch_max_freq only if CONFIG_SMP, I forgot to provide a definition (with empty body) in the other case. Resending. Giovanni > vim +/set_arch_max_freq +925 drivers/cpufreq/intel_pstate.c > > 913 > 914 static void intel_pstate_update_limits(unsigned int cpu) > 915 { > 916 mutex_lock(&intel_pstate_driver_lock); > 917 > 918 update_turbo_state(); > 919 /* > 920 * If turbo has been turned on or off globally, policy limits for > 921 * all CPUs need to be updated to reflect that. > 922 */ > 923 if (global.turbo_disabled_mf != global.turbo_disabled) { > 924 global.turbo_disabled_mf = global.turbo_disabled; > > 925 set_arch_max_freq(global.turbo_disabled); > 926 for_each_possible_cpu(cpu) > 927 intel_pstate_update_max_freq(cpu); > 928 } else { > 929 cpufreq_update_policy(cpu); > 930 } > 931 > 932 mutex_unlock(&intel_pstate_driver_lock); > 933 } > 934 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
next prev parent reply other threads:[~2019-11-13 12:20 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-11 18:05 [PATCH 0/6] Add support for frequency invariance for (some) x86 Giovanni Gherdovich 2019-11-11 18:05 ` [PATCH 1/6] x86,sched: Add support for frequency invariance Giovanni Gherdovich 2019-11-11 18:05 ` [PATCH 2/6] x86,sched: Add support for frequency invariance on SKYLAKE_X Giovanni Gherdovich 2019-11-11 18:05 ` [PATCH 3/6] x86,sched: Add support for frequency invariance on XEON_PHI_KNL/KNM Giovanni Gherdovich 2019-11-11 18:05 ` [PATCH 4/6] x86,sched: Add support for frequency invariance on ATOM_GOLDMONT* Giovanni Gherdovich 2019-11-11 18:05 ` [PATCH 5/6] x86,sched: Add support for frequency invariance on ATOM Giovanni Gherdovich 2019-11-11 18:05 ` [PATCH 6/6] x86: intel_pstate: handle runtime turbo disablement/enablement in freq. invariance Giovanni Gherdovich 2019-11-12 21:28 ` kbuild test robot 2019-11-12 21:28 ` kbuild test robot 2019-11-13 12:26 ` Giovanni Gherdovich [this message] 2019-11-13 12:26 ` Giovanni Gherdovich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1573647975.2933.17.camel@suse.cz \ --to=ggherdovich@suse.cz \ --cc=bp@suse.de \ --cc=dietmar.eggemann@arm.com \ --cc=dsmythies@telus.net \ --cc=juri.lelli@redhat.com \ --cc=kbuild-all@lists.01.org \ --cc=lenb@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lkp@intel.com \ --cc=matt@codeblueprint.co.uk \ --cc=mgorman@techsingularity.net \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=pjt@google.com \ --cc=qperret@qperret.net \ --cc=rjw@rjwysocki.net \ --cc=srinivas.pandruvada@linux.intel.com \ --cc=tglx@linutronix.de \ --cc=vincent.guittot@linaro.org \ --cc=viresh.kumar@linaro.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.