From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andi Shyti <andi@etezian.org>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t 4/5] i915: Exercise sysfs heartbeat controls
Date: Fri, 28 Feb 2020 23:37:22 +0000 [thread overview]
Message-ID: <158293304248.29794.5765520201928001036@skylake-alporthouse-com> (raw)
In-Reply-To: <20200228233448.GE11891@jack.zhora.eu>
Quoting Andi Shyti (2020-02-28 23:34:48)
> On Fri, Feb 28, 2020 at 10:43:39AM +0000, Chris Wilson wrote:
> > We [will] expose various per-engine scheduling controls. One of which,
> > 'heartbeat_duration_ms', defines how often we send a heartbeat down the
> > engine to check upon the health of the engine. If a heartbeat does not
> > complete within the interval (or two), the engine is declared hung.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Someone with not a good eye might swear to have read this patch
> once, and at patch 5/5 he will ask again the same question.
>
> Why don't we put together in a library the things that patch
> 3/4/5 have in common?
They are. It's basically a repeating pattern of testing with local
assumptions. For the sole reason that I'm not very inventive.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andi Shyti <andi@etezian.org>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 4/5] i915: Exercise sysfs heartbeat controls
Date: Fri, 28 Feb 2020 23:37:22 +0000 [thread overview]
Message-ID: <158293304248.29794.5765520201928001036@skylake-alporthouse-com> (raw)
In-Reply-To: <20200228233448.GE11891@jack.zhora.eu>
Quoting Andi Shyti (2020-02-28 23:34:48)
> On Fri, Feb 28, 2020 at 10:43:39AM +0000, Chris Wilson wrote:
> > We [will] expose various per-engine scheduling controls. One of which,
> > 'heartbeat_duration_ms', defines how often we send a heartbeat down the
> > engine to check upon the health of the engine. If a heartbeat does not
> > complete within the interval (or two), the engine is declared hung.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Someone with not a good eye might swear to have read this patch
> once, and at patch 5/5 he will ask again the same question.
>
> Why don't we put together in a library the things that patch
> 3/4/5 have in common?
They are. It's basically a repeating pattern of testing with local
assumptions. For the sole reason that I'm not very inventive.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-28 23:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 10:43 [Intel-gfx] [PATCH i-g-t 1/5] i915: Start putting the mmio_base to wider use Chris Wilson
2020-02-28 10:43 ` [igt-dev] " Chris Wilson
2020-02-28 10:43 ` [Intel-gfx] [PATCH i-g-t 2/5] i915/gem_ctx_isolation: Check engine relative registers Chris Wilson
2020-02-28 19:46 ` Stimson, Dale B
2020-02-28 19:46 ` [igt-dev] " Stimson, Dale B
2020-02-28 10:43 ` [Intel-gfx] [PATCH i-g-t 3/5] i915: Exercise preemption timeout controls in sysfs Chris Wilson
2020-02-28 10:43 ` [igt-dev] " Chris Wilson
2020-02-28 23:27 ` [Intel-gfx] " Andi Shyti
2020-02-28 23:32 ` Chris Wilson
2020-02-28 23:32 ` [igt-dev] " Chris Wilson
2020-02-28 23:51 ` Andi Shyti
2020-02-29 10:21 ` Chris Wilson
2020-02-29 10:21 ` [igt-dev] " Chris Wilson
2020-02-29 12:45 ` Andi Shyti
2020-02-29 18:34 ` Chris Wilson
2020-02-29 18:34 ` [igt-dev] " Chris Wilson
2020-02-29 18:39 ` Chris Wilson
2020-02-28 10:43 ` [Intel-gfx] [PATCH i-g-t 4/5] i915: Exercise sysfs heartbeat controls Chris Wilson
2020-02-28 23:34 ` Andi Shyti
2020-02-28 23:37 ` Chris Wilson [this message]
2020-02-28 23:37 ` [igt-dev] " Chris Wilson
2020-02-28 10:43 ` [Intel-gfx] [PATCH i-g-t 5/5] i915: Exercise timeslice sysfs property Chris Wilson
2020-02-28 10:43 ` [igt-dev] " Chris Wilson
2020-02-28 11:15 ` [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [i-g-t,1/5] i915: Start putting the mmio_base to wider use Patchwork
2020-02-28 11:52 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-02-28 19:45 ` [Intel-gfx] [igt-dev] [PATCH i-g-t 1/5] " Stimson, Dale B
2020-02-28 19:45 ` Stimson, Dale B
2020-02-28 21:27 ` [Intel-gfx] " Andi Shyti
2020-02-28 21:27 ` [igt-dev] " Andi Shyti
2020-03-01 1:09 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/5] " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-03-11 9:34 [Intel-gfx] [PATCH i-g-t 1/5] lib/i915: Create a context wrapping one specific engine Chris Wilson
2020-03-11 9:34 ` [Intel-gfx] [PATCH i-g-t 4/5] i915: Exercise sysfs heartbeat controls Chris Wilson
2020-01-27 12:18 [Intel-gfx] [PATCH i-g-t 1/5] i915: Start putting the mmio_base to wider use Chris Wilson
2020-01-27 12:18 ` [Intel-gfx] [PATCH i-g-t 4/5] i915: Exercise sysfs heartbeat controls Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158293304248.29794.5765520201928001036@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=andi@etezian.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.