From: Stephen Boyd <sboyd@kernel.org> To: Alex Riesen <alexander.riesen@cetitec.com>, Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-clk <linux-clk@vger.kernel.org> Subject: Re: [PATCH v3 05/11] media: adv748x: add support for HDMI audio Date: Fri, 20 Mar 2020 18:09:31 -0700 [thread overview] Message-ID: <158475297119.125146.8177273856843293558@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <82828e89ccf4173de4e5e52dcecacc4d5168315c.1584720678.git.alexander.riesen@cetitec.com> Quoting Alex Riesen (2020-03-20 09:12:00) > diff --git a/drivers/media/i2c/adv748x/adv748x-dai.c b/drivers/media/i2c/adv748x/adv748x-dai.c > new file mode 100644 > index 000000000000..6fce7d000423 > --- /dev/null > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c > @@ -0,0 +1,265 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Driver for Analog Devices ADV748X HDMI receiver with AFE > + * The implementation of DAI. > + */ > + > +#include "adv748x.h" > + > +#include <linux/clk.h> Is this include used? Please try to make a clk provider or a clk consumer and not both unless necessary. > +#include <linux/clk-provider.h> > +#include <sound/pcm_params.h> > + > +#define state_of(soc_dai) \ > + adv748x_dai_to_state(container_of((soc_dai)->driver, \ > + struct adv748x_dai, \ > + drv)) > + > +static const char ADV748X_DAI_NAME[] = "adv748x-i2s"; > + [...] > + .set_sysclk = adv748x_dai_set_sysclk, > + .set_fmt = adv748x_dai_set_fmt, > + .startup = adv748x_dai_startup, > + .hw_params = adv748x_dai_hw_params, > + .mute_stream = adv748x_dai_mute_stream, > + .shutdown = adv748x_dai_shutdown, > +}; > + > +static int adv748x_of_xlate_dai_name(struct snd_soc_component *component, > + struct of_phandle_args *args, > + const char **dai_name) > +{ > + if (dai_name) > + *dai_name = ADV748X_DAI_NAME; > + return 0; > +} > + > +static const struct snd_soc_component_driver adv748x_codec = { > + .of_xlate_dai_name = adv748x_of_xlate_dai_name, > +}; > + > +int adv748x_dai_init(struct adv748x_dai *dai) > +{ > + int ret; > + struct adv748x_state *state = adv748x_dai_to_state(dai); > + > + dai->mclk_name = kasprintf(GFP_KERNEL, "%s.%s-i2s-mclk", > + state->dev->driver->name, > + dev_name(state->dev)); > + if (!dai->mclk_name) { > + ret = -ENOMEM; > + adv_err(state, "No memory for MCLK\n"); > + goto fail; > + } > + dai->mclk = clk_register_fixed_rate(state->dev, Please register with clk_hw_register_fixed_rate() instead. > + dai->mclk_name, > + NULL /* parent_name */, > + 0 /* flags */, > + 12288000 /* rate */); Not sure these comments are useful. > + if (IS_ERR_OR_NULL(dai->mclk)) { > + ret = PTR_ERR(dai->mclk); > + adv_err(state, "Failed to register MCLK (%d)\n", ret); > + goto fail; > + } > + ret = of_clk_add_provider(state->dev->of_node, of_clk_src_simple_get, > + dai->mclk); > + if (ret < 0) { > + adv_err(state, "Failed to add MCLK provider (%d)\n", ret); > + goto unreg_mclk; > + } > + dai->drv.name = ADV748X_DAI_NAME; > + dai->drv.ops = &adv748x_dai_ops; > + dai->drv.capture = (struct snd_soc_pcm_stream){ Can this be const? > + .stream_name = "Capture", > + .channels_min = 8, > + .channels_max = 8, > + .rates = SNDRV_PCM_RATE_48000, > + .formats = SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_U24_LE, > + }; > + > + ret = devm_snd_soc_register_component(state->dev, &adv748x_codec, > + &dai->drv, 1); > + if (ret < 0) { > + adv_err(state, "Failed to register the codec (%d)\n", ret); > + goto cleanup_mclk; > + } > + return 0; > + > +cleanup_mclk: > + of_clk_del_provider(state->dev->of_node); > +unreg_mclk: > + clk_unregister_fixed_rate(dai->mclk); > +fail: > + return ret; > +} > + > +void adv748x_dai_cleanup(struct adv748x_dai *dai) > +{ > + struct adv748x_state *state = adv748x_dai_to_state(dai); > + > + of_clk_del_provider(state->dev->of_node); > + clk_unregister_fixed_rate(dai->mclk); > + kfree(dai->mclk_name); > +} > + Please drop extra newline at end of file.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org> To: Alex Riesen <alexander.riesen@cetitec.com>, Kieran Bingham <kieran.bingham@ideasonboard.com> Cc: Mark Rutland <mark.rutland@arm.com>, devel@driverdev.osuosl.org, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-clk <linux-clk@vger.kernel.org>, linux-media@vger.kernel.org Subject: Re: [PATCH v3 05/11] media: adv748x: add support for HDMI audio Date: Fri, 20 Mar 2020 18:09:31 -0700 [thread overview] Message-ID: <158475297119.125146.8177273856843293558@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <82828e89ccf4173de4e5e52dcecacc4d5168315c.1584720678.git.alexander.riesen@cetitec.com> Quoting Alex Riesen (2020-03-20 09:12:00) > diff --git a/drivers/media/i2c/adv748x/adv748x-dai.c b/drivers/media/i2c/adv748x/adv748x-dai.c > new file mode 100644 > index 000000000000..6fce7d000423 > --- /dev/null > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c > @@ -0,0 +1,265 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Driver for Analog Devices ADV748X HDMI receiver with AFE > + * The implementation of DAI. > + */ > + > +#include "adv748x.h" > + > +#include <linux/clk.h> Is this include used? Please try to make a clk provider or a clk consumer and not both unless necessary. > +#include <linux/clk-provider.h> > +#include <sound/pcm_params.h> > + > +#define state_of(soc_dai) \ > + adv748x_dai_to_state(container_of((soc_dai)->driver, \ > + struct adv748x_dai, \ > + drv)) > + > +static const char ADV748X_DAI_NAME[] = "adv748x-i2s"; > + [...] > + .set_sysclk = adv748x_dai_set_sysclk, > + .set_fmt = adv748x_dai_set_fmt, > + .startup = adv748x_dai_startup, > + .hw_params = adv748x_dai_hw_params, > + .mute_stream = adv748x_dai_mute_stream, > + .shutdown = adv748x_dai_shutdown, > +}; > + > +static int adv748x_of_xlate_dai_name(struct snd_soc_component *component, > + struct of_phandle_args *args, > + const char **dai_name) > +{ > + if (dai_name) > + *dai_name = ADV748X_DAI_NAME; > + return 0; > +} > + > +static const struct snd_soc_component_driver adv748x_codec = { > + .of_xlate_dai_name = adv748x_of_xlate_dai_name, > +}; > + > +int adv748x_dai_init(struct adv748x_dai *dai) > +{ > + int ret; > + struct adv748x_state *state = adv748x_dai_to_state(dai); > + > + dai->mclk_name = kasprintf(GFP_KERNEL, "%s.%s-i2s-mclk", > + state->dev->driver->name, > + dev_name(state->dev)); > + if (!dai->mclk_name) { > + ret = -ENOMEM; > + adv_err(state, "No memory for MCLK\n"); > + goto fail; > + } > + dai->mclk = clk_register_fixed_rate(state->dev, Please register with clk_hw_register_fixed_rate() instead. > + dai->mclk_name, > + NULL /* parent_name */, > + 0 /* flags */, > + 12288000 /* rate */); Not sure these comments are useful. > + if (IS_ERR_OR_NULL(dai->mclk)) { > + ret = PTR_ERR(dai->mclk); > + adv_err(state, "Failed to register MCLK (%d)\n", ret); > + goto fail; > + } > + ret = of_clk_add_provider(state->dev->of_node, of_clk_src_simple_get, > + dai->mclk); > + if (ret < 0) { > + adv_err(state, "Failed to add MCLK provider (%d)\n", ret); > + goto unreg_mclk; > + } > + dai->drv.name = ADV748X_DAI_NAME; > + dai->drv.ops = &adv748x_dai_ops; > + dai->drv.capture = (struct snd_soc_pcm_stream){ Can this be const? > + .stream_name = "Capture", > + .channels_min = 8, > + .channels_max = 8, > + .rates = SNDRV_PCM_RATE_48000, > + .formats = SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_U24_LE, > + }; > + > + ret = devm_snd_soc_register_component(state->dev, &adv748x_codec, > + &dai->drv, 1); > + if (ret < 0) { > + adv_err(state, "Failed to register the codec (%d)\n", ret); > + goto cleanup_mclk; > + } > + return 0; > + > +cleanup_mclk: > + of_clk_del_provider(state->dev->of_node); > +unreg_mclk: > + clk_unregister_fixed_rate(dai->mclk); > +fail: > + return ret; > +} > + > +void adv748x_dai_cleanup(struct adv748x_dai *dai) > +{ > + struct adv748x_state *state = adv748x_dai_to_state(dai); > + > + of_clk_del_provider(state->dev->of_node); > + clk_unregister_fixed_rate(dai->mclk); > + kfree(dai->mclk_name); > +} > + Please drop extra newline at end of file. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-21 1:09 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-20 16:11 [PATCH v3 00/11] media: adv748x: add support for HDMI audio Alex Riesen 2020-03-20 16:11 ` Alex Riesen 2020-03-20 16:11 ` [PATCH v3 01/11] media: adv748x: fix end-of-line terminators in diagnostic statements Alex Riesen 2020-03-20 16:11 ` Alex Riesen 2020-03-20 16:11 ` [PATCH v3 02/11] media: adv748x: include everything adv748x.h needs into the file Alex Riesen 2020-03-20 16:11 ` Alex Riesen 2020-03-20 16:11 ` [PATCH v3 03/11] media: adv748x: reduce amount of code for bitwise modifications of device registers Alex Riesen 2020-03-20 16:11 ` Alex Riesen 2020-03-20 16:11 ` [PATCH v3 04/11] media: adv748x: add definitions for audio output related registers Alex Riesen 2020-03-20 16:11 ` Alex Riesen 2020-03-20 16:12 ` [PATCH v3 05/11] media: adv748x: add support for HDMI audio Alex Riesen 2020-03-20 16:12 ` Alex Riesen 2020-03-21 1:09 ` Stephen Boyd [this message] 2020-03-21 1:09 ` Stephen Boyd 2020-03-23 8:36 ` Alex Riesen 2020-03-23 8:36 ` Alex Riesen 2020-03-20 16:12 ` [PATCH v3 06/11] media: adv748x: prepare/enable mclk when the audio is used Alex Riesen 2020-03-20 16:12 ` Alex Riesen 2020-03-20 16:12 ` [PATCH v3 07/11] media: adv748x: only activate DAI if it is described in device tree Alex Riesen 2020-03-20 16:12 ` Alex Riesen 2020-03-20 16:12 ` [PATCH v3 08/11] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Alex Riesen 2020-03-20 16:12 ` Alex Riesen 2020-03-20 16:12 ` [PATCH v3 09/11] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Alex Riesen 2020-03-20 16:12 ` Alex Riesen 2020-03-23 8:34 ` Geert Uytterhoeven 2020-03-23 8:34 ` Geert Uytterhoeven 2020-03-23 8:40 ` Alex Riesen 2020-03-23 8:40 ` Alex Riesen 2020-03-23 8:45 ` Alex Riesen 2020-03-23 8:45 ` Alex Riesen 2020-03-23 8:48 ` Geert Uytterhoeven 2020-03-23 8:48 ` Geert Uytterhoeven 2020-03-23 8:50 ` Alex Riesen 2020-03-23 8:50 ` Alex Riesen 2020-03-20 16:12 ` [PATCH v3 10/11] media: adv748x: add support for log_status ioctl Alex Riesen 2020-03-20 16:12 ` Alex Riesen 2020-03-20 16:12 ` [PATCH v3 11/11] media: adv748x: allow the HDMI sub-device to accept EDID Alex Riesen 2020-03-20 16:12 ` Alex Riesen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=158475297119.125146.8177273856843293558@swboyd.mtv.corp.google.com \ --to=sboyd@kernel.org \ --cc=alexander.riesen@cetitec.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=hverkuil-cisco@xs4all.nl \ --cc=kieran.bingham@ideasonboard.com \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.