From: no-reply@patchew.org
To: its@irrelevant.dk
Cc: kwolf@redhat.com, beata.michalska@linaro.org,
qemu-block@nongnu.org, k.jensen@samsung.com,
qemu-devel@nongnu.org, mreitz@redhat.com, kbusch@kernel.org,
its@irrelevant.dk, javier.gonz@samsung.com, mlevitsk@redhat.com
Subject: Re: [PATCH v7 00/48] nvme: support NVMe v1.3d, SGLs and multiple namespaces
Date: Wed, 15 Apr 2020 01:02:13 -0700 (PDT) [thread overview]
Message-ID: <158693773167.27250.3605083509764023589@39012742ff91> (raw)
In-Reply-To: <20200415055140.466900-1-its@irrelevant.dk>
Patchew URL: https://patchew.org/QEMU/20200415055140.466900-1-its@irrelevant.dk/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v7 00/48] nvme: support NVMe v1.3d, SGLs and multiple namespaces
Message-id: 20200415055140.466900-1-its@irrelevant.dk
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200412210954.32313-1-f4bug@amsat.org -> patchew/20200412210954.32313-1-f4bug@amsat.org
- [tag update] patchew/20200412223619.11284-1-f4bug@amsat.org -> patchew/20200412223619.11284-1-f4bug@amsat.org
- [tag update] patchew/20200415055140.466900-1-its@irrelevant.dk -> patchew/20200415055140.466900-1-its@irrelevant.dk
Switched to a new branch 'test'
4ab23cf nvme: make lba data size configurable
4c8a056 nvme: change controller pci id
506f543 pci: allocate pci id for nvme
95623e7 nvme: support multiple namespaces
d2da14b nvme: refactor identify active namespace id list
bbac04c nvme: add support for sgl bit bucket descriptor
f6c40e0 nvme: add support for scatter gather lists
591ccdf nvme: harden cmb access
c3ccf89 nvme: handle dma errors
75febcd pci: pass along the return value of dma_memory_rw
05048e8 nvme: use preallocated qsg/iov in nvme_dma_prp
9a939bd nvme: add nvme_check_rw helper
d1ff466 nvme: allow multiple aios per command
5dc3864 nvme: remove NvmeCmd parameter
0d6fc35 nvme: refactor NvmeRequest
a77654d nvme: be consistent about zeros vs zeroes
9f7ec64 nvme: add check for mdts
0f0481c nvme: refactor request bounds checking
a9208e4 nvme: verify validity of prp lists in the cmb
19b6a4b nvme: add request mapping helper
bad14d6 nvme: pass request along for tracing
3a9fc50 nvme: refactor dma read/write
e3e7e57 nvme: remove redundant has_sg member
98e643a nvme: replace dma_acct with blk_acct equivalent
8e2a196 nvme: add mapping helpers
6c8bfdf nvme: memset preallocated requests structures
2ded511 nvme: bump supported version to v1.3
f4ea0f2 nvme: provide the mandatory subnqn field
8bf580e nvme: enforce valid queue creation sequence
452a2ff nvme: support identify namespace descriptor list
9e8fd3d nvme: add log specific field to trace events
c9a9106 nvme: make sure ncqr and nsqr is valid
2b53bfa nvme: additional tracing
a212237 nvme: add missing mandatory features
a9a43cf nvme: add support for the asynchronous event request command
f5dcf98 nvme: add support for the get log page command
ce62c52 nvme: add temperature threshold feature
656c989 nvme: refactor device realization
509c349 nvme: remove redundant cmbloc/cmbsz members
42e29cd nvme: add max_ioqpairs device parameter
20e6f29 nvme: fix pci doorbell size calculation
acd84e3 nvme: add support for the abort command
eb96029 nvme: refactor nvme_addr_read
075de60 nvme: use constants in identify
16e4f0d nvme: bump spec data structures to v1.3
5ca5eeb nvme: move device parameters to separate struct
bc6fa5c nvme: remove superfluous breaks
ecbfef5 nvme: rename trace events to nvme_dev
=== OUTPUT BEGIN ===
1/48 Checking commit ecbfef51f105 (nvme: rename trace events to nvme_dev)
2/48 Checking commit bc6fa5cc4955 (nvme: remove superfluous breaks)
3/48 Checking commit 5ca5eeb5d92c (nvme: move device parameters to separate struct)
ERROR: Macros with complex values should be enclosed in parenthesis
#180: FILE: hw/block/nvme.h:6:
+#define DEFINE_NVME_PROPERTIES(_state, _props) \
+ DEFINE_PROP_STRING("serial", _state, _props.serial), \
+ DEFINE_PROP_UINT32("cmb_size_mb", _state, _props.cmb_size_mb, 0), \
+ DEFINE_PROP_UINT32("num_queues", _state, _props.num_queues, 64)
total: 1 errors, 0 warnings, 181 lines checked
Patch 3/48 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/48 Checking commit 16e4f0dd48eb (nvme: bump spec data structures to v1.3)
5/48 Checking commit 075de60b9c58 (nvme: use constants in identify)
6/48 Checking commit eb9602977cf4 (nvme: refactor nvme_addr_read)
7/48 Checking commit acd84e3bbf0d (nvme: add support for the abort command)
8/48 Checking commit 20e6f29fe81d (nvme: fix pci doorbell size calculation)
9/48 Checking commit 42e29cd4ba89 (nvme: add max_ioqpairs device parameter)
10/48 Checking commit 509c349c8755 (nvme: remove redundant cmbloc/cmbsz members)
11/48 Checking commit 656c98958103 (nvme: refactor device realization)
12/48 Checking commit ce62c5295b18 (nvme: add temperature threshold feature)
13/48 Checking commit f5dcf988ef1a (nvme: add support for the get log page command)
14/48 Checking commit a9a43cf3d965 (nvme: add support for the asynchronous event request command)
15/48 Checking commit a21223712932 (nvme: add missing mandatory features)
16/48 Checking commit 2b53bfa79af6 (nvme: additional tracing)
17/48 Checking commit c9a91061dbeb (nvme: make sure ncqr and nsqr is valid)
18/48 Checking commit 9e8fd3ddf0bc (nvme: add log specific field to trace events)
19/48 Checking commit 452a2ffe63ee (nvme: support identify namespace descriptor list)
20/48 Checking commit 8bf580e70657 (nvme: enforce valid queue creation sequence)
21/48 Checking commit f4ea0f21000e (nvme: provide the mandatory subnqn field)
22/48 Checking commit 2ded5117428e (nvme: bump supported version to v1.3)
23/48 Checking commit 6c8bfdfdedac (nvme: memset preallocated requests structures)
24/48 Checking commit 8e2a196c482a (nvme: add mapping helpers)
25/48 Checking commit 98e643a6ff9c (nvme: replace dma_acct with blk_acct equivalent)
26/48 Checking commit e3e7e5712935 (nvme: remove redundant has_sg member)
27/48 Checking commit 3a9fc50dd3d8 (nvme: refactor dma read/write)
28/48 Checking commit bad14d6db88c (nvme: pass request along for tracing)
29/48 Checking commit 19b6a4bc26d6 (nvme: add request mapping helper)
30/48 Checking commit a9208e457a15 (nvme: verify validity of prp lists in the cmb)
31/48 Checking commit 0f0481c13a90 (nvme: refactor request bounds checking)
32/48 Checking commit 9f7ec646dfb3 (nvme: add check for mdts)
33/48 Checking commit a77654d0651b (nvme: be consistent about zeros vs zeroes)
34/48 Checking commit 0d6fc3519806 (nvme: refactor NvmeRequest)
35/48 Checking commit 5dc386494d66 (nvme: remove NvmeCmd parameter)
36/48 Checking commit d1ff466e6519 (nvme: allow multiple aios per command)
37/48 Checking commit 9a939bdbbe7a (nvme: add nvme_check_rw helper)
38/48 Checking commit 05048e848b16 (nvme: use preallocated qsg/iov in nvme_dma_prp)
39/48 Checking commit 75febcd68a46 (pci: pass along the return value of dma_memory_rw)
40/48 Checking commit c3ccf898265d (nvme: handle dma errors)
41/48 Checking commit 591ccdf3c944 (nvme: harden cmb access)
42/48 Checking commit f6c40e0d1671 (nvme: add support for scatter gather lists)
43/48 Checking commit bbac04c4a9c3 (nvme: add support for sgl bit bucket descriptor)
44/48 Checking commit d2da14b49e99 (nvme: refactor identify active namespace id list)
45/48 Checking commit 95623e7d16d1 (nvme: support multiple namespaces)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#218: FILE: hw/block/nvme-ns.h:8:
+#define DEFINE_NVME_NS_PROPERTIES(_state, _props) \
+ DEFINE_PROP_DRIVE("drive", _state, blk), \
+ DEFINE_PROP_UINT32("nsid", _state, _props.nsid, 0)
total: 1 errors, 1 warnings, 841 lines checked
Patch 45/48 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
46/48 Checking commit 506f54399c6a (pci: allocate pci id for nvme)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 46 lines checked
Patch 46/48 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/48 Checking commit 4c8a056f5893 (nvme: change controller pci id)
48/48 Checking commit 4ab23cf5a34f (nvme: make lba data size configurable)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200415055140.466900-1-its@irrelevant.dk/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2020-04-15 8:03 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 5:50 [PATCH v7 00/48] nvme: support NVMe v1.3d, SGLs and multiple namespaces Klaus Jensen
2020-04-15 5:50 ` [PATCH v7 01/48] nvme: rename trace events to nvme_dev Klaus Jensen
2020-04-15 5:50 ` [PATCH v7 02/48] nvme: remove superfluous breaks Klaus Jensen
2020-04-15 6:57 ` Philippe Mathieu-Daudé
2020-04-15 5:50 ` [PATCH v7 03/48] nvme: move device parameters to separate struct Klaus Jensen
2020-04-15 6:58 ` Philippe Mathieu-Daudé
2020-04-15 5:50 ` [PATCH v7 04/48] nvme: bump spec data structures to v1.3 Klaus Jensen
2020-04-15 5:50 ` [PATCH v7 05/48] nvme: use constants in identify Klaus Jensen
2020-04-15 7:01 ` Philippe Mathieu-Daudé
2020-04-15 5:50 ` [PATCH v7 06/48] nvme: refactor nvme_addr_read Klaus Jensen
2020-04-15 7:03 ` Philippe Mathieu-Daudé
2020-04-15 7:46 ` Klaus Birkelund Jensen
2020-04-15 5:50 ` [PATCH v7 07/48] nvme: add support for the abort command Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 08/48] nvme: fix pci doorbell size calculation Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 09/48] nvme: add max_ioqpairs device parameter Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 10/48] nvme: remove redundant cmbloc/cmbsz members Klaus Jensen
2020-04-15 7:10 ` Philippe Mathieu-Daudé
2020-04-15 7:19 ` Klaus Birkelund Jensen
2020-04-15 7:48 ` Philippe Mathieu-Daudé
2020-04-15 5:51 ` [PATCH v7 11/48] nvme: refactor device realization Klaus Jensen
2020-04-15 7:14 ` Philippe Mathieu-Daudé
2020-04-15 7:25 ` Klaus Birkelund Jensen
2020-04-15 7:55 ` Philippe Mathieu-Daudé
2020-04-15 8:18 ` Klaus Birkelund Jensen
2020-04-15 5:51 ` [PATCH v7 12/48] nvme: add temperature threshold feature Klaus Jensen
2020-04-15 7:19 ` Philippe Mathieu-Daudé
2020-04-15 7:24 ` Klaus Birkelund Jensen
2020-04-15 7:28 ` Klaus Birkelund Jensen
2020-04-15 7:45 ` Philippe Mathieu-Daudé
2020-04-15 5:51 ` [PATCH v7 13/48] nvme: add support for the get log page command Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 14/48] nvme: add support for the asynchronous event request command Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 15/48] nvme: add missing mandatory features Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 16/48] nvme: additional tracing Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 17/48] nvme: make sure ncqr and nsqr is valid Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 18/48] nvme: add log specific field to trace events Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 19/48] nvme: support identify namespace descriptor list Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 20/48] nvme: enforce valid queue creation sequence Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 21/48] nvme: provide the mandatory subnqn field Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 22/48] nvme: bump supported version to v1.3 Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 23/48] nvme: memset preallocated requests structures Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 24/48] nvme: add mapping helpers Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 25/48] nvme: replace dma_acct with blk_acct equivalent Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 26/48] nvme: remove redundant has_sg member Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 27/48] nvme: refactor dma read/write Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 28/48] nvme: pass request along for tracing Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 29/48] nvme: add request mapping helper Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 30/48] nvme: verify validity of prp lists in the cmb Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 31/48] nvme: refactor request bounds checking Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 32/48] nvme: add check for mdts Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 33/48] nvme: be consistent about zeros vs zeroes Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 34/48] nvme: refactor NvmeRequest Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 35/48] nvme: remove NvmeCmd parameter Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 36/48] nvme: allow multiple aios per command Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 37/48] nvme: add nvme_check_rw helper Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 38/48] nvme: use preallocated qsg/iov in nvme_dma_prp Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 39/48] pci: pass along the return value of dma_memory_rw Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 40/48] nvme: handle dma errors Klaus Jensen
2020-04-15 7:26 ` Philippe Mathieu-Daudé
2020-04-15 5:51 ` [PATCH v7 41/48] nvme: harden cmb access Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 42/48] nvme: add support for scatter gather lists Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 43/48] nvme: add support for sgl bit bucket descriptor Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 44/48] nvme: refactor identify active namespace id list Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 45/48] nvme: support multiple namespaces Klaus Jensen
2020-04-15 7:38 ` Philippe Mathieu-Daudé
2020-04-15 8:02 ` Klaus Birkelund Jensen
2020-04-15 5:51 ` [PATCH v7 46/48] pci: allocate pci id for nvme Klaus Jensen
2020-04-21 9:19 ` Gerd Hoffmann
2020-04-15 5:51 ` [PATCH v7 47/48] nvme: change controller pci id Klaus Jensen
2020-04-15 5:51 ` [PATCH v7 48/48] nvme: make lba data size configurable Klaus Jensen
2020-04-15 7:40 ` Philippe Mathieu-Daudé
2020-04-15 7:17 ` [PATCH v7 00/48] nvme: support NVMe v1.3d, SGLs and multiple namespaces no-reply
2020-04-15 8:02 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158693773167.27250.3605083509764023589@39012742ff91 \
--to=no-reply@patchew.org \
--cc=beata.michalska@linaro.org \
--cc=its@irrelevant.dk \
--cc=javier.gonz@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.