Re: [PATCH 00/16] nvme: refactoring and cleanups - no-reply

From: no-reply@patchew.org
To: its@irrelevant.dk
Cc: kwolf@redhat.com, beata.michalska@linaro.org,
	qemu-block@nongnu.org, k.jensen@samsung.com,
	qemu-devel@nongnu.org, mreitz@redhat.com, kbusch@kernel.org,
	its@irrelevant.dk, javier.gonz@samsung.com, mlevitsk@redhat.com,
	philmd@redhat.com
Subject: Re: [PATCH 00/16] nvme: refactoring and cleanups
Date: Wed, 15 Apr 2020 06:35:19 -0700 (PDT)	[thread overview]
Message-ID: <158695771775.27250.3145997479693028052@39012742ff91> (raw)
In-Reply-To: <20200415102445.564803-1-its@irrelevant.dk>

Patchew URL: https://patchew.org/QEMU/20200415102445.564803-1-its@irrelevant.dk/

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 00/16] nvme: refactoring and cleanups
Message-id: 20200415102445.564803-1-its@irrelevant.dk
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   2f7cc1f..73995d1  master     -> master
 - [tag update]      patchew/20200414120935.12719-1-peter.maydell@linaro.org -> patchew/20200414120935.12719-1-peter.maydell@linaro.org
 - [tag update]      patchew/20200415074927.19897-1-armbru@redhat.com -> patchew/20200415074927.19897-1-armbru@redhat.com
 - [tag update]      patchew/20200415083048.14339-1-armbru@redhat.com -> patchew/20200415083048.14339-1-armbru@redhat.com
 * [new tag]         patchew/20200415130159.611361-1-its@irrelevant.dk -> patchew/20200415130159.611361-1-its@irrelevant.dk
Switched to a new branch 'test'
36a0670 nvme: factor out controller identify setup
0eba9ad nvme: factor out cmb setup
5b5feee nvme: factor out pci setup
577bb77 nvme: factor out namespace setup
9ac7fae nvme: add namespace helpers
ab9bbca nvme: factor out block backend setup
ba90026 nvme: factor out device state setup
b14d6d1 nvme: factor out property/constraint checks
35fc2dc nvme: remove redundant cmbloc/cmbsz members
802a9ab nvme: add max_ioqpairs device parameter
acf5b71 nvme: refactor nvme_addr_read
945aa26 nvme: use constants in identify
06aee41 nvme: move device parameters to separate struct
d1f279f nvme: remove superfluous breaks
e659f34 nvme: rename trace events to nvme_dev
f6d960a nvme: fix pci doorbell size calculation

=== OUTPUT BEGIN ===
1/16 Checking commit f6d960adefde (nvme: fix pci doorbell size calculation)
2/16 Checking commit e659f3474c29 (nvme: rename trace events to nvme_dev)
3/16 Checking commit d1f279f37080 (nvme: remove superfluous breaks)
4/16 Checking commit 06aee411cb67 (nvme: move device parameters to separate struct)
ERROR: Macros with complex values should be enclosed in parenthesis
#181: FILE: hw/block/nvme.h:6:
+#define DEFINE_NVME_PROPERTIES(_state, _props) \
+    DEFINE_PROP_STRING("serial", _state, _props.serial), \
+    DEFINE_PROP_UINT32("cmb_size_mb", _state, _props.cmb_size_mb, 0), \
+    DEFINE_PROP_UINT32("num_queues", _state, _props.num_queues, 64)

total: 1 errors, 0 warnings, 181 lines checked

Patch 4/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/16 Checking commit 945aa26e4b39 (nvme: use constants in identify)
6/16 Checking commit acf5b7156c93 (nvme: refactor nvme_addr_read)
7/16 Checking commit 802a9ab0f8c1 (nvme: add max_ioqpairs device parameter)
8/16 Checking commit 35fc2dcb7465 (nvme: remove redundant cmbloc/cmbsz members)
9/16 Checking commit b14d6d1afb3e (nvme: factor out property/constraint checks)
10/16 Checking commit ba9002645e0c (nvme: factor out device state setup)
11/16 Checking commit ab9bbcaa7af5 (nvme: factor out block backend setup)
12/16 Checking commit 9ac7faec3567 (nvme: add namespace helpers)
13/16 Checking commit 577bb7783e47 (nvme: factor out namespace setup)
14/16 Checking commit 5b5feee08d6d (nvme: factor out pci setup)
15/16 Checking commit 0eba9ade7b81 (nvme: factor out cmb setup)
16/16 Checking commit 36a0670099c1 (nvme: factor out controller identify setup)
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/20200415102445.564803-1-its@irrelevant.dk/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com