Re: [PATCH 02/16] nvme: rename trace events to nvme_dev - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Klaus Jensen <its@irrelevant.dk>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Beata Michalska <beata.michalska@linaro.org>,
	Klaus Jensen <k.jensen@samsung.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Keith Busch <kbusch@kernel.org>,
	Javier Gonzalez <javier.gonz@samsung.com>,
	Maxim Levitsky <mlevitsk@redhat.com>
Subject: Re: [PATCH 02/16] nvme: rename trace events to nvme_dev
Date: Wed, 15 Apr 2020 13:36:18 +0200	[thread overview]
Message-ID: <83edb49b-56b5-4504-8794-f7fcdf74fd67@redhat.com> (raw)
In-Reply-To: <20200415102445.564803-3-its@irrelevant.dk>

On 4/15/20 12:24 PM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> Change the prefix of all nvme device related trace events to 'nvme_dev'

Another option is 'pci_nvme'. None of them make me happy but I can't 
find a better name.

> to not clash with trace events from the nvme block driver.
> 
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> Acked-by: Keith Busch <kbusch@kernel.org>
> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
>   hw/block/nvme.c       | 190 +++++++++++++++++++++---------------------
>   hw/block/trace-events | 172 +++++++++++++++++++-------------------
>   2 files changed, 180 insertions(+), 182 deletions(-)
> 
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 77f9c151a665..316cfc4d36e0 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -112,16 +112,16 @@ static void nvme_irq_assert(NvmeCtrl *n, NvmeCQueue *cq)
>   {
>       if (cq->irq_enabled) {
>           if (msix_enabled(&(n->parent_obj))) {
> -            trace_nvme_irq_msix(cq->vector);
> +            trace_nvme_dev_irq_msix(cq->vector);
>               msix_notify(&(n->parent_obj), cq->vector);
>           } else {
> -            trace_nvme_irq_pin();
> +            trace_nvme_dev_irq_pin();
>               assert(cq->cqid < 64);
>               n->irq_status |= 1 << cq->cqid;
>               nvme_irq_check(n);
>           }
>       } else {
> -        trace_nvme_irq_masked();
> +        trace_nvme_dev_irq_masked();
>       }
>   }
[...]