From: "Durrant, Paul" <pdurrant@amazon.com> To: "Jürgen Groß" <jgross@suse.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, "Roger Pau Monné" <roger.pau@citrix.com>, "Jens Axboe" <axboe@kernel.dk>, "Boris Ostrovsky" <boris.ostrovsky@oracle.com>, "Stefano Stabellini" <sstabellini@kernel.org> Subject: RE: [PATCH 4/4] xen-blkback: support dynamic unbind/bind Date: Mon, 9 Dec 2019 14:01:43 +0000 [thread overview] Message-ID: <158cb2845bec457fa54c6dfbd5a9efac@EX13D32EUC003.ant.amazon.com> (raw) In-Reply-To: <bbf958af-d435-3a56-1e91-e068125a9ce7@suse.com> > -----Original Message----- > From: Jürgen Groß <jgross@suse.com> > Sent: 09 December 2019 13:58 > To: Durrant, Paul <pdurrant@amazon.com>; linux-kernel@vger.kernel.org; > xen-devel@lists.xenproject.org > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>; Roger Pau Monné > <roger.pau@citrix.com>; Jens Axboe <axboe@kernel.dk>; Boris Ostrovsky > <boris.ostrovsky@oracle.com>; Stefano Stabellini <sstabellini@kernel.org> > Subject: Re: [PATCH 4/4] xen-blkback: support dynamic unbind/bind > > On 05.12.19 15:01, Paul Durrant wrote: > > By simply re-attaching to shared rings during connect_ring() rather than > > assuming they are freshly allocated (i.e assuming the counters are zero) > > it is possible for vbd instances to be unbound and re-bound from and to > > (respectively) a running guest. > > > > This has been tested by running: > > > > while true; do dd if=/dev/urandom of=test.img bs=1M count=1024; done > > > > in a PV guest whilst running: > > > > while true; > > do echo vbd-$DOMID-$VBD >unbind; > > echo unbound; > > sleep 5; > > echo vbd-$DOMID-$VBD >bind; > > echo bound; > > sleep 3; > > done > > > > in dom0 from /sys/bus/xen-backend/drivers/vbd to continuously unbind and > > re-bind its system disk image. > > Could you do the same test with mixed reads/writes and verification of > the read/written data, please? A write-only test is not _that_ > convincing regarding correctness. It only proves the guest is not > crashing. Sure. I'll find something that will verify content. > > I'm fine with the general approach, though. > Cool, thanks, Paul > > Juergen
WARNING: multiple messages have this Message-ID (diff)
From: "Durrant, Paul" <pdurrant@amazon.com> To: "Jürgen Groß" <jgross@suse.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: "Jens Axboe" <axboe@kernel.dk>, "Boris Ostrovsky" <boris.ostrovsky@oracle.com>, "Roger Pau Monné" <roger.pau@citrix.com>, "Stefano Stabellini" <sstabellini@kernel.org>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> Subject: Re: [Xen-devel] [PATCH 4/4] xen-blkback: support dynamic unbind/bind Date: Mon, 9 Dec 2019 14:01:43 +0000 [thread overview] Message-ID: <158cb2845bec457fa54c6dfbd5a9efac@EX13D32EUC003.ant.amazon.com> (raw) In-Reply-To: <bbf958af-d435-3a56-1e91-e068125a9ce7@suse.com> > -----Original Message----- > From: Jürgen Groß <jgross@suse.com> > Sent: 09 December 2019 13:58 > To: Durrant, Paul <pdurrant@amazon.com>; linux-kernel@vger.kernel.org; > xen-devel@lists.xenproject.org > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>; Roger Pau Monné > <roger.pau@citrix.com>; Jens Axboe <axboe@kernel.dk>; Boris Ostrovsky > <boris.ostrovsky@oracle.com>; Stefano Stabellini <sstabellini@kernel.org> > Subject: Re: [PATCH 4/4] xen-blkback: support dynamic unbind/bind > > On 05.12.19 15:01, Paul Durrant wrote: > > By simply re-attaching to shared rings during connect_ring() rather than > > assuming they are freshly allocated (i.e assuming the counters are zero) > > it is possible for vbd instances to be unbound and re-bound from and to > > (respectively) a running guest. > > > > This has been tested by running: > > > > while true; do dd if=/dev/urandom of=test.img bs=1M count=1024; done > > > > in a PV guest whilst running: > > > > while true; > > do echo vbd-$DOMID-$VBD >unbind; > > echo unbound; > > sleep 5; > > echo vbd-$DOMID-$VBD >bind; > > echo bound; > > sleep 3; > > done > > > > in dom0 from /sys/bus/xen-backend/drivers/vbd to continuously unbind and > > re-bind its system disk image. > > Could you do the same test with mixed reads/writes and verification of > the read/written data, please? A write-only test is not _that_ > convincing regarding correctness. It only proves the guest is not > crashing. Sure. I'll find something that will verify content. > > I'm fine with the general approach, though. > Cool, thanks, Paul > > Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-09 14:02 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-05 14:01 [PATCH 0/4] xen-blkback: support live update Paul Durrant 2019-12-05 14:01 ` [Xen-devel] " Paul Durrant 2019-12-05 14:01 ` [PATCH 1/4] xenbus: move xenbus_dev_shutdown() into frontend code Paul Durrant 2019-12-05 14:01 ` [Xen-devel] " Paul Durrant 2019-12-09 11:33 ` Jürgen Groß 2019-12-09 11:33 ` [Xen-devel] " Jürgen Groß 2019-12-09 11:55 ` Durrant, Paul 2019-12-09 11:55 ` [Xen-devel] " Durrant, Paul 2019-12-09 11:57 ` Jürgen Groß 2019-12-09 11:57 ` [Xen-devel] " Jürgen Groß 2019-12-05 14:01 ` [PATCH 2/4] xenbus: limit when state is forced to closed Paul Durrant 2019-12-05 14:01 ` [Xen-devel] " Paul Durrant 2019-12-09 11:39 ` Roger Pau Monné 2019-12-09 11:39 ` Roger Pau Monné 2019-12-09 11:55 ` Jürgen Groß 2019-12-09 11:55 ` Jürgen Groß 2019-12-09 12:03 ` Durrant, Paul 2019-12-09 12:03 ` Durrant, Paul 2019-12-09 12:08 ` Jürgen Groß 2019-12-09 12:08 ` Jürgen Groß 2019-12-09 12:19 ` Durrant, Paul 2019-12-09 12:19 ` Durrant, Paul 2019-12-09 13:38 ` Jürgen Groß 2019-12-09 13:38 ` Jürgen Groß 2019-12-09 14:06 ` Durrant, Paul 2019-12-09 14:06 ` Durrant, Paul 2019-12-09 14:09 ` Jürgen Groß 2019-12-09 14:09 ` Jürgen Groß 2019-12-09 14:23 ` Durrant, Paul 2019-12-09 14:23 ` Durrant, Paul 2019-12-09 14:41 ` Jürgen Groß 2019-12-09 14:41 ` Jürgen Groß 2019-12-09 14:43 ` Durrant, Paul 2019-12-09 14:43 ` Durrant, Paul 2019-12-09 12:01 ` Durrant, Paul 2019-12-09 12:01 ` Durrant, Paul 2019-12-09 12:25 ` Roger Pau Monné 2019-12-09 12:25 ` Roger Pau Monné 2019-12-09 12:40 ` Durrant, Paul 2019-12-09 12:40 ` Durrant, Paul 2019-12-09 14:28 ` Roger Pau Monné 2019-12-09 14:28 ` Roger Pau Monné 2019-12-09 14:41 ` Durrant, Paul 2019-12-09 14:41 ` Durrant, Paul 2019-12-09 15:13 ` Roger Pau Monné 2019-12-09 15:13 ` Roger Pau Monné 2019-12-09 16:26 ` Durrant, Paul 2019-12-09 16:26 ` Durrant, Paul 2019-12-09 17:17 ` Roger Pau Monné 2019-12-09 17:17 ` Roger Pau Monné 2019-12-09 17:23 ` Durrant, Paul 2019-12-09 17:23 ` Durrant, Paul 2019-12-05 14:01 ` [PATCH 3/4] xen/interface: don't discard pending work in FRONT/BACK_RING_ATTACH Paul Durrant 2019-12-05 14:01 ` [Xen-devel] " Paul Durrant 2019-12-09 11:41 ` Roger Pau Monné 2019-12-09 11:41 ` Roger Pau Monné 2019-12-09 11:52 ` Jürgen Groß 2019-12-09 11:52 ` Jürgen Groß 2019-12-09 12:50 ` Durrant, Paul 2019-12-09 12:50 ` Durrant, Paul 2019-12-09 13:55 ` Jürgen Groß 2019-12-09 13:55 ` [Xen-devel] " Jürgen Groß 2019-12-09 16:38 ` Durrant, Paul 2019-12-09 16:38 ` [Xen-devel] " Durrant, Paul 2019-12-10 11:42 ` Jürgen Groß 2019-12-10 11:42 ` [Xen-devel] " Jürgen Groß 2019-12-05 14:01 ` [PATCH 4/4] xen-blkback: support dynamic unbind/bind Paul Durrant 2019-12-05 14:01 ` [Xen-devel] " Paul Durrant 2019-12-09 12:17 ` Roger Pau Monné 2019-12-09 12:17 ` [Xen-devel] " Roger Pau Monné 2019-12-09 12:24 ` Durrant, Paul 2019-12-09 12:24 ` [Xen-devel] " Durrant, Paul 2019-12-09 13:57 ` Jürgen Groß 2019-12-09 13:57 ` [Xen-devel] " Jürgen Groß 2019-12-09 14:01 ` Durrant, Paul [this message] 2019-12-09 14:01 ` Durrant, Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=158cb2845bec457fa54c6dfbd5a9efac@EX13D32EUC003.ant.amazon.com \ --to=pdurrant@amazon.com \ --cc=axboe@kernel.dk \ --cc=boris.ostrovsky@oracle.com \ --cc=jgross@suse.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=roger.pau@citrix.com \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.