Re: [PATCH 12/14] clk: sparx5: Add Sparx5 SoC DPLL clock driver

From: Stephen Boyd <sboyd@kernel.org>
To: Lars Povlsen <lars.povlsen@microchip.com>
Cc: devicetree@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Michael Turquette <mturquette@baylibre.com>,
	SoC Team <soc@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Olof Johansson <olof@lixom.net>,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	Lars Povlsen <lars.povlsen@microchip.com>
Subject: Re: [PATCH 12/14] clk: sparx5: Add Sparx5 SoC DPLL clock driver
Date: Wed, 27 May 2020 12:08:11 -0700	[thread overview]
Message-ID: <159060649156.88029.3527344402878672794@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <87mu5tpi2q.fsf@soft-dev15.microsemi.net>

Quoting Lars Povlsen (2020-05-27 07:29:17)
> 
> Stephen Boyd writes:
> 
> > Quoting Lars Povlsen (2020-05-13 05:55:30)
> >> diff --git a/drivers/clk/clk-sparx5.c b/drivers/clk/clk-sparx5.c
> >> new file mode 100644
> 
> >> +}
> >> +
> >> +static struct clk_hw *s5_clk_hw_get(struct of_phandle_args *clkspec, void *data)
> >> +{
> >> +       struct s5_clk_data *pll_clk = data;
> >> +       unsigned int idx = clkspec->args[0];
> >> +
> >> +       if (idx >= N_CLOCKS) {
> >> +               pr_err("%s: invalid index %u\n", __func__, idx);
> >> +               return ERR_PTR(-EINVAL);
> >> +       }
> >> +
> >> +       return &pll_clk->s5_hw[idx].hw;
> >> +}
> >> +
> >> +static void __init s5_pll_init(struct device_node *np)
> >> +{
> >> +       int i, ret;
> >> +       struct s5_clk_data *pll_clk;
> >> +       struct clk_init_data init = { 0 };
> >
> > Just do init = { } so that 0 doesn't trip up sparse.
> 
> I'm not sure what you mean by "trip up sparse", but its changed now.
> 

For example, sparse complains if the first struct member is a pointer
and an integer is assigned to it.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel