From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Hans de Goede" <hdegoede@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
Date: Sun, 07 Jun 2020 18:28:13 -0000 [thread overview]
Message-ID: <159155449374.15986.5218940914735022313@emeril.freedesktop.org> (raw)
In-Reply-To: <20200607181840.13536-1-hdegoede@redhat.com>
== Series Details ==
Series: pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
URL : https://patchwork.freedesktop.org/series/78089/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e5cf553c0dcc ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase
e4c217421240 ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation)
50130652086f pwm: lpss: Add range limit check for the base_unit register value
cb9922913f55 pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()
dba8a9e355db pwm: lpss: Set SW_UPDATE bit when enabling the PWM
-:78: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#78: FILE: drivers/pwm/pwm-lpss.c:149:
+ lpwm->info->bypass == false);
total: 0 errors, 0 warnings, 1 checks, 36 lines checked
84fd73d0b37e pwm: crc: Fix period / duty_cycle times being off by a factor of 256
9e2eaeacdf15 pwm: crc: Fix off-by-one error in the clock-divider calculations
8b1bbb8e9bc0 pwm: crc: Fix period changes not having any effect
a08d7c7752b8 pwm: crc: Enable/disable PWM output on enable/disable
989f50988bff pwm: crc: Implement apply() method to support the new atomic PWM API
2c6d747e89fe pwm: crc: Implement get_state() method
-:20: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#20: FILE: drivers/pwm/pwm-crc.c:118:
+static void crc_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
+ struct pwm_state *state)
total: 0 errors, 0 warnings, 1 checks, 37 lines checked
13ddb5bbc283 drm/i915: panel: Add get_vbt_pwm_freq() helper
a5b8e319f197 drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller
61594a403a5c drm/i915: panel: Honor the VBT PWM min setting for devs with an external PWM controller
dc3969b82041 drm/i915: panel: Use atomic PWM API for devs with an external PWM controller
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-07 18:28 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 18:18 [PATCH v2 00/15] pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 01/15] ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 02/15] ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation) Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 03/15] pwm: lpss: Add range limit check for the base_unit register value Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-08 3:50 ` Andy Shevchenko
2020-06-08 3:50 ` [Intel-gfx] " Andy Shevchenko
2020-06-08 3:50 ` Andy Shevchenko
2020-06-08 11:07 ` Hans de Goede
2020-06-08 11:07 ` [Intel-gfx] " Hans de Goede
2020-06-08 11:07 ` Hans de Goede
2020-06-08 12:51 ` Andy Shevchenko
2020-06-08 12:51 ` [Intel-gfx] " Andy Shevchenko
2020-06-08 12:51 ` Andy Shevchenko
2020-06-08 12:51 ` Andy Shevchenko
2020-06-08 14:19 ` Hans de Goede
2020-06-08 14:19 ` [Intel-gfx] " Hans de Goede
2020-06-08 14:19 ` Hans de Goede
2020-06-11 22:12 ` Uwe Kleine-König
2020-06-11 22:12 ` [Intel-gfx] " Uwe Kleine-König
2020-06-11 22:12 ` Uwe Kleine-König
2020-06-12 11:57 ` Andy Shevchenko
2020-06-12 11:57 ` [Intel-gfx] " Andy Shevchenko
2020-06-12 11:57 ` Andy Shevchenko
2020-06-13 20:50 ` Uwe Kleine-König
2020-06-13 20:50 ` [Intel-gfx] " Uwe Kleine-König
2020-06-13 20:50 ` Uwe Kleine-König
2020-06-07 18:18 ` [PATCH v2 04/15] pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare() Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-08 3:55 ` Andy Shevchenko
2020-06-08 3:55 ` [Intel-gfx] " Andy Shevchenko
2020-06-08 3:55 ` Andy Shevchenko
2020-06-08 11:13 ` Hans de Goede
2020-06-08 11:13 ` [Intel-gfx] " Hans de Goede
2020-06-08 11:13 ` Hans de Goede
2020-06-08 11:13 ` Hans de Goede
2020-06-08 12:55 ` Andy Shevchenko
2020-06-08 12:55 ` [Intel-gfx] " Andy Shevchenko
2020-06-08 12:55 ` Andy Shevchenko
2020-06-07 18:18 ` [PATCH v2 05/15] pwm: lpss: Set SW_UPDATE bit when enabling the PWM Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 06/15] pwm: crc: Fix period / duty_cycle times being off by a factor of 256 Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-09 11:29 ` Andy Shevchenko
2020-06-09 11:29 ` [Intel-gfx] " Andy Shevchenko
2020-06-09 11:29 ` Andy Shevchenko
2020-06-09 13:45 ` Hans de Goede
2020-06-09 13:45 ` [Intel-gfx] " Hans de Goede
2020-06-09 13:45 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 07/15] pwm: crc: Fix off-by-one error in the clock-divider calculations Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 08/15] pwm: crc: Fix period changes not having any effect Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 09/15] pwm: crc: Enable/disable PWM output on enable/disable Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-09 11:31 ` Andy Shevchenko
2020-06-09 11:31 ` [Intel-gfx] " Andy Shevchenko
2020-06-09 11:31 ` Andy Shevchenko
2020-06-11 22:20 ` Uwe Kleine-König
2020-06-11 22:20 ` [Intel-gfx] " Uwe Kleine-König
2020-06-11 22:20 ` Uwe Kleine-König
2020-06-12 16:59 ` Hans de Goede
2020-06-12 16:59 ` [Intel-gfx] " Hans de Goede
2020-06-12 16:59 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 10/15] pwm: crc: Implement apply() method to support the new atomic PWM API Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-09 11:32 ` Andy Shevchenko
2020-06-09 11:32 ` [Intel-gfx] " Andy Shevchenko
2020-06-09 11:32 ` Andy Shevchenko
2020-06-09 13:44 ` Hans de Goede
2020-06-09 13:44 ` [Intel-gfx] " Hans de Goede
2020-06-09 13:44 ` Hans de Goede
2020-06-09 13:50 ` Andy Shevchenko
2020-06-09 13:50 ` [Intel-gfx] " Andy Shevchenko
2020-06-09 13:50 ` Andy Shevchenko
2020-06-07 18:18 ` [PATCH v2 11/15] pwm: crc: Implement get_state() method Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-09 11:32 ` Andy Shevchenko
2020-06-09 11:32 ` [Intel-gfx] " Andy Shevchenko
2020-06-09 11:32 ` Andy Shevchenko
2020-06-11 21:37 ` Uwe Kleine-König
2020-06-11 21:37 ` [Intel-gfx] " Uwe Kleine-König
2020-06-11 21:37 ` Uwe Kleine-König
2020-06-12 17:00 ` Hans de Goede
2020-06-12 17:00 ` [Intel-gfx] " Hans de Goede
2020-06-12 17:00 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 12/15] drm/i915: panel: Add get_vbt_pwm_freq() helper Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 13/15] drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 14/15] drm/i915: panel: Honor the VBT PWM min setting " Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:18 ` [PATCH v2 15/15] drm/i915: panel: Use atomic PWM API " Hans de Goede
2020-06-07 18:18 ` [Intel-gfx] " Hans de Goede
2020-06-07 18:18 ` Hans de Goede
2020-06-07 18:28 ` Patchwork [this message]
2020-06-07 18:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API Patchwork
2020-06-07 19:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159155449374.15986.5218940914735022313@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.