From: Will Deacon <will@kernel.org>
To: mark.rutland@arm.com, Qi Liu <liuqi115@huawei.com>,
zhangshaokun@hisilicon.com, john.garry@huawei.com
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers/perf: Prevent forced unbinding of PMU drivers
Date: Fri, 17 Jul 2020 11:43:42 +0100 [thread overview]
Message-ID: <159497953657.530785.13608435502860855695.b4-ty@kernel.org> (raw)
In-Reply-To: <1594975763-32966-1-git-send-email-liuqi115@huawei.com>
On Fri, 17 Jul 2020 16:49:23 +0800, Qi Liu wrote:
> Forcefully unbinding PMU drivers during perf sampling will lead to
> a kernel panic, because the perf upper-layer framework call a NULL
> pointer in this situation.
>
> To solve this issue, "suppress_bind_attrs" should be set to true, so
> that bind/unbind can be disabled via sysfs and prevent unbinding PMU
> drivers during perf sampling.
Applied to arm64 (for-next/fixes), thanks!
[1/1] drivers/perf: Prevent forced unbinding of PMU drivers
https://git.kernel.org/arm64/c/f32ed8eb0e3f
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: mark.rutland@arm.com, Qi Liu <liuqi115@huawei.com>,
zhangshaokun@hisilicon.com, john.garry@huawei.com
Cc: Will Deacon <will@kernel.org>,
catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, kernel-team@android.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers/perf: Prevent forced unbinding of PMU drivers
Date: Fri, 17 Jul 2020 11:43:42 +0100 [thread overview]
Message-ID: <159497953657.530785.13608435502860855695.b4-ty@kernel.org> (raw)
In-Reply-To: <1594975763-32966-1-git-send-email-liuqi115@huawei.com>
On Fri, 17 Jul 2020 16:49:23 +0800, Qi Liu wrote:
> Forcefully unbinding PMU drivers during perf sampling will lead to
> a kernel panic, because the perf upper-layer framework call a NULL
> pointer in this situation.
>
> To solve this issue, "suppress_bind_attrs" should be set to true, so
> that bind/unbind can be disabled via sysfs and prevent unbinding PMU
> drivers during perf sampling.
Applied to arm64 (for-next/fixes), thanks!
[1/1] drivers/perf: Prevent forced unbinding of PMU drivers
https://git.kernel.org/arm64/c/f32ed8eb0e3f
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-17 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 8:49 [PATCH] drivers/perf: Prevent forced unbinding of PMU drivers Qi Liu
2020-07-17 8:49 ` Qi Liu
2020-07-17 10:43 ` Will Deacon [this message]
2020-07-17 10:43 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159497953657.530785.13608435502860855695.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=john.garry@huawei.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi115@huawei.com \
--cc=mark.rutland@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.