All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Stephen Boyd <swboyd@chromium.org>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Subject: Re: [v3 PATCH] usb: gadget: bdc: use readl_poll_timeout() to simplify code
Date: Wed, 22 Jul 2020 14:51:20 +0800	[thread overview]
Message-ID: <1595400680.23885.59.camel@mhfsdcap03> (raw)
In-Reply-To: <87eep5p5jz.fsf@kernel.org>

On Tue, 2020-07-21 at 12:42 +0300, Felipe Balbi wrote:
> Hi,
> 
> Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> > Use readl_poll_timeout() to poll register status
> >
> > Cc: Florian Fainelli <f.fainelli@gmail.com>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> I had a lot of trouble to apply this patch, could you avoid base64
> encoding on the patch body next time?
Sorry for inconvenience.


I usually use Source Insight 3.5 or Vim to edit the code, sometimes use
Beyond Compare to compare patches, their default encoding is UTF-8 or
ANSI. Not sure which tool would use base64 encoding, maybe introduced
when I copy email address from Win7 with Chinese (used to receive email)
into Win10 with English (used to sent email/patch). 


Can you tell me which lines are base64 encoding in this patch?


The patch's encoding is ANSI, I'll convert it into UTF-8 and resend it,
please try it again.

> 
> Thanks
> 


WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
	linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [v3 PATCH] usb: gadget: bdc: use readl_poll_timeout() to simplify code
Date: Wed, 22 Jul 2020 14:51:20 +0800	[thread overview]
Message-ID: <1595400680.23885.59.camel@mhfsdcap03> (raw)
In-Reply-To: <87eep5p5jz.fsf@kernel.org>

On Tue, 2020-07-21 at 12:42 +0300, Felipe Balbi wrote:
> Hi,
> 
> Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> > Use readl_poll_timeout() to poll register status
> >
> > Cc: Florian Fainelli <f.fainelli@gmail.com>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> I had a lot of trouble to apply this patch, could you avoid base64
> encoding on the patch body next time?
Sorry for inconvenience.


I usually use Source Insight 3.5 or Vim to edit the code, sometimes use
Beyond Compare to compare patches, their default encoding is UTF-8 or
ANSI. Not sure which tool would use base64 encoding, maybe introduced
when I copy email address from Win7 with Chinese (used to receive email)
into Win10 with English (used to sent email/patch). 


Can you tell me which lines are base64 encoding in this patch?


The patch's encoding is ANSI, I'll convert it into UTF-8 and resend it,
please try it again.

> 
> Thanks
> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
	linux-kernel@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [v3 PATCH] usb: gadget: bdc: use readl_poll_timeout() to simplify code
Date: Wed, 22 Jul 2020 14:51:20 +0800	[thread overview]
Message-ID: <1595400680.23885.59.camel@mhfsdcap03> (raw)
In-Reply-To: <87eep5p5jz.fsf@kernel.org>

On Tue, 2020-07-21 at 12:42 +0300, Felipe Balbi wrote:
> Hi,
> 
> Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> > Use readl_poll_timeout() to poll register status
> >
> > Cc: Florian Fainelli <f.fainelli@gmail.com>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> I had a lot of trouble to apply this patch, could you avoid base64
> encoding on the patch body next time?
Sorry for inconvenience.


I usually use Source Insight 3.5 or Vim to edit the code, sometimes use
Beyond Compare to compare patches, their default encoding is UTF-8 or
ANSI. Not sure which tool would use base64 encoding, maybe introduced
when I copy email address from Win7 with Chinese (used to receive email)
into Win10 with English (used to sent email/patch). 


Can you tell me which lines are base64 encoding in this patch?


The patch's encoding is ANSI, I'll convert it into UTF-8 and resend it,
please try it again.

> 
> Thanks
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-22  6:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13  6:48 [v3 PATCH] usb: gadget: bdc: use readl_poll_timeout() to simplify code Chunfeng Yun
2020-07-13  6:48 ` Chunfeng Yun
2020-07-13  6:48 ` Chunfeng Yun
2020-07-16  1:06 ` Stephen Boyd
2020-07-16  1:06   ` Stephen Boyd
2020-07-16  1:06   ` Stephen Boyd
2020-07-21  9:42 ` Felipe Balbi
2020-07-21  9:42   ` Felipe Balbi
2020-07-21  9:42   ` Felipe Balbi
2020-07-22  6:51   ` Chunfeng Yun [this message]
2020-07-22  6:51     ` Chunfeng Yun
2020-07-22  6:51     ` Chunfeng Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1595400680.23885.59.camel@mhfsdcap03 \
    --to=chunfeng.yun@mediatek.com \
    --cc=balbi@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=swboyd@chromium.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.