All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hanks Chen <hanks.chen@mediatek.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <maz@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	<kernel-team@android.com>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-arm-msm@vger.kernel.org>,
	"John Stultz" <john.stultz@linaro.org>,
	CC Hwang <cc.hwang@mediatek.com>,
	"Loda Chou" <loda.chou@mediatek.com>
Subject: Re: [PATCH v3 4/4] irqchip/mtk-cirq: Convert to a platform driver
Date: Thu, 23 Jul 2020 19:46:03 +0800	[thread overview]
Message-ID: <1595504763.31289.5.camel@mtkswgap22> (raw)
In-Reply-To: <20200718000637.3632841-5-saravanak@google.com>

On Fri, 2020-07-17 at 17:06 -0700, Saravana Kannan wrote:
> This driver can work as a platform driver. So covert it to a platform
> driver.
> 
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
>  drivers/irqchip/irq-mtk-cirq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c
> index 69ba8ce3c178..62a61275aaa3 100644
> --- a/drivers/irqchip/irq-mtk-cirq.c
> +++ b/drivers/irqchip/irq-mtk-cirq.c
> @@ -295,4 +295,6 @@ static int __init mtk_cirq_of_init(struct device_node *node,
>  	return ret;
>  }
>  
> -IRQCHIP_DECLARE(mtk_cirq, "mediatek,mtk-cirq", mtk_cirq_of_init);
> +IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_cirq)
> +IRQCHIP_MATCH("mediatek,mtk-cirq", mtk_cirq_of_init)
> +IRQCHIP_PLATFORM_DRIVER_END(mtk_cirq)

Hi Saravana,

Looks good for me to convert cirq to a platform.
Thank you for your patch.

Reviewed-by: Hanks Chen <hanks.chen@mediatek.com>

Hanks Chen

WARNING: multiple messages have this Message-ID (diff)
From: Hanks Chen <hanks.chen@mediatek.com>
To: Saravana Kannan <saravanak@google.com>
Cc: CC Hwang <cc.hwang@mediatek.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <maz@kernel.org>, Loda Chou <loda.chou@mediatek.com>,
	linux-kernel@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	kernel-team@android.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] irqchip/mtk-cirq: Convert to a platform driver
Date: Thu, 23 Jul 2020 19:46:03 +0800	[thread overview]
Message-ID: <1595504763.31289.5.camel@mtkswgap22> (raw)
In-Reply-To: <20200718000637.3632841-5-saravanak@google.com>

On Fri, 2020-07-17 at 17:06 -0700, Saravana Kannan wrote:
> This driver can work as a platform driver. So covert it to a platform
> driver.
> 
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
>  drivers/irqchip/irq-mtk-cirq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c
> index 69ba8ce3c178..62a61275aaa3 100644
> --- a/drivers/irqchip/irq-mtk-cirq.c
> +++ b/drivers/irqchip/irq-mtk-cirq.c
> @@ -295,4 +295,6 @@ static int __init mtk_cirq_of_init(struct device_node *node,
>  	return ret;
>  }
>  
> -IRQCHIP_DECLARE(mtk_cirq, "mediatek,mtk-cirq", mtk_cirq_of_init);
> +IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_cirq)
> +IRQCHIP_MATCH("mediatek,mtk-cirq", mtk_cirq_of_init)
> +IRQCHIP_PLATFORM_DRIVER_END(mtk_cirq)

Hi Saravana,

Looks good for me to convert cirq to a platform.
Thank you for your patch.

Reviewed-by: Hanks Chen <hanks.chen@mediatek.com>

Hanks Chen
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Hanks Chen <hanks.chen@mediatek.com>
To: Saravana Kannan <saravanak@google.com>
Cc: CC Hwang <cc.hwang@mediatek.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <maz@kernel.org>, Loda Chou <loda.chou@mediatek.com>,
	linux-kernel@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	kernel-team@android.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] irqchip/mtk-cirq: Convert to a platform driver
Date: Thu, 23 Jul 2020 19:46:03 +0800	[thread overview]
Message-ID: <1595504763.31289.5.camel@mtkswgap22> (raw)
In-Reply-To: <20200718000637.3632841-5-saravanak@google.com>

On Fri, 2020-07-17 at 17:06 -0700, Saravana Kannan wrote:
> This driver can work as a platform driver. So covert it to a platform
> driver.
> 
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
>  drivers/irqchip/irq-mtk-cirq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c
> index 69ba8ce3c178..62a61275aaa3 100644
> --- a/drivers/irqchip/irq-mtk-cirq.c
> +++ b/drivers/irqchip/irq-mtk-cirq.c
> @@ -295,4 +295,6 @@ static int __init mtk_cirq_of_init(struct device_node *node,
>  	return ret;
>  }
>  
> -IRQCHIP_DECLARE(mtk_cirq, "mediatek,mtk-cirq", mtk_cirq_of_init);
> +IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_cirq)
> +IRQCHIP_MATCH("mediatek,mtk-cirq", mtk_cirq_of_init)
> +IRQCHIP_PLATFORM_DRIVER_END(mtk_cirq)

Hi Saravana,

Looks good for me to convert cirq to a platform.
Thank you for your patch.

Reviewed-by: Hanks Chen <hanks.chen@mediatek.com>

Hanks Chen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-23 11:46 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18  0:06 [PATCH v3 0/4] irqchip: Add IRQCHIP_PLATFORM_DRIVER helper macros Saravana Kannan
2020-07-18  0:06 ` Saravana Kannan
2020-07-18  0:06 ` Saravana Kannan
2020-07-18  0:06 ` [PATCH v3 1/4] irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END and IRQCHIP_MATCH " Saravana Kannan
2020-07-18  0:06   ` Saravana Kannan
2020-07-18  0:06   ` Saravana Kannan
2020-07-18  0:06 ` [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER " Saravana Kannan
2020-07-18  0:06   ` Saravana Kannan
2020-07-18  0:06   ` Saravana Kannan
2020-08-05  7:44   ` John Stultz
2020-08-05  7:44     ` John Stultz
2020-08-05  7:44     ` John Stultz
2020-08-05 20:19     ` Saravana Kannan
2020-08-05 20:19       ` Saravana Kannan
2020-08-05 20:19       ` Saravana Kannan
2020-08-05 21:16       ` Steev Klimaszewski
2020-08-05 21:16         ` Steev Klimaszewski
2020-08-05 21:16         ` Steev Klimaszewski
2020-08-05 21:47         ` Steev Klimaszewski
2020-08-05 21:47           ` Steev Klimaszewski
2020-08-05 21:47           ` Steev Klimaszewski
2020-08-05 21:57           ` John Stultz
2020-08-05 21:57             ` John Stultz
2020-08-05 21:57             ` John Stultz
2020-08-07  0:40             ` Bjorn Andersson
2020-08-07  0:40               ` Bjorn Andersson
2020-08-07  0:40               ` Bjorn Andersson
2020-08-07  1:22               ` John Stultz
2020-08-07  1:22                 ` John Stultz
2020-08-07  1:22                 ` John Stultz
2020-08-07  1:39                 ` Bjorn Andersson
2020-08-07  1:39                   ` Bjorn Andersson
2020-08-07  1:39                   ` Bjorn Andersson
2020-08-07  2:48                   ` John Stultz
2020-08-07  2:48                     ` John Stultz
2020-08-07  2:48                     ` John Stultz
2020-08-07  3:02                     ` Saravana Kannan
2020-08-07  3:02                       ` Saravana Kannan
2020-08-07  3:02                       ` Saravana Kannan
2020-08-07  3:09                       ` John Stultz
2020-08-07  3:09                         ` John Stultz
2020-08-07  3:09                         ` John Stultz
2020-08-07  3:12                         ` Saravana Kannan
2020-08-07  3:12                           ` Saravana Kannan
2020-08-07  3:12                           ` Saravana Kannan
2020-08-07  5:58                     ` Bjorn Andersson
2020-08-07  5:58                       ` Bjorn Andersson
2020-08-07  5:58                       ` Bjorn Andersson
2020-08-07  6:22                       ` Saravana Kannan
2020-08-07  6:22                         ` Saravana Kannan
2020-08-07  6:22                         ` Saravana Kannan
2020-08-06  1:24       ` John Stultz
2020-08-06  1:24         ` John Stultz
2020-08-06  1:24         ` John Stultz
2020-08-06  8:49         ` Marc Zyngier
2020-08-06  8:49           ` Marc Zyngier
2020-08-06  8:49           ` Marc Zyngier
2020-08-06 18:05           ` Saravana Kannan
2020-08-06 18:05             ` Saravana Kannan
2020-08-06 18:05             ` Saravana Kannan
2020-08-06 19:59             ` Marc Zyngier
2020-08-06 19:59               ` Marc Zyngier
2020-08-06 19:59               ` Marc Zyngier
2020-08-06 20:09               ` John Stultz
2020-08-06 20:09                 ` John Stultz
2020-08-06 20:09                 ` John Stultz
2020-08-06 20:31                 ` Marc Zyngier
2020-08-06 20:31                   ` Marc Zyngier
2020-08-06 20:31                   ` Marc Zyngier
2020-08-06 21:16                   ` Saravana Kannan
2020-08-06 21:16                     ` Saravana Kannan
2020-08-06 21:16                     ` Saravana Kannan
2020-07-18  0:06 ` [PATCH v3 3/4] irqchip/mtk-sysirq: Convert to a platform driver Saravana Kannan
2020-07-18  0:06   ` Saravana Kannan
2020-07-18  0:06   ` Saravana Kannan
2020-07-23 11:42   ` Hanks Chen
2020-07-23 11:42     ` Hanks Chen
2020-07-23 11:42     ` Hanks Chen
2020-07-18  0:06 ` [PATCH v3 4/4] irqchip/mtk-cirq: " Saravana Kannan
2020-07-18  0:06   ` Saravana Kannan
2020-07-18  0:06   ` Saravana Kannan
2020-07-23 11:46   ` Hanks Chen [this message]
2020-07-23 11:46     ` Hanks Chen
2020-07-23 11:46     ` Hanks Chen
2020-07-23 17:37     ` Saravana Kannan
2020-07-23 17:37       ` Saravana Kannan
2020-07-23 17:37       ` Saravana Kannan
2020-07-25 14:23 ` [PATCH v3 0/4] irqchip: Add IRQCHIP_PLATFORM_DRIVER helper macros Marc Zyngier
2020-07-25 14:23   ` Marc Zyngier
2020-07-25 14:23   ` Marc Zyngier
2020-07-26  3:58   ` Saravana Kannan
2020-07-26  3:58     ` Saravana Kannan
2020-07-26  3:58     ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1595504763.31289.5.camel@mtkswgap22 \
    --to=hanks.chen@mediatek.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cc.hwang@mediatek.com \
    --cc=jason@lakedaemon.net \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=loda.chou@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=maz@kernel.org \
    --cc=saravanak@google.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.