From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Eddie Hung <eddie.hung@mediatek.com>
Subject: [PATCH 08/11] usb: mtu3: remove useless member @busy in mtu3_ep struct
Date: Mon, 27 Jul 2020 15:14:57 +0800 [thread overview]
Message-ID: <1595834101-13094-8-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1595834101-13094-1-git-send-email-chunfeng.yun@mediatek.com>
The member @busy in mtu3_ep struct is unnecessary, so remove it.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/mtu3/mtu3.h | 1 -
drivers/usb/mtu3/mtu3_gadget.c | 6 ------
2 files changed, 7 deletions(-)
diff --git a/drivers/usb/mtu3/mtu3.h b/drivers/usb/mtu3/mtu3.h
index 9d68f25..8fd83bd 100644
--- a/drivers/usb/mtu3/mtu3.h
+++ b/drivers/usb/mtu3/mtu3.h
@@ -294,7 +294,6 @@ struct mtu3_ep {
int flags;
u8 wedged;
- u8 busy;
};
struct mtu3_request {
diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c
index 2bc9a95..ef9fcd5 100644
--- a/drivers/usb/mtu3/mtu3_gadget.c
+++ b/drivers/usb/mtu3/mtu3_gadget.c
@@ -17,7 +17,6 @@ void mtu3_req_complete(struct mtu3_ep *mep,
{
struct mtu3_request *mreq;
struct mtu3 *mtu;
- int busy = mep->busy;
mreq = to_mtu3_request(req);
list_del(&mreq->list);
@@ -25,8 +24,6 @@ void mtu3_req_complete(struct mtu3_ep *mep,
mreq->request.status = status;
mtu = mreq->mtu;
- mep->busy = 1;
-
trace_mtu3_req_complete(mreq);
spin_unlock(&mtu->lock);
@@ -40,14 +37,12 @@ void mtu3_req_complete(struct mtu3_ep *mep,
usb_gadget_giveback_request(&mep->ep, &mreq->request);
spin_lock(&mtu->lock);
- mep->busy = busy;
}
static void nuke(struct mtu3_ep *mep, const int status)
{
struct mtu3_request *mreq = NULL;
- mep->busy = 1;
if (list_empty(&mep->req_list))
return;
@@ -195,7 +190,6 @@ static int mtu3_gadget_ep_enable(struct usb_ep *ep,
if (ret)
goto error;
- mep->busy = 0;
mep->wedged = 0;
mep->flags |= MTU3_EP_ENABLED;
mtu->active_ep++;
--
1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Eddie Hung <eddie.hung@mediatek.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/11] usb: mtu3: remove useless member @busy in mtu3_ep struct
Date: Mon, 27 Jul 2020 15:14:57 +0800 [thread overview]
Message-ID: <1595834101-13094-8-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1595834101-13094-1-git-send-email-chunfeng.yun@mediatek.com>
The member @busy in mtu3_ep struct is unnecessary, so remove it.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/mtu3/mtu3.h | 1 -
drivers/usb/mtu3/mtu3_gadget.c | 6 ------
2 files changed, 7 deletions(-)
diff --git a/drivers/usb/mtu3/mtu3.h b/drivers/usb/mtu3/mtu3.h
index 9d68f25..8fd83bd 100644
--- a/drivers/usb/mtu3/mtu3.h
+++ b/drivers/usb/mtu3/mtu3.h
@@ -294,7 +294,6 @@ struct mtu3_ep {
int flags;
u8 wedged;
- u8 busy;
};
struct mtu3_request {
diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c
index 2bc9a95..ef9fcd5 100644
--- a/drivers/usb/mtu3/mtu3_gadget.c
+++ b/drivers/usb/mtu3/mtu3_gadget.c
@@ -17,7 +17,6 @@ void mtu3_req_complete(struct mtu3_ep *mep,
{
struct mtu3_request *mreq;
struct mtu3 *mtu;
- int busy = mep->busy;
mreq = to_mtu3_request(req);
list_del(&mreq->list);
@@ -25,8 +24,6 @@ void mtu3_req_complete(struct mtu3_ep *mep,
mreq->request.status = status;
mtu = mreq->mtu;
- mep->busy = 1;
-
trace_mtu3_req_complete(mreq);
spin_unlock(&mtu->lock);
@@ -40,14 +37,12 @@ void mtu3_req_complete(struct mtu3_ep *mep,
usb_gadget_giveback_request(&mep->ep, &mreq->request);
spin_lock(&mtu->lock);
- mep->busy = busy;
}
static void nuke(struct mtu3_ep *mep, const int status)
{
struct mtu3_request *mreq = NULL;
- mep->busy = 1;
if (list_empty(&mep->req_list))
return;
@@ -195,7 +190,6 @@ static int mtu3_gadget_ep_enable(struct usb_ep *ep,
if (ret)
goto error;
- mep->busy = 0;
mep->wedged = 0;
mep->flags |= MTU3_EP_ENABLED;
mtu->active_ep++;
--
1.9.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Eddie Hung <eddie.hung@mediatek.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/11] usb: mtu3: remove useless member @busy in mtu3_ep struct
Date: Mon, 27 Jul 2020 15:14:57 +0800 [thread overview]
Message-ID: <1595834101-13094-8-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1595834101-13094-1-git-send-email-chunfeng.yun@mediatek.com>
The member @busy in mtu3_ep struct is unnecessary, so remove it.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/mtu3/mtu3.h | 1 -
drivers/usb/mtu3/mtu3_gadget.c | 6 ------
2 files changed, 7 deletions(-)
diff --git a/drivers/usb/mtu3/mtu3.h b/drivers/usb/mtu3/mtu3.h
index 9d68f25..8fd83bd 100644
--- a/drivers/usb/mtu3/mtu3.h
+++ b/drivers/usb/mtu3/mtu3.h
@@ -294,7 +294,6 @@ struct mtu3_ep {
int flags;
u8 wedged;
- u8 busy;
};
struct mtu3_request {
diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c
index 2bc9a95..ef9fcd5 100644
--- a/drivers/usb/mtu3/mtu3_gadget.c
+++ b/drivers/usb/mtu3/mtu3_gadget.c
@@ -17,7 +17,6 @@ void mtu3_req_complete(struct mtu3_ep *mep,
{
struct mtu3_request *mreq;
struct mtu3 *mtu;
- int busy = mep->busy;
mreq = to_mtu3_request(req);
list_del(&mreq->list);
@@ -25,8 +24,6 @@ void mtu3_req_complete(struct mtu3_ep *mep,
mreq->request.status = status;
mtu = mreq->mtu;
- mep->busy = 1;
-
trace_mtu3_req_complete(mreq);
spin_unlock(&mtu->lock);
@@ -40,14 +37,12 @@ void mtu3_req_complete(struct mtu3_ep *mep,
usb_gadget_giveback_request(&mep->ep, &mreq->request);
spin_lock(&mtu->lock);
- mep->busy = busy;
}
static void nuke(struct mtu3_ep *mep, const int status)
{
struct mtu3_request *mreq = NULL;
- mep->busy = 1;
if (list_empty(&mep->req_list))
return;
@@ -195,7 +190,6 @@ static int mtu3_gadget_ep_enable(struct usb_ep *ep,
if (ret)
goto error;
- mep->busy = 0;
mep->wedged = 0;
mep->flags |= MTU3_EP_ENABLED;
mtu->active_ep++;
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-27 7:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 7:14 [PATCH 01/11] usb: mtu3: remove unnecessary pointer checks Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` [PATCH 02/11] usb: mtu3: fix macro for maximum number of packets Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` [PATCH 03/11] usb: mtu3: reinitialize CSR registers Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` [PATCH 04/11] usb: mtu3: clear interrupts status when disable interrupts Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` [PATCH 05/11] usb: mtu3: introduce a funtion to check maximum speed Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` [PATCH 06/11] usb: mtu3: add ->udc_set_speed() Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` [PATCH 07/11] usb: mtu3: remove repeated error log Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun [this message]
2020-07-27 7:14 ` [PATCH 08/11] usb: mtu3: remove useless member @busy in mtu3_ep struct Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` [PATCH 09/11] usb: mtu3: use MTU3_EP_WEDGE flag Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` [PATCH 10/11] usb: mtu3: clear dual mode of u3port when disable device Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 7:14 ` Chunfeng Yun
2020-07-27 8:07 ` Sergei Shtylyov
2020-07-27 8:07 ` Sergei Shtylyov
2020-07-27 8:07 ` Sergei Shtylyov
2020-07-28 6:05 ` Chunfeng Yun
2020-07-28 6:05 ` Chunfeng Yun
2020-07-28 6:05 ` Chunfeng Yun
2020-07-27 7:15 ` [PATCH 11/11] usb: mtu3: simplify mtu3_req_complete() Chunfeng Yun
2020-07-27 7:15 ` Chunfeng Yun
2020-07-27 7:15 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595834101-13094-8-git-send-email-chunfeng.yun@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=balbi@kernel.org \
--cc=eddie.hung@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.