[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Hans de Goede" <hdegoede@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
Date: Mon, 24 Aug 2020 12:28:30 -0000	[thread overview]
Message-ID: <159827211077.20778.4575869402766299068@emeril.freedesktop.org> (raw)
In-Reply-To: <20200824120126.7116-1-hdegoede@redhat.com>

== Series Details ==

Series: acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
URL   : https://patchwork.freedesktop.org/series/80943/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
23eeb608a11a ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase
3404311e82b8 ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation)
cc49add91e96 pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()
a9f8c291fa0f pwm: lpss: Add range limit check for the base_unit register value
a7c9b3968280 pwm: lpss: Add pwm_lpss_prepare_enable() helper
-:45: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#45: FILE: drivers/pwm/pwm-lpss.c:137:
+	pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == false);

-:50: CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#50: FILE: drivers/pwm/pwm-lpss.c:142:
+	pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == true);

total: 0 errors, 0 warnings, 2 checks, 67 lines checked
19fbcc493a46 pwm: lpss: Use pwm_lpss_apply() when restoring state on resume
23df6f9340c1 pwm: crc: Fix period / duty_cycle times being off by a factor of 256
a9c78de3ade3 pwm: crc: Fix off-by-one error in the clock-divider calculations
9d3242bf8a3e pwm: crc: Fix period changes not having any effect
8b8e82933140 pwm: crc: Enable/disable PWM output on enable/disable
6a44ff1498a2 pwm: crc: Implement apply() method to support the new atomic PWM API
c72a3592f7d9 pwm: crc: Implement get_state() method
1f8f97bf9b4a drm/i915: panel: Add get_vbt_pwm_freq() helper
c1026447b3e9 drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller
5e7767931e02 drm/i915: panel: Honor the VBT PWM min setting for devs with an external PWM controller
80c31f95dffd drm/i915: panel: Use atomic PWM API for devs with an external PWM controller


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx