From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Hans de Goede" <hdegoede@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
Date: Sun, 30 Aug 2020 13:25:57 -0000 [thread overview]
Message-ID: <159879395703.18690.13529871566286732857@emeril.freedesktop.org> (raw)
In-Reply-To: <20200830125753.230420-1-hdegoede@redhat.com>
== Series Details ==
Series: acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
URL : https://patchwork.freedesktop.org/series/81176/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
48148eeaab72 ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase
45a4de251846 ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation)
4f7f933a6af6 pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()
bea1f0a2539c pwm: lpss: Add range limit check for the base_unit register value
c14d8f448f41 pwm: lpss: Add pwm_lpss_prepare_enable() helper
-:45: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#45: FILE: drivers/pwm/pwm-lpss.c:137:
+ pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == false);
-:50: CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#50: FILE: drivers/pwm/pwm-lpss.c:142:
+ pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == true);
total: 0 errors, 0 warnings, 2 checks, 67 lines checked
4537cd716e11 pwm: lpss: Use pwm_lpss_restore() when restoring state on resume
a12337a38581 pwm: lpss: Always update state and set update bit
23074c82455a pwm: crc: Fix period / duty_cycle times being off by a factor of 256
d6a64ac9e222 pwm: crc: Fix off-by-one error in the clock-divider calculations
3eaa398d8d92 pwm: crc: Fix period changes not having any effect
605d467e4d8d pwm: crc: Enable/disable PWM output on enable/disable
8924b6bba39e pwm: crc: Implement apply() method to support the new atomic PWM API
32379b451d32 pwm: crc: Implement get_state() method
ada5a0b67cad drm/i915: panel: Add get_vbt_pwm_freq() helper
b09d3cbb410b drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller
823d349c8754 drm/i915: panel: Honor the VBT PWM min setting for devs with an external PWM controller
263c2d7f2378 drm/i915: panel: Use atomic PWM API for devs with an external PWM controller
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-08-30 13:25 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 12:57 [PATCH v8 00/17] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-30 12:57 ` [PATCH v8 01/17] ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-30 12:57 ` [PATCH v8 02/17] ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation) Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-30 12:57 ` [PATCH v8 03/17] pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare() Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:01 ` Thierry Reding
2020-08-31 11:01 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:01 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 04/17] pwm: lpss: Add range limit check for the base_unit register value Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:02 ` Thierry Reding
2020-08-31 11:02 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:02 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 05/17] pwm: lpss: Add pwm_lpss_prepare_enable() helper Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:03 ` Thierry Reding
2020-08-31 11:03 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:03 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:10 ` Thierry Reding
2020-08-31 11:10 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:10 ` Thierry Reding
2020-08-31 11:46 ` Hans de Goede
2020-08-31 11:46 ` [Intel-gfx] " Hans de Goede
2020-08-31 11:46 ` Hans de Goede
2020-08-31 13:15 ` Thierry Reding
2020-08-31 13:15 ` [Intel-gfx] " Thierry Reding
2020-08-31 13:15 ` Thierry Reding
2020-08-31 17:57 ` Hans de Goede
2020-08-31 17:57 ` [Intel-gfx] " Hans de Goede
2020-08-31 17:57 ` Hans de Goede
2020-09-01 8:09 ` Andy Shevchenko
2020-09-01 8:09 ` [Intel-gfx] " Andy Shevchenko
2020-09-01 8:09 ` Andy Shevchenko
2020-08-30 12:57 ` [PATCH v8 07/17] pwm: lpss: Always update state and set update bit Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 8:56 ` Andy Shevchenko
2020-08-31 8:56 ` [Intel-gfx] " Andy Shevchenko
2020-08-31 8:56 ` Andy Shevchenko
2020-08-31 11:50 ` Hans de Goede
2020-08-31 11:50 ` [Intel-gfx] " Hans de Goede
2020-08-31 11:50 ` Hans de Goede
2020-08-31 11:13 ` Thierry Reding
2020-08-31 11:13 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:13 ` Thierry Reding
2020-08-31 11:26 ` Hans de Goede
2020-08-31 11:26 ` [Intel-gfx] " Hans de Goede
2020-08-31 11:26 ` Hans de Goede
2020-08-31 13:31 ` Thierry Reding
2020-08-31 13:31 ` [Intel-gfx] " Thierry Reding
2020-08-31 13:31 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 08/17] pwm: crc: Fix period / duty_cycle times being off by a factor of 256 Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:13 ` Thierry Reding
2020-08-31 11:13 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:13 ` Thierry Reding
2020-08-31 11:14 ` Thierry Reding
2020-08-31 11:14 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:14 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 09/17] pwm: crc: Fix off-by-one error in the clock-divider calculations Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:15 ` Thierry Reding
2020-08-31 11:15 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:15 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 10/17] pwm: crc: Fix period changes not having any effect Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:15 ` Thierry Reding
2020-08-31 11:15 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:15 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 11/17] pwm: crc: Enable/disable PWM output on enable/disable Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:16 ` Thierry Reding
2020-08-31 11:16 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:16 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 12/17] pwm: crc: Implement apply() method to support the new atomic PWM API Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:17 ` Thierry Reding
2020-08-31 11:17 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:17 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 13/17] pwm: crc: Implement get_state() method Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-31 11:18 ` Thierry Reding
2020-08-31 11:18 ` [Intel-gfx] " Thierry Reding
2020-08-31 11:18 ` Thierry Reding
2020-08-30 12:57 ` [PATCH v8 14/17] drm/i915: panel: Add get_vbt_pwm_freq() helper Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-30 12:57 ` [PATCH v8 15/17] drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-30 12:57 ` [PATCH v8 16/17] drm/i915: panel: Honor the VBT PWM min setting " Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-30 12:57 ` [PATCH v8 17/17] drm/i915: panel: Use atomic PWM API " Hans de Goede
2020-08-30 12:57 ` [Intel-gfx] " Hans de Goede
2020-08-30 12:57 ` Hans de Goede
2020-08-30 13:25 ` Patchwork [this message]
2020-08-30 13:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success for acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API Patchwork
2020-08-30 15:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-09-03 11:23 [PATCH v10 00/17] " Hans de Goede
2020-09-03 11:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-09-03 10:50 [PATCH v9 00/17] " Hans de Goede
2020-09-03 11:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-08-25 10:00 [PATCH v7 00/16] " Hans de Goede
2020-08-25 10:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-08-24 12:01 [PATCH v6 00/16] " Hans de Goede
2020-08-24 12:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-06-20 12:17 [PATCH v3 00/15] " Hans de Goede
2020-06-20 12:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159879395703.18690.13529871566286732857@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.