From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <broonie@kernel.org>, <tiwai@suse.com>, <matthias.bgg@gmail.com>,
<p.zabel@pengutronix.de>, <tzungbi@google.com>,
<alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <shane.chien@mediatek.com>,
<kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v2 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document
Date: Thu, 22 Oct 2020 18:32:03 +0800 [thread overview]
Message-ID: <1603362723.8921.37.camel@mhfsdcap03> (raw)
In-Reply-To: <20201021145605.GA2775711@bogus>
On Wed, 2020-10-21 at 09:56 -0500, Rob Herring wrote:
> On Wed, Oct 21, 2020 at 04:53:55PM +0800, Jiaxin Yu wrote:
> > This patch adds document for the machine board with mt6358, rt1015
> > and rt5682.
> >
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> > ---
> > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 42 +++++++++++++++++++
> > 1 file changed, 42 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > new file mode 100644
> > index 0000000000000..4c39e88906fc1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
>
> GPL-2.0-only
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver
> > +
> > +maintainers:
> > + - Jiaxin Yu <jiaxin.yu@mediatek.com>
> > + - Shane Chien <shane.chien@mediatek.com>
> > +
> > +description:
> > + This binding describes the MT8192 sound card.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt8192_mt6359_rt1015_rt5682
>
> I still don't think this is the right way to do this.
>
Dear Rob,
This nomencalture is extended to the MTK mt8183/mt8173.
And we think it's better to maintain multiple boards, but
the disadvantage is need to write one more machine drivers.
> > +
> > + mediatek,platform:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: The phandle of MT8192 ASoC platform.
>
> I still don't understand what this is.
>
This property will assign to 'snd_soc_dai_link->platforms->of_node'.
The value of 'mediatek,platform' here is &afe that is mt8192 platform
driver.
It will be resolved from a phandle property to a device_node pointer.
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - mediatek,platform
> > +
> > +examples:
> > + - |
> > +
> > + sound: mt8192-sound {
> > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682";
> > + mediatek,platform = <&afe>;
> > + pinctrl-names = "aud_clk_mosi_off",
> > + "aud_clk_mosi_on";
> > + pinctrl-0 = <&aud_clk_mosi_off>;
> > + pinctrl-1 = <&aud_clk_mosi_on>;
> > + };
> > +
> > +...
> > --
> > 2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, shane.chien@mediatek.com,
tiwai@suse.com, tzungbi@google.com, broonie@kernel.org,
linux-mediatek@lists.infradead.org, p.zabel@pengutronix.de,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document
Date: Thu, 22 Oct 2020 18:32:03 +0800 [thread overview]
Message-ID: <1603362723.8921.37.camel@mhfsdcap03> (raw)
In-Reply-To: <20201021145605.GA2775711@bogus>
On Wed, 2020-10-21 at 09:56 -0500, Rob Herring wrote:
> On Wed, Oct 21, 2020 at 04:53:55PM +0800, Jiaxin Yu wrote:
> > This patch adds document for the machine board with mt6358, rt1015
> > and rt5682.
> >
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> > ---
> > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 42 +++++++++++++++++++
> > 1 file changed, 42 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > new file mode 100644
> > index 0000000000000..4c39e88906fc1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
>
> GPL-2.0-only
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver
> > +
> > +maintainers:
> > + - Jiaxin Yu <jiaxin.yu@mediatek.com>
> > + - Shane Chien <shane.chien@mediatek.com>
> > +
> > +description:
> > + This binding describes the MT8192 sound card.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt8192_mt6359_rt1015_rt5682
>
> I still don't think this is the right way to do this.
>
Dear Rob,
This nomencalture is extended to the MTK mt8183/mt8173.
And we think it's better to maintain multiple boards, but
the disadvantage is need to write one more machine drivers.
> > +
> > + mediatek,platform:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: The phandle of MT8192 ASoC platform.
>
> I still don't understand what this is.
>
This property will assign to 'snd_soc_dai_link->platforms->of_node'.
The value of 'mediatek,platform' here is &afe that is mt8192 platform
driver.
It will be resolved from a phandle property to a device_node pointer.
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - mediatek,platform
> > +
> > +examples:
> > + - |
> > +
> > + sound: mt8192-sound {
> > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682";
> > + mediatek,platform = <&afe>;
> > + pinctrl-names = "aud_clk_mosi_off",
> > + "aud_clk_mosi_on";
> > + pinctrl-0 = <&aud_clk_mosi_off>;
> > + pinctrl-1 = <&aud_clk_mosi_on>;
> > + };
> > +
> > +...
> > --
> > 2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, shane.chien@mediatek.com,
tiwai@suse.com, tzungbi@google.com, broonie@kernel.org,
linux-mediatek@lists.infradead.org, p.zabel@pengutronix.de,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document
Date: Thu, 22 Oct 2020 18:32:03 +0800 [thread overview]
Message-ID: <1603362723.8921.37.camel@mhfsdcap03> (raw)
In-Reply-To: <20201021145605.GA2775711@bogus>
On Wed, 2020-10-21 at 09:56 -0500, Rob Herring wrote:
> On Wed, Oct 21, 2020 at 04:53:55PM +0800, Jiaxin Yu wrote:
> > This patch adds document for the machine board with mt6358, rt1015
> > and rt5682.
> >
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> > ---
> > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 42 +++++++++++++++++++
> > 1 file changed, 42 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > new file mode 100644
> > index 0000000000000..4c39e88906fc1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
>
> GPL-2.0-only
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver
> > +
> > +maintainers:
> > + - Jiaxin Yu <jiaxin.yu@mediatek.com>
> > + - Shane Chien <shane.chien@mediatek.com>
> > +
> > +description:
> > + This binding describes the MT8192 sound card.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt8192_mt6359_rt1015_rt5682
>
> I still don't think this is the right way to do this.
>
Dear Rob,
This nomencalture is extended to the MTK mt8183/mt8173.
And we think it's better to maintain multiple boards, but
the disadvantage is need to write one more machine drivers.
> > +
> > + mediatek,platform:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: The phandle of MT8192 ASoC platform.
>
> I still don't understand what this is.
>
This property will assign to 'snd_soc_dai_link->platforms->of_node'.
The value of 'mediatek,platform' here is &afe that is mt8192 platform
driver.
It will be resolved from a phandle property to a device_node pointer.
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - mediatek,platform
> > +
> > +examples:
> > + - |
> > +
> > + sound: mt8192-sound {
> > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682";
> > + mediatek,platform = <&afe>;
> > + pinctrl-names = "aud_clk_mosi_off",
> > + "aud_clk_mosi_on";
> > + pinctrl-0 = <&aud_clk_mosi_off>;
> > + pinctrl-1 = <&aud_clk_mosi_on>;
> > + };
> > +
> > +...
> > --
> > 2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, shane.chien@mediatek.com,
tiwai@suse.com, tzungbi@google.com, broonie@kernel.org,
linux-mediatek@lists.infradead.org, p.zabel@pengutronix.de,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document
Date: Thu, 22 Oct 2020 18:32:03 +0800 [thread overview]
Message-ID: <1603362723.8921.37.camel@mhfsdcap03> (raw)
In-Reply-To: <20201021145605.GA2775711@bogus>
On Wed, 2020-10-21 at 09:56 -0500, Rob Herring wrote:
> On Wed, Oct 21, 2020 at 04:53:55PM +0800, Jiaxin Yu wrote:
> > This patch adds document for the machine board with mt6358, rt1015
> > and rt5682.
> >
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> > ---
> > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 42 +++++++++++++++++++
> > 1 file changed, 42 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > new file mode 100644
> > index 0000000000000..4c39e88906fc1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
>
> GPL-2.0-only
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver
> > +
> > +maintainers:
> > + - Jiaxin Yu <jiaxin.yu@mediatek.com>
> > + - Shane Chien <shane.chien@mediatek.com>
> > +
> > +description:
> > + This binding describes the MT8192 sound card.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt8192_mt6359_rt1015_rt5682
>
> I still don't think this is the right way to do this.
>
Dear Rob,
This nomencalture is extended to the MTK mt8183/mt8173.
And we think it's better to maintain multiple boards, but
the disadvantage is need to write one more machine drivers.
> > +
> > + mediatek,platform:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: The phandle of MT8192 ASoC platform.
>
> I still don't understand what this is.
>
This property will assign to 'snd_soc_dai_link->platforms->of_node'.
The value of 'mediatek,platform' here is &afe that is mt8192 platform
driver.
It will be resolved from a phandle property to a device_node pointer.
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - mediatek,platform
> > +
> > +examples:
> > + - |
> > +
> > + sound: mt8192-sound {
> > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682";
> > + mediatek,platform = <&afe>;
> > + pinctrl-names = "aud_clk_mosi_off",
> > + "aud_clk_mosi_on";
> > + pinctrl-0 = <&aud_clk_mosi_off>;
> > + pinctrl-1 = <&aud_clk_mosi_on>;
> > + };
> > +
> > +...
> > --
> > 2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-22 10:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 8:53 [PATCH v2 0/5] ASoC: Mediatek: Add support for MT8192 SoC Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` [PATCH v2 1/5] ASoC: mediatek: mt6359: add the calibration functions Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` [PATCH v2 2/5] ASoC: mediatek: mt8192: add platform driver Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 13:23 ` Mark Brown
2020-10-21 13:23 ` Mark Brown
2020-10-21 13:23 ` Mark Brown
2020-10-21 13:23 ` Mark Brown
2020-10-22 10:04 ` Jiaxin Yu
2020-10-22 10:04 ` Jiaxin Yu
2020-10-22 10:04 ` Jiaxin Yu
2020-10-22 10:04 ` Jiaxin Yu
2020-10-22 12:05 ` Mark Brown
2020-10-22 12:05 ` Mark Brown
2020-10-22 12:05 ` Mark Brown
2020-10-22 12:05 ` Mark Brown
2020-10-21 8:53 ` [PATCH v2 3/5] dt-bindings: mediatek: mt8192: add audio afe document Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 14:52 ` Rob Herring
2020-10-21 14:52 ` Rob Herring
2020-10-21 14:52 ` Rob Herring
2020-10-21 14:52 ` Rob Herring
2020-10-21 8:53 ` [PATCH v2 4/5] ASoC: mediatek: mt8192: add machine driver with mt6359, rt1015 and rt5682 Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` [PATCH v2 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 8:53 ` Jiaxin Yu
2020-10-21 14:56 ` Rob Herring
2020-10-21 14:56 ` Rob Herring
2020-10-21 14:56 ` Rob Herring
2020-10-21 14:56 ` Rob Herring
2020-10-22 10:32 ` Jiaxin Yu [this message]
2020-10-22 10:32 ` Jiaxin Yu
2020-10-22 10:32 ` Jiaxin Yu
2020-10-22 10:32 ` Jiaxin Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603362723.8921.37.camel@mhfsdcap03 \
--to=jiaxin.yu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=shane.chien@mediatek.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.