From: Marc Zyngier <maz@kernel.org>
To: kvmarm@lists.cs.columbia.edu, Gavin Shan <gshan@redhat.com>,
Will Deacon <will@kernel.org>
Cc: shan.gavin@gmail.com, linux-kernel@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH] KVM: arm64: Fix masks in stage2_pte_cacheable()
Date: Thu, 29 Oct 2020 21:09:18 +0000 [thread overview]
Message-ID: <160400571841.9348.3202358449739872177.b4-ty@kernel.org> (raw)
In-Reply-To: <20201029144716.30476-1-will@kernel.org>
On Thu, 29 Oct 2020 14:47:16 +0000, Will Deacon wrote:
> stage2_pte_cacheable() tries to figure out whether the mapping installed
> in its 'pte' parameter is cacheable or not. Unfortunately, it fails
> miserably because it extracts the memory attributes from the entry using
> FIELD_GET(), which returns the attributes shifted down to bit 0, but then
> compares this with the unshifted value generated by the PAGE_S2_MEMATTR()
> macro.
>
> [...]
Applied to next, thanks!
[1/1] KVM: arm64: Fix masks in stage2_pte_cacheable()
commit: e2fc6a9f686d037cbd9b08b9fb657685b4a722d3
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: kvmarm@lists.cs.columbia.edu, Gavin Shan <gshan@redhat.com>,
Will Deacon <will@kernel.org>
Cc: kernel-team@android.com, linux-kernel@vger.kernel.org,
shan.gavin@gmail.com
Subject: Re: [PATCH] KVM: arm64: Fix masks in stage2_pte_cacheable()
Date: Thu, 29 Oct 2020 21:09:18 +0000 [thread overview]
Message-ID: <160400571841.9348.3202358449739872177.b4-ty@kernel.org> (raw)
In-Reply-To: <20201029144716.30476-1-will@kernel.org>
On Thu, 29 Oct 2020 14:47:16 +0000, Will Deacon wrote:
> stage2_pte_cacheable() tries to figure out whether the mapping installed
> in its 'pte' parameter is cacheable or not. Unfortunately, it fails
> miserably because it extracts the memory attributes from the entry using
> FIELD_GET(), which returns the attributes shifted down to bit 0, but then
> compares this with the unshifted value generated by the PAGE_S2_MEMATTR()
> macro.
>
> [...]
Applied to next, thanks!
[1/1] KVM: arm64: Fix masks in stage2_pte_cacheable()
commit: e2fc6a9f686d037cbd9b08b9fb657685b4a722d3
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2020-10-29 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 14:47 [PATCH] KVM: arm64: Fix masks in stage2_pte_cacheable() Will Deacon
2020-10-29 21:09 ` Marc Zyngier [this message]
2020-10-29 21:09 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160400571841.9348.3202358449739872177.b4-ty@kernel.org \
--to=maz@kernel.org \
--cc=gshan@redhat.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.